You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/06/18 10:36:31 UTC
[GitHub] [kafka] gunnarmorling opened a new pull request #8895: KAFKA-8398 Avoiding NPE in ByteBufferUnmapper#unmap()
gunnarmorling opened a new pull request #8895:
URL: https://github.com/apache/kafka/pull/8895
Regularly seeing this NPE when shutting down the broker in our tests. I *think* simply returning early in this case should suffice.
Hey @ijuma, could you take a a look at this one perhaps? Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] gunnarmorling commented on pull request #8895: KAFKA-8398 Avoiding NPE in ByteBufferUnmapper#unmap()
Posted by GitBox <gi...@apache.org>.
gunnarmorling commented on pull request #8895:
URL: https://github.com/apache/kafka/pull/8895#issuecomment-648684744
Hey @rhauch, could you pick up and review this one perhaps? Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] gunnarmorling commented on pull request #8895: KAFKA-8398 Avoiding NPE in ByteBufferUnmapper#unmap()
Posted by GitBox <gi...@apache.org>.
gunnarmorling commented on pull request #8895:
URL: https://github.com/apache/kafka/pull/8895#issuecomment-654089873
Makes sense. So I'm going to close this one here, looking forward to the other fix being released soon. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #8895: KAFKA-8398 Avoiding NPE in ByteBufferUnmapper#unmap()
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #8895:
URL: https://github.com/apache/kafka/pull/8895#issuecomment-653965756
Thanks for the PR. This was originally submitted as #7387. I think the approach in that PR is better, so revived it via #8983 (with original authorship preserved).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] gunnarmorling closed pull request #8895: KAFKA-8398 Avoiding NPE in ByteBufferUnmapper#unmap()
Posted by GitBox <gi...@apache.org>.
gunnarmorling closed pull request #8895:
URL: https://github.com/apache/kafka/pull/8895
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org