[GitHub] [iceberg] JingsongLi commented on a change in pull request #1509: Flink: Integrate Flink reader to SQL

[GitBox <gi...@apache.org>]

JingsongLi commented on a change in pull request #1509:
URL: https://github.com/apache/iceberg/pull/1509#discussion_r497875926



##########
File path: flink/src/main/java/org/apache/iceberg/flink/source/FlinkSource.java
##########
@@ -89,8 +88,18 @@ public Builder table(Table newTable) {
       return this;
     }
 
-    public Builder filters(List<Expression> newFilters) {
-      this.filterExpressions = newFilters;
+    public Builder hadoopConf(Configuration newConf) {

Review comment:
       Using `clusterHadoopConf` may not so flexible.
   I am +1 for CatalogLoader should serialize its own Configuration. I will create a PR later for source and sink.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org