You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2017/08/02 16:27:29 UTC

Re: Review Request 61032: Fixed slaves_unreachable metric.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61032/#review181998
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On July 28, 2017, 2:40 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61032/
> -----------------------------------------------------------
> 
> (Updated July 28, 2017, 2:40 p.m.)
> 
> 
> Review request for mesos, Armand Grillet and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> While a gauge for slaves_unreachable was created in master metrics,
> it was not added to the metrics actor and hence was not tracked by
> the metrics subsystem.
> 
> 
> Diffs
> -----
> 
>   src/master/metrics.cpp 646041d53642d6c25c3ea735bd9c87784374084f 
> 
> 
> Diff: https://reviews.apache.org/r/61032/diff/2/
> 
> 
> Testing
> -------
> 
> Augemnted an appropriate test with a check for this metric in https://reviews.apache.org/r/61033/
> 
> See https://reviews.apache.org/r/61030/
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>