You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Azrael Park <az...@nexr.com> on 2014/06/12 04:10:16 UTC
Review Request 22491: OOZIE-1846 Convert CoordActionMaterializeCommand to an
XCommand and remove Command
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22491/
-----------------------------------------------------------
Review request for oozie.
Bugs: OOZIE-1846
https://issues.apache.org/jira/browse/OOZIE-1846
Repository: oozie-git
Description
-------
Use CoordActionMaterializeCommand for dryrun and remove Command.
Change surefire version to 2.12.2 for single method test.
Diffs
-----
core/src/main/java/org/apache/oozie/command/Command.java d3f1011
core/src/main/java/org/apache/oozie/command/CommandException.java ce5ef54
core/src/main/java/org/apache/oozie/command/coord/CoordActionMaterializeCommand.java 6962fb2
core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 515e247
core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 91fb5da
core/src/main/java/org/apache/oozie/command/coord/CoordinatorCommand.java c70e171
core/src/test/java/org/apache/oozie/command/TestCommand.java 60363bf
core/src/test/java/org/apache/oozie/command/coord/TestCoordActionMaterializeCommand.java 6278515
core/src/test/java/org/apache/oozie/command/coord/TestCoordELExtensions.java 7f7a387
core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java 5b22abc
pom.xml b5e0e4e
Diff: https://reviews.apache.org/r/22491/diff/
Testing
-------
Unit test done.
Manual test done.
Thanks,
Azrael Park
Re: Review Request 22491: OOZIE-1846 Convert CoordActionMaterializeCommand
to an XCommand and remove Command
Posted by sh...@inmobi.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22491/#review45575
-----------------------------------------------------------
Looks good otherwise
core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java
<https://reviews.apache.org/r/22491/#comment80477>
You can remove even CoordinatorCommand
core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java
<https://reviews.apache.org/r/22491/#comment80478>
A little refactoring which is better:
Define constructor CoordMaterializeTransitionXCommand(coordJob, startTime, endTime) and call materializeActions(true) directly
- shwethags
On June 12, 2014, 2:10 a.m., Azrael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22491/
> -----------------------------------------------------------
>
> (Updated June 12, 2014, 2:10 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1846
> https://issues.apache.org/jira/browse/OOZIE-1846
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Use CoordActionMaterializeCommand for dryrun and remove Command.
>
> Change surefire version to 2.12.2 for single method test.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/command/Command.java d3f1011
> core/src/main/java/org/apache/oozie/command/CommandException.java ce5ef54
> core/src/main/java/org/apache/oozie/command/coord/CoordActionMaterializeCommand.java 6962fb2
> core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 515e247
> core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 91fb5da
> core/src/main/java/org/apache/oozie/command/coord/CoordinatorCommand.java c70e171
> core/src/test/java/org/apache/oozie/command/TestCommand.java 60363bf
> core/src/test/java/org/apache/oozie/command/coord/TestCoordActionMaterializeCommand.java 6278515
> core/src/test/java/org/apache/oozie/command/coord/TestCoordELExtensions.java 7f7a387
> core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java 5b22abc
> pom.xml b5e0e4e
>
> Diff: https://reviews.apache.org/r/22491/diff/
>
>
> Testing
> -------
>
> Unit test done.
> Manual test done.
>
>
> Thanks,
>
> Azrael Park
>
>
Re: Review Request 22491: OOZIE-1846 Convert CoordActionMaterializeCommand
to an XCommand and remove Command
Posted by Azrael Park <az...@nexr.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22491/#review45578
-----------------------------------------------------------
core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java
<https://reviews.apache.org/r/22491/#comment80480>
I removed it already.
core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java
<https://reviews.apache.org/r/22491/#comment80481>
Yes, comment will be addressed.
- Azrael Park
On June 12, 2014, 2:10 a.m., Azrael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22491/
> -----------------------------------------------------------
>
> (Updated June 12, 2014, 2:10 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1846
> https://issues.apache.org/jira/browse/OOZIE-1846
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Use CoordActionMaterializeCommand for dryrun and remove Command.
>
> Change surefire version to 2.12.2 for single method test.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/command/Command.java d3f1011
> core/src/main/java/org/apache/oozie/command/CommandException.java ce5ef54
> core/src/main/java/org/apache/oozie/command/coord/CoordActionMaterializeCommand.java 6962fb2
> core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 515e247
> core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 91fb5da
> core/src/main/java/org/apache/oozie/command/coord/CoordinatorCommand.java c70e171
> core/src/test/java/org/apache/oozie/command/TestCommand.java 60363bf
> core/src/test/java/org/apache/oozie/command/coord/TestCoordActionMaterializeCommand.java 6278515
> core/src/test/java/org/apache/oozie/command/coord/TestCoordELExtensions.java 7f7a387
> core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java 5b22abc
> pom.xml b5e0e4e
>
> Diff: https://reviews.apache.org/r/22491/diff/
>
>
> Testing
> -------
>
> Unit test done.
> Manual test done.
>
>
> Thanks,
>
> Azrael Park
>
>
Re: Review Request 22491: OOZIE-1846 Convert CoordActionMaterializeCommand
to an XCommand and remove Command
Posted by Purshotam Shah <pu...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22491/#review45580
-----------------------------------------------------------
core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java
<https://reviews.apache.org/r/22491/#comment80482>
3600 is MATERIALIZATION_WINDOW, we have configuration for that. Please use that.
CoordMaterializeTriggerService
int materializationWindow = conf.getInt(CONF_MATERIALIZATION_WINDOW, CONF_MATERIALIZATION_WINDOW_DEFAULT);
core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java
<https://reviews.apache.org/r/22491/#comment80483>
Can you please change this as well.
Replace 3600 as MATERIALIZATION_WINDOW conf, once you do that you can close OOZIE-1845.
- Purshotam Shah
On June 13, 2014, 7:05 a.m., Azrael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22491/
> -----------------------------------------------------------
>
> (Updated June 13, 2014, 7:05 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1846
> https://issues.apache.org/jira/browse/OOZIE-1846
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Use CoordActionMaterializeCommand for dryrun and remove Command.
>
> Change surefire version to 2.12.2 for single method test.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/command/Command.java d3f1011
> core/src/main/java/org/apache/oozie/command/CommandException.java ce5ef54
> core/src/main/java/org/apache/oozie/command/coord/CoordActionMaterializeCommand.java 6962fb2
> core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 515e247
> core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 91fb5da
> core/src/main/java/org/apache/oozie/command/coord/CoordinatorCommand.java c70e171
> core/src/test/java/org/apache/oozie/command/TestCommand.java 60363bf
> core/src/test/java/org/apache/oozie/command/coord/TestCoordActionMaterializeCommand.java 6278515
> core/src/test/java/org/apache/oozie/command/coord/TestCoordELExtensions.java 7f7a387
> core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java 5b22abc
> pom.xml b5e0e4e
>
> Diff: https://reviews.apache.org/r/22491/diff/
>
>
> Testing
> -------
>
> Unit test done.
> Manual test done.
>
>
> Thanks,
>
> Azrael Park
>
>
Re: Review Request 22491: OOZIE-1846 Convert CoordActionMaterializeCommand
to an XCommand and remove Command
Posted by Azrael Park <az...@nexr.com>.
> On June 13, 2014, 9:52 a.m., shwethags wrote:
> > core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java, line 388
> > <https://reviews.apache.org/r/22491/diff/2/?file=608456#file608456line388>
> >
> > For dryRun, the coord is not in DB. So, can you change addRecordToCoordJobTable to createCoordJob.
> >
> > Also checkCoordActions is not required.
> >
comment addressed.
- Azrael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22491/#review45603
-----------------------------------------------------------
On June 16, 2014, 5:48 a.m., Azrael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22491/
> -----------------------------------------------------------
>
> (Updated June 16, 2014, 5:48 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1846
> https://issues.apache.org/jira/browse/OOZIE-1846
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Use CoordActionMaterializeCommand for dryrun and remove Command.
>
> Change surefire version to 2.12.2 for single method test.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/command/Command.java d3f1011
> core/src/main/java/org/apache/oozie/command/CommandException.java ce5ef54
> core/src/main/java/org/apache/oozie/command/coord/CoordActionMaterializeCommand.java 6962fb2
> core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 515e247
> core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 91fb5da
> core/src/main/java/org/apache/oozie/command/coord/CoordinatorCommand.java c70e171
> core/src/main/java/org/apache/oozie/service/CoordMaterializeTriggerService.java d2b5a6c
> core/src/test/java/org/apache/oozie/command/TestCommand.java 60363bf
> core/src/test/java/org/apache/oozie/command/coord/TestCoordActionMaterializeCommand.java 6278515
> core/src/test/java/org/apache/oozie/command/coord/TestCoordELExtensions.java 7f7a387
> core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java 5b22abc
> pom.xml b5e0e4e
>
> Diff: https://reviews.apache.org/r/22491/diff/
>
>
> Testing
> -------
>
> Unit test done.
> Manual test done.
>
>
> Thanks,
>
> Azrael Park
>
>
Re: Review Request 22491: OOZIE-1846 Convert CoordActionMaterializeCommand
to an XCommand and remove Command
Posted by sh...@inmobi.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22491/#review45603
-----------------------------------------------------------
core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java
<https://reviews.apache.org/r/22491/#comment80487>
For dryRun, the coord is not in DB. So, can you change addRecordToCoordJobTable to createCoordJob.
Also checkCoordActions is not required.
- shwethags
On June 13, 2014, 7:05 a.m., Azrael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22491/
> -----------------------------------------------------------
>
> (Updated June 13, 2014, 7:05 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1846
> https://issues.apache.org/jira/browse/OOZIE-1846
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Use CoordActionMaterializeCommand for dryrun and remove Command.
>
> Change surefire version to 2.12.2 for single method test.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/command/Command.java d3f1011
> core/src/main/java/org/apache/oozie/command/CommandException.java ce5ef54
> core/src/main/java/org/apache/oozie/command/coord/CoordActionMaterializeCommand.java 6962fb2
> core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 515e247
> core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 91fb5da
> core/src/main/java/org/apache/oozie/command/coord/CoordinatorCommand.java c70e171
> core/src/test/java/org/apache/oozie/command/TestCommand.java 60363bf
> core/src/test/java/org/apache/oozie/command/coord/TestCoordActionMaterializeCommand.java 6278515
> core/src/test/java/org/apache/oozie/command/coord/TestCoordELExtensions.java 7f7a387
> core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java 5b22abc
> pom.xml b5e0e4e
>
> Diff: https://reviews.apache.org/r/22491/diff/
>
>
> Testing
> -------
>
> Unit test done.
> Manual test done.
>
>
> Thanks,
>
> Azrael Park
>
>
Re: Review Request 22491: OOZIE-1846 Convert CoordActionMaterializeCommand
to an XCommand and remove Command
Posted by sh...@inmobi.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22491/#review45719
-----------------------------------------------------------
Ship it!
Ship It!
- shwethags
On June 16, 2014, 5:48 a.m., Azrael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22491/
> -----------------------------------------------------------
>
> (Updated June 16, 2014, 5:48 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1846
> https://issues.apache.org/jira/browse/OOZIE-1846
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Use CoordActionMaterializeCommand for dryrun and remove Command.
>
> Change surefire version to 2.12.2 for single method test.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/command/Command.java d3f1011
> core/src/main/java/org/apache/oozie/command/CommandException.java ce5ef54
> core/src/main/java/org/apache/oozie/command/coord/CoordActionMaterializeCommand.java 6962fb2
> core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 515e247
> core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 91fb5da
> core/src/main/java/org/apache/oozie/command/coord/CoordinatorCommand.java c70e171
> core/src/main/java/org/apache/oozie/service/CoordMaterializeTriggerService.java d2b5a6c
> core/src/test/java/org/apache/oozie/command/TestCommand.java 60363bf
> core/src/test/java/org/apache/oozie/command/coord/TestCoordActionMaterializeCommand.java 6278515
> core/src/test/java/org/apache/oozie/command/coord/TestCoordELExtensions.java 7f7a387
> core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java 5b22abc
> pom.xml b5e0e4e
>
> Diff: https://reviews.apache.org/r/22491/diff/
>
>
> Testing
> -------
>
> Unit test done.
> Manual test done.
>
>
> Thanks,
>
> Azrael Park
>
>
Re: Review Request 22491: OOZIE-1846 Convert CoordActionMaterializeCommand
to an XCommand and remove Command
Posted by Azrael Park <az...@nexr.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22491/
-----------------------------------------------------------
(Updated June 16, 2014, 5:48 a.m.)
Review request for oozie.
Changes
-------
Used CONF_MATERIALIZATION_WINDOW, CONF_MATERIALIZATION_WINDOW_DEFAULT instead 3600.
Used createCoordJob instead addRecordToCoordJobTable.
Bugs: OOZIE-1846
https://issues.apache.org/jira/browse/OOZIE-1846
Repository: oozie-git
Description
-------
Use CoordActionMaterializeCommand for dryrun and remove Command.
Change surefire version to 2.12.2 for single method test.
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/command/Command.java d3f1011
core/src/main/java/org/apache/oozie/command/CommandException.java ce5ef54
core/src/main/java/org/apache/oozie/command/coord/CoordActionMaterializeCommand.java 6962fb2
core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 515e247
core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 91fb5da
core/src/main/java/org/apache/oozie/command/coord/CoordinatorCommand.java c70e171
core/src/main/java/org/apache/oozie/service/CoordMaterializeTriggerService.java d2b5a6c
core/src/test/java/org/apache/oozie/command/TestCommand.java 60363bf
core/src/test/java/org/apache/oozie/command/coord/TestCoordActionMaterializeCommand.java 6278515
core/src/test/java/org/apache/oozie/command/coord/TestCoordELExtensions.java 7f7a387
core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java 5b22abc
pom.xml b5e0e4e
Diff: https://reviews.apache.org/r/22491/diff/
Testing
-------
Unit test done.
Manual test done.
Thanks,
Azrael Park
Re: Review Request 22491: OOZIE-1846 Convert CoordActionMaterializeCommand
to an XCommand and remove Command
Posted by Azrael Park <az...@nexr.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22491/
-----------------------------------------------------------
(Updated June 13, 2014, 7:05 a.m.)
Review request for oozie.
Changes
-------
comment addressed.
Bugs: OOZIE-1846
https://issues.apache.org/jira/browse/OOZIE-1846
Repository: oozie-git
Description
-------
Use CoordActionMaterializeCommand for dryrun and remove Command.
Change surefire version to 2.12.2 for single method test.
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/command/Command.java d3f1011
core/src/main/java/org/apache/oozie/command/CommandException.java ce5ef54
core/src/main/java/org/apache/oozie/command/coord/CoordActionMaterializeCommand.java 6962fb2
core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 515e247
core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 91fb5da
core/src/main/java/org/apache/oozie/command/coord/CoordinatorCommand.java c70e171
core/src/test/java/org/apache/oozie/command/TestCommand.java 60363bf
core/src/test/java/org/apache/oozie/command/coord/TestCoordActionMaterializeCommand.java 6278515
core/src/test/java/org/apache/oozie/command/coord/TestCoordELExtensions.java 7f7a387
core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java 5b22abc
pom.xml b5e0e4e
Diff: https://reviews.apache.org/r/22491/diff/
Testing
-------
Unit test done.
Manual test done.
Thanks,
Azrael Park