You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/04/12 13:51:08 UTC
[GitHub] [incubator-echarts] BonGrace opened a new pull request #12418: Fix
12109
BonGrace opened a new pull request #12418: Fix 12109
URL: https://github.com/apache/incubator-echarts/pull/12418
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [x] bug fixing
- [ ] new feature
- [ ] others
### What does this PR do?
<!-- USE ONCE SENTENCE TO DESCRIBE WHAT THIS PR DOES. -->
correct bar polar rendering negative values
### Fixed issues
https://github.com/apache/incubator-echarts/issues/12109
<!--
- #xxxx: ...
-->
## Details
### Before: What was the problem?
<!-- DESCRIBE THE BUG OR REQUIREMENT HERE. -->
<!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
### After: How is it fixed in this PR?
<!-- THE RESULT AFTER FIXING AND A SIMPLE EXPLANATION ABOUT HOW IT IS FIXED. -->
<!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
## Usage
### Are there any API changes?
- [ ] The API has been changed.
<!-- LIST THE API CHANGES HERE -->
### Related test cases or examples to use the new APIs
NA.
## Others
### Merging options
- [ ] Please squash the commits into a single one when merge.
### Other information
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] Ovilia commented on a change in pull request
#12418: Fix 12109
Posted by GitBox <gi...@apache.org>.
Ovilia commented on a change in pull request #12418: Fix 12109
URL: https://github.com/apache/incubator-echarts/pull/12418#discussion_r407895981
##########
File path: src/layout/barPolar.js
##########
@@ -83,6 +83,19 @@ function barLayoutPolar(seriesType, ecModel, api) {
|| !seriesModel.get('roundCap', true);
var valueAxisStart = valueAxis.getExtent()[0];
+ var radiusValueAxisStart;
+ if (valueAxis.dim === 'radius') {
+ radiusValueAxisStart = valueAxis.model.option.min || valueAxis.getExtent()[0];
+ if (valueAxis.model.option.min && valueAxis.model.option.min < 0) {
+ if (!valueAxis.model.option.max
+ || valueAxis.model.option.max && valueAxis.model.option.max > 0) {
+ radiusValueAxisStart = valueAxis.getExtent()[0];
+ } else if (valueAxis.model.option.max && valueAxis.model.option.max < 0) {
+ radiusValueAxisStart = valueAxis.model.option.max;
+ }
+ }
+ }
+
Review comment:
`valueAxisStart` means the `0` position in the axis extent. You don't need to do all these logics to calculate the `max` because it's already in `valueAxis.scale.getExtent()`.
So my suggestion for this part would be only:
```js
var valueAxisStart = valueAxis.dim === 'radius'
? valueAxis.dataToRadius(0)
: valueAxis.dataToAngle(0);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] Ovilia commented on a change in pull request
#12418: Fix 12109
Posted by GitBox <gi...@apache.org>.
Ovilia commented on a change in pull request #12418: Fix 12109
URL: https://github.com/apache/incubator-echarts/pull/12418#discussion_r407897310
##########
File path: src/layout/barPolar.js
##########
@@ -112,7 +132,7 @@ function barLayoutPolar(seriesType, ecModel, api) {
// radial sector
if (valueAxis.dim === 'radius') {
- var radiusSpan = valueAxis.dataToRadius(value) - valueAxisStart;
+ var radiusSpan = valueAxis.dataToRadius(value) - valueAxis.dataToRadius(valueAxis.getExtent()[0])
Review comment:
This should stay unchanged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #12418: Fix
12109
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on issue #12418: Fix 12109
URL: https://github.com/apache/incubator-echarts/pull/12418#issuecomment-612617751
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] Ovilia commented on a change in pull request
#12418: Fix 12109
Posted by GitBox <gi...@apache.org>.
Ovilia commented on a change in pull request #12418: Fix 12109
URL: https://github.com/apache/incubator-echarts/pull/12418#discussion_r407898556
##########
File path: test/polarLine2.html
##########
@@ -83,5 +88,109 @@
})
</script>
+
+ <script>
+ require([
+ 'echarts'
+ ], function (echarts) {
+
+ var chart = echarts.init(document.getElementById('polar-negative'), null, {});
+
+ var data = [];
+
+ chart.setOption({
+ angleAxis: {
+ type: 'category',
+ data: ['S1', 'S2', 'S3']
+ },
+ radiusAxis: {
+ min:-1,
+ max: 3
+ },
+ polar: {
+ },
+ series: [{
+ type: 'bar',
+ data: [1, 1, 1],
+ coordinateSystem: 'polar',
+ itemStyle:{
+ color:"blue"
+ },
+ name: 'A',
+ stack: 'a'
+ }, {
+ type: 'bar',
+ data: [1, 1, 1],
+ coordinateSystem: 'polar',
+ name: 'B',
+ stack: 'a'
+ }, {
+ type: 'bar',
+ data: [1, 1, 1],
+ coordinateSystem: 'polar',
+ name: 'C',
+ stack: 'a'
+ }],
+ legend: {
+ show: true,
+ data: ['A', 'B', 'C']
+ }
+ });
+ })
+ </script>
Review comment:
Please add another test case here:
```js
chart.setOption({
angleAxis: {
min:-1,
max: 3
},
radiusAxis: {
type: 'category',
data: ['S1', 'S2', 'S3']
},
polar: {
},
series: [{
type: 'bar',
data: [1, 1, 1],
coordinateSystem: 'polar',
itemStyle:{
color:"blue"
},
name: 'A',
stack: 'a'
}, {
type: 'bar',
data: [1, 1, 1],
coordinateSystem: 'polar',
name: 'B',
stack: 'a'
}, {
type: 'bar',
data: [1, 1, 1],
coordinateSystem: 'polar',
name: 'C',
stack: 'a'
}],
legend: {
show: true,
data: ['A', 'B', 'C']
}
});
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] Ovilia commented on a change in pull request
#12418: Fix 12109
Posted by GitBox <gi...@apache.org>.
Ovilia commented on a change in pull request #12418: Fix 12109
URL: https://github.com/apache/incubator-echarts/pull/12418#discussion_r407896843
##########
File path: src/layout/barPolar.js
##########
@@ -95,11 +108,18 @@ function barLayoutPolar(seriesType, ecModel, api) {
// stackResultDimension directly.
// Only ordinal axis can be stacked.
if (stacked) {
+
if (!lastStackCoords[stackId][baseValue]) {
lastStackCoords[stackId][baseValue] = {
p: valueAxisStart, // Positive stack
n: valueAxisStart // Negative stack
};
+ if (valueAxis.dim === 'radius') {
+ lastStackCoords[stackId][baseValue] = {
+ p: valueAxis.dataToRadius(radiusValueAxisStart), // Positive stack
+ n: valueAxis.dataToRadius(radiusValueAxisStart) // Negative stack
+ };
+ }
Review comment:
These are probably not needed since we have calculated `valueAxisStart` above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] Ovilia commented on a change in pull request
#12418: Fix 12109
Posted by GitBox <gi...@apache.org>.
Ovilia commented on a change in pull request #12418: Fix 12109
URL: https://github.com/apache/incubator-echarts/pull/12418#discussion_r407897991
##########
File path: test/polarLine2.html
##########
@@ -26,12 +26,17 @@
</head>
<body>
<style>
- html, body, #main {
+ html, body, .test-chart {
width: 100%;
height: 100%;
}
</style>
- <div id="main"></div>
+ <h1>main</h1>
Review comment:
Please do not change in this file because this is for line series in polar system. Consider moving to `bar-polar-stack.html`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] BonGrace edited a comment on issue #12418: Fix 12109
Posted by GitBox <gi...@apache.org>.
BonGrace edited a comment on issue #12418:
URL: https://github.com/apache/incubator-echarts/pull/12418#issuecomment-617008259
> > > > > I mean the user.name and user.email of you git. It seems like you didn't use your github account to push commit
> > > >
> > > >
> > > > I got your point. Should I change account and commit again?
> > >
> > >
> > > That won't be necessary, Squash all commits then merge can do the job. I think.
> >
> >
> > Thanks, I'll make a try.
>
> Or you can force push.
Do you know where to see if I had done right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] BonGrace commented on issue #12418: Fix 12109
Posted by GitBox <gi...@apache.org>.
BonGrace commented on issue #12418:
URL: https://github.com/apache/incubator-echarts/pull/12418#issuecomment-617663583
@susiwen8 Clear, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] Ovilia commented on a change in pull request #12418: Fix 12109
Posted by GitBox <gi...@apache.org>.
Ovilia commented on a change in pull request #12418:
URL: https://github.com/apache/incubator-echarts/pull/12418#discussion_r414271701
##########
File path: src/layout/barPolar.js
##########
@@ -75,15 +76,26 @@ function barLayoutPolar(seriesType, ecModel, api) {
var barMinAngle = seriesModel.get('barMinAngle') || 0;
lastStackCoords[stackId] = lastStackCoords[stackId] || [];
+ lastStackSum[stackId] = lastStackSum[stackId] || [];
var valueDim = data.mapDimension(valueAxis.dim);
var baseDim = data.mapDimension(baseAxis.dim);
var stacked = isDimensionStacked(data, valueDim /*, baseDim*/);
var clampLayout = baseAxis.dim !== 'radius'
|| !seriesModel.get('roundCap', true);
- var valueAxisStart = valueAxis.getExtent()[0];
-
+ // valueAxisStart may not always be 0 consider of scale extent min and max
+ var radiusValueAxisStart;
+ if(valueAxis.scale.getExtent()[1] < 0) {
Review comment:
Probably should consider `value` instead of extent. See https://github.com/apache/incubator-echarts/blob/c11c48343f6606fca65721a2eb65a7464791b592/src/layout/barGrid.js#L276
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] Ovilia commented on a change in pull request #12418: Fix 12109
Posted by GitBox <gi...@apache.org>.
Ovilia commented on a change in pull request #12418:
URL: https://github.com/apache/incubator-echarts/pull/12418#discussion_r431009173
##########
File path: test/bar-polar-stack.html
##########
@@ -91,5 +104,205 @@
window.onresize = chart.resize;
});
</script>
+ <script>
+ require([
+ 'echarts'
+ ], function (echarts) {
+
+ var chart = echarts.init(document.getElementById('polar-negative'), null, {});
+
+ var data = [];
+
+ chart.setOption({
+ angleAxis: {
+ type: 'category',
+ data: ['S1', 'S2', 'S3']
+ },
+ radiusAxis: {
+ min:-1,
+ max: 3
+ },
+ polar: {
Review comment:
Try adding `radius: [50, 200]` to all `polar` in the test cases to find potential bugs.
##########
File path: src/layout/barPolar.js
##########
@@ -95,6 +96,7 @@ function barLayoutPolar(seriesType, ecModel, api) {
// stackResultDimension directly.
// Only ordinal axis can be stacked.
if (stacked) {
+
Review comment:
You may remove this empty line.
##########
File path: src/chart/bar/BarView.js
##########
@@ -336,8 +336,14 @@ var clip = {
return clipped;
},
- polar: function (coordSysClipArea) {
- return false;
+ polar: function (coordSysClipArea, layout) {
+ var clipped = (layout.r - coordSysClipArea.r > 0 && layout.r0 - coordSysClipArea.r > 0)
+ var r = mathMin(layout.r, coordSysClipArea.r);
+ var r0 = mathMin(layout.r0, coordSysClipArea.r);
+
+ layout.r = r;
+ layout.r0 = r0;
+ return clipped;
Review comment:
When adding `radius: [50, 200]` to the last test case, you may find the clipping algorithm is not correct.
According to the clipping algorithm of cartesian2d, I think this may be changed into:
```js
var signR = layout.r0 <= layout.r ? 1 : -1;
// Make sure r is larger than r0
if (signR < 0) {
var r = layout.r;
layout.r = layout.r0;
layout.r0 = r;
}
var r = mathMin(layout.r, coordSysClipArea.r);
var r0 = mathMax(layout.r0, coordSysClipArea.r0);
layout.r = r;
layout.r0 = r0;
var clipped = r - r0 < 0;
// Reverse back
if (signR < 0) {
var r = layout.r;
layout.r = layout.r0;
layout.r0 = r;
}
return clipped;
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] susiwen8 commented on issue #12418: Fix 12109
Posted by GitBox <gi...@apache.org>.
susiwen8 commented on issue #12418:
URL: https://github.com/apache/incubator-echarts/pull/12418#issuecomment-616364265
Did you set correct user.name and user.email?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] BonGrace commented on issue #12418: Fix 12109
Posted by GitBox <gi...@apache.org>.
BonGrace commented on issue #12418:
URL: https://github.com/apache/incubator-echarts/pull/12418#issuecomment-616366672
> Did you set correct user.name and user.email?
Sorry, not quite sure of the problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] Ovilia merged pull request #12418: Fix 12109
Posted by GitBox <gi...@apache.org>.
Ovilia merged pull request #12418:
URL: https://github.com/apache/incubator-echarts/pull/12418
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] BonGrace commented on issue #12418: Fix 12109
Posted by GitBox <gi...@apache.org>.
BonGrace commented on issue #12418:
URL: https://github.com/apache/incubator-echarts/pull/12418#issuecomment-616359251
1. remove min max calculation logic with axis.scale.getExtent()
2. moved cases to bar-polar-stack.html
3. add more cases
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] susiwen8 commented on issue #12418: Fix 12109
Posted by GitBox <gi...@apache.org>.
susiwen8 commented on issue #12418:
URL: https://github.com/apache/incubator-echarts/pull/12418#issuecomment-616932272
> > > > I mean the user.name and user.email of you git. It seems like you didn't use your github account to push commit
> > >
> > >
> > > I got your point. Should I change account and commit again?
> >
> >
> > That won't be necessary, Squash all commits then merge can do the job. I think.
>
> Thanks, I'll make a try.
Or you can force push.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] susiwen8 commented on issue #12418: Fix 12109
Posted by GitBox <gi...@apache.org>.
susiwen8 commented on issue #12418:
URL: https://github.com/apache/incubator-echarts/pull/12418#issuecomment-617031086
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] BonGrace commented on issue #12418: Fix 12109
Posted by GitBox <gi...@apache.org>.
BonGrace commented on issue #12418:
URL: https://github.com/apache/incubator-echarts/pull/12418#issuecomment-617008259
> > > > > I mean the user.name and user.email of you git. It seems like you didn't use your github account to push commit
> > > >
> > > >
> > > > I got your point. Should I change account and commit again?
> > >
> > >
> > > That won't be necessary, Squash all commits then merge can do the job. I think.
> >
> >
> > Thanks, I'll make a try.
>
> Or you can force push.
Do you know where to see if I have done right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #12418: Fix 12109
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #12418:
URL: https://github.com/apache/incubator-echarts/pull/12418#issuecomment-635069642
Congratulations! Your PR has been merged. Thanks for your contribution! 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] susiwen8 commented on issue #12418: Fix 12109
Posted by GitBox <gi...@apache.org>.
susiwen8 commented on issue #12418:
URL: https://github.com/apache/incubator-echarts/pull/12418#issuecomment-616927876
> > I mean the user.name and user.email of you git. It seems like you didn't use your github account to push commit
>
> I got your point. Should I change account and commit again?
That won't be necessary, Squash all commits then merge can do the job. I think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] susiwen8 commented on issue #12418: Fix 12109
Posted by GitBox <gi...@apache.org>.
susiwen8 commented on issue #12418:
URL: https://github.com/apache/incubator-echarts/pull/12418#issuecomment-616367767
I mean the user.name and user.email of you git. It seems like you didn't use your github account to push commit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] BonGrace commented on issue #12418: Fix 12109
Posted by GitBox <gi...@apache.org>.
BonGrace commented on issue #12418:
URL: https://github.com/apache/incubator-echarts/pull/12418#issuecomment-616920493
> I mean the user.name and user.email of you git. It seems like you didn't use your github account to push commit
I got your point. Should I change account and commit again?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] BonGrace commented on issue #12418: Fix 12109
Posted by GitBox <gi...@apache.org>.
BonGrace commented on issue #12418:
URL: https://github.com/apache/incubator-echarts/pull/12418#issuecomment-616931826
> > > I mean the user.name and user.email of you git. It seems like you didn't use your github account to push commit
> >
> >
> > I got your point. Should I change account and commit again?
>
> That won't be necessary, Squash all commits then merge can do the job. I think.
Thanks, I'll make a try.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org