You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2018/10/11 06:25:17 UTC
[kudu-CR] log cache: fix MemTracker name
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11654
Change subject: log_cache: fix MemTracker name
......................................................................
log_cache: fix MemTracker name
This caused all of the MemTracker ids in the web ui to show up as
"log_cache::".
Change-Id: I9d482c9e242b271bd8e6a33ad4090cbdeafc1c63
---
M src/kudu/consensus/log_cache.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/11654/1
--
To view, visit http://gerrit.cloudera.org:8080/11654
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9d482c9e242b271bd8e6a33ad4090cbdeafc1c63
Gerrit-Change-Number: 11654
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
[kudu-CR] log cache: fix MemTracker name
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11654 )
Change subject: log_cache: fix MemTracker name
......................................................................
log_cache: fix MemTracker name
This caused all of the MemTracker ids in the web ui to show up as
"log_cache::".
Change-Id: I9d482c9e242b271bd8e6a33ad4090cbdeafc1c63
Reviewed-on: http://gerrit.cloudera.org:8080/11654
Tested-by: Kudu Jenkins
Reviewed-by: Will Berkeley <wd...@gmail.com>
---
M src/kudu/consensus/log_cache.cc
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Kudu Jenkins: Verified
Will Berkeley: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/11654
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9d482c9e242b271bd8e6a33ad4090cbdeafc1c63
Gerrit-Change-Number: 11654
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] log cache: fix MemTracker name
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11654 )
Change subject: log_cache: fix MemTracker name
......................................................................
Patch Set 1: Code-Review+2
C++ move semantics :( when will it be rust time :)
--
To view, visit http://gerrit.cloudera.org:8080/11654
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9d482c9e242b271bd8e6a33ad4090cbdeafc1c63
Gerrit-Change-Number: 11654
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 11 Oct 2018 16:42:36 +0000
Gerrit-HasComments: No