You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Dmitriy V. Ryaboy (JIRA)" <ji...@apache.org> on 2010/02/03 17:45:27 UTC

[jira] Commented: (PIG-1217) [piggybank] evaluation.util.Top is broken

    [ https://issues.apache.org/jira/browse/PIG-1217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12829137#action_12829137 ] 

Dmitriy V. Ryaboy commented on PIG-1217:
----------------------------------------

Attached patch fixes the issue.

While I was in there, I also made it algebraic, and reduced the amount of reflection this function required (it used to call instanceof twice for every comparison operation, several of which may be needed for every tuple).

This patch should apply to 0.6 as well.

> [piggybank] evaluation.util.Top is broken
> -----------------------------------------
>
>                 Key: PIG-1217
>                 URL: https://issues.apache.org/jira/browse/PIG-1217
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.3.0, 0.3.1, 0.4.0, site, 0.5.0, 0.6.0, 0.7.0
>            Reporter: Dmitriy V. Ryaboy
>            Assignee: Dmitriy V. Ryaboy
>            Priority: Minor
>             Fix For: 0.7.0
>
>         Attachments: fix_top_udf.diff
>
>
> The Top udf has been broken for a while, due to an incorrect implementation of getArgToFuncMapping.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.