You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "swaminathanmanish (via GitHub)" <gi...@apache.org> on 2023/04/19 16:31:28 UTC

[GitHub] [pinot] swaminathanmanish commented on a diff in pull request #10630: Adding an parameter (toSegments) to the endSegmentReplacement API

swaminathanmanish commented on code in PR #10630:
URL: https://github.com/apache/pinot/pull/10630#discussion_r1171589878


##########
pinot-common/src/main/java/org/apache/pinot/common/restlet/resources/EndReplaceSegmentsRequest.java:
##########
@@ -0,0 +1,42 @@
+package org.apache.pinot.common.restlet.resources;
+
+import com.fasterxml.jackson.annotation.JsonProperty;
+import java.util.Collections;
+import java.util.List;
+import javax.annotation.Nullable;
+
+/**

Review Comment:
   > Can we move this header to the top of the code? (above the `package org.apache.pinot....`
   
   ah thanks for catching !



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org