You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Alex Astapchuk (JIRA)" <ji...@apache.org> on 2006/12/15 14:40:21 UTC
[jira] Created: (HARMONY-2746) [drlvm][EXPERIMENTAL]Optimized
ld_interface_vtable.
[drlvm][EXPERIMENTAL]Optimized ld_interface_vtable.
---------------------------------------------------
Key: HARMONY-2746
URL: http://issues.apache.org/jira/browse/HARMONY-2746
Project: Harmony
Issue Type: Improvement
Components: DRLVM
Reporter: Alex Astapchuk
Priority: Trivial
Attachments: 0001-drlvm-EXPERIMENTAL-Optimized-ld_interface_vtable.txt
Attached is a try to optimize ld_interface_vtable helper to make it faster.
Note to commiters: please, do NOT commit it into the main trunk.
This is extremely experimental, and its effect need to be carefully measured.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-2746) [drlvm][EXPERIMENTAL]Optimized
ld_interface_vtable.
Posted by "Mikhail Fursov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2746?page=comments#action_12458796 ]
Mikhail Fursov commented on HARMONY-2746:
-----------------------------------------
I'm going to provide complete testing for this patch and new inlined version for this helper.
> [drlvm][EXPERIMENTAL]Optimized ld_interface_vtable.
> ---------------------------------------------------
>
> Key: HARMONY-2746
> URL: http://issues.apache.org/jira/browse/HARMONY-2746
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Alex Astapchuk
> Priority: Trivial
> Attachments: 0001-drlvm-EXPERIMENTAL-Optimized-ld_interface_vtable.txt
>
>
> Attached is a try to optimize ld_interface_vtable helper to make it faster.
> Note to commiters: please, do NOT commit it into the main trunk.
> This is extremely experimental, and its effect need to be carefully measured.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-2746) [drlvm][EXPERIMENTAL]Optimized
ld_interface_vtable.
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-2746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexey Varlamov closed HARMONY-2746.
------------------------------------
Resolution: Fixed
> [drlvm][EXPERIMENTAL]Optimized ld_interface_vtable.
> ---------------------------------------------------
>
> Key: HARMONY-2746
> URL: https://issues.apache.org/jira/browse/HARMONY-2746
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Alex Astapchuk
> Assigned To: Alexey Varlamov
> Priority: Trivial
> Attachments: 0001-drlvm-EXPERIMENTAL-Optimized-ld_interface_vtable.txt, intf1.diff, intf2.diff
>
>
> Attached is a try to optimize ld_interface_vtable helper to make it faster.
> Note to commiters: please, do NOT commit it into the main trunk.
> This is extremely experimental, and its effect need to be carefully measured.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-2746) [drlvm][EXPERIMENTAL]Optimized
ld_interface_vtable.
Posted by "Mikhail Fursov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2746?page=all ]
Mikhail Fursov updated HARMONY-2746:
------------------------------------
Attachment: intf2.diff
Pavel, I fixed initialization issue: intf2.diff
As for item 2) I disabled fast path when VM_STATS is defined to make statistics more accurate.
> [drlvm][EXPERIMENTAL]Optimized ld_interface_vtable.
> ---------------------------------------------------
>
> Key: HARMONY-2746
> URL: http://issues.apache.org/jira/browse/HARMONY-2746
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Alex Astapchuk
> Priority: Trivial
> Attachments: 0001-drlvm-EXPERIMENTAL-Optimized-ld_interface_vtable.txt, intf1.diff, intf2.diff
>
>
> Attached is a try to optimize ld_interface_vtable helper to make it faster.
> Note to commiters: please, do NOT commit it into the main trunk.
> This is extremely experimental, and its effect need to be carefully measured.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-2746) [drlvm][EXPERIMENTAL]Optimized
ld_interface_vtable.
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2746?page=all ]
Alexey Varlamov reassigned HARMONY-2746:
----------------------------------------
Assignee: Alexey Varlamov
> [drlvm][EXPERIMENTAL]Optimized ld_interface_vtable.
> ---------------------------------------------------
>
> Key: HARMONY-2746
> URL: http://issues.apache.org/jira/browse/HARMONY-2746
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Alex Astapchuk
> Assigned To: Alexey Varlamov
> Priority: Trivial
> Attachments: 0001-drlvm-EXPERIMENTAL-Optimized-ld_interface_vtable.txt, intf1.diff, intf2.diff
>
>
> Attached is a try to optimize ld_interface_vtable helper to make it faster.
> Note to commiters: please, do NOT commit it into the main trunk.
> This is extremely experimental, and its effect need to be carefully measured.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-2746) [drlvm][EXPERIMENTAL]Optimized
ld_interface_vtable.
Posted by "Alex Astapchuk (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2746?page=all ]
Alex Astapchuk updated HARMONY-2746:
------------------------------------
Attachment: 0001-drlvm-EXPERIMENTAL-Optimized-ld_interface_vtable.txt
> [drlvm][EXPERIMENTAL]Optimized ld_interface_vtable.
> ---------------------------------------------------
>
> Key: HARMONY-2746
> URL: http://issues.apache.org/jira/browse/HARMONY-2746
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Alex Astapchuk
> Priority: Trivial
> Attachments: 0001-drlvm-EXPERIMENTAL-Optimized-ld_interface_vtable.txt
>
>
> Attached is a try to optimize ld_interface_vtable helper to make it faster.
> Note to commiters: please, do NOT commit it into the main trunk.
> This is extremely experimental, and its effect need to be carefully measured.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-2746) [drlvm][EXPERIMENTAL]Optimized
ld_interface_vtable.
Posted by "Mikhail Fursov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2746?page=all ]
Mikhail Fursov updated HARMONY-2746:
------------------------------------
Attachment: intf1.diff
updated and tested patch
> [drlvm][EXPERIMENTAL]Optimized ld_interface_vtable.
> ---------------------------------------------------
>
> Key: HARMONY-2746
> URL: http://issues.apache.org/jira/browse/HARMONY-2746
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Alex Astapchuk
> Priority: Trivial
> Attachments: 0001-drlvm-EXPERIMENTAL-Optimized-ld_interface_vtable.txt, intf1.diff
>
>
> Attached is a try to optimize ld_interface_vtable helper to make it faster.
> Note to commiters: please, do NOT commit it into the main trunk.
> This is extremely experimental, and its effect need to be carefully measured.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-2746) [drlvm][EXPERIMENTAL]Optimized
ld_interface_vtable.
Posted by "Pavel Pervov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2746?page=comments#action_12459598 ]
Pavel Pervov commented on HARMONY-2746:
---------------------------------------
I've reviewed updated patch. It generally looks ok.
The list of things I would fix:
1) Comment for added fields does not describe m_intf_table_<N> members, it only refers to m_intf_<N>
2) Not sure why the fast path is under '#ifndef VM_STATS' preprocessing
3) All new fields must be initialized explicitly in Class::init_internals. memset at the beginning of that method is erroneous and will be removed.
> [drlvm][EXPERIMENTAL]Optimized ld_interface_vtable.
> ---------------------------------------------------
>
> Key: HARMONY-2746
> URL: http://issues.apache.org/jira/browse/HARMONY-2746
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Alex Astapchuk
> Priority: Trivial
> Attachments: 0001-drlvm-EXPERIMENTAL-Optimized-ld_interface_vtable.txt, intf1.diff
>
>
> Attached is a try to optimize ld_interface_vtable helper to make it faster.
> Note to commiters: please, do NOT commit it into the main trunk.
> This is extremely experimental, and its effect need to be carefully measured.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira