You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@systemml.apache.org by GitBox <gi...@apache.org> on 2020/04/25 19:57:35 UTC

[GitHub] [systemml] mboehm7 commented on pull request #872: [SYSTEMDS-273] Refactor Compressed Package

mboehm7 commented on pull request #872:
URL: https://github.com/apache/systemml/pull/872#issuecomment-619432671


   LGTM - overall this is great @Baunsgaard. During the merge, I just fixed a few typos, and minor warnings (generics, static methods).
   
   Additionally, you might want to consider moving the `ColGroupSizes` into the class hierarchy of column groups to avoid string-based dispatching (including abstract classes that could never be instantiated) and bring this closer to their implementation. Also, please reconsider the unnecessary indirection of `AbstractCompressedMatrixBlock` and `CompressedMatrixBlockFactory`. Is there any intention behind them other than splitting `CompressedMatrixBlock` into smaller files?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org