[GitHub] [incubator-nuttx] normanr opened a new pull request #5316: Fix broken bl602 flash due to partition_table being incorrectly marked as unused

[GitBox <gi...@apache.org>]

normanr opened a new pull request #5316:
URL: https://github.com/apache/incubator-nuttx/pull/5316


   ## Summary
   Commit 5d1a444812f46b3f841ea2f09b1dd6be9725ec15 (from #4238) replaced `__attribute__ ((unused))` with `unused_code` but two instances of `__attribute__ ((used))` were also incorrectly replaced. Add `used_code`/`used_data` and used them instead.
   
   This resulted in the bl602 `boot2_partition_table` being zero size in the final binary, which means that the code in bl602_head.S no longer copied it into RAM. The result of which is that the `boot2_flash_cfg` data was read from the wrong offset and all flash ops would hang. 
   
   ## Impact
   Restoring the partition table size means that the flash config is valid, and flash ops (and the `bl602evb:spiflash` config) work again. cxd56 farapi_main had the same issue, although it's referenced in a different way so the compiler probably didn't omit it from the final link.
   
   ## Testing
   `bl602evb:spiflash` demo from #2659 now works


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5316: Fix broken bl602 flash due to partition_table being incorrectly marked as unused

[GitBox <gi...@apache.org>]

xiaoxiang781216 merged pull request #5316:
URL: https://github.com/apache/incubator-nuttx/pull/5316


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org