Re: [PR] MINOR: Cleanup Trogdor Module [kafka]

["sjhajharia (via GitHub)" <gi...@apache.org>]

sjhajharia commented on code in PR #20214:
URL: https://github.com/apache/kafka/pull/20214#discussion_r2249139705


##########
trogdor/src/main/java/org/apache/kafka/trogdor/rest/TaskRequest.java:
##########
@@ -23,14 +23,13 @@
 /**
  * The request to /coordinator/tasks/{taskId}
  */
-public class TaskRequest {
-    private final String taskId;
-
+public record TaskRequest(String taskId) {
     @JsonCreator
     public TaskRequest(@JsonProperty("taskId") String taskId) {
         this.taskId = taskId == null ? "" : taskId;
     }
 
+    @Override
     @JsonProperty

Review Comment:
   Hey @chia7712 , I agree, both of the annotations are unnexcessary. Dropped them.
   Pls re-review. TIA!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org