You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/11/10 23:57:26 UTC

[GitHub] [superset] junlincc commented on pull request #16756: refactor: Repeated boilerplate code between upload to database forms

junlincc commented on pull request #16756:
URL: https://github.com/apache/superset/pull/16756#issuecomment-965855545


   Sorry for being late the the discussion. @betodealmeida @john-bodley thanks for calling out. 
   Looks like this PR involves DB migration? We should definitely come up with a guideline for reviewing PRs that requires DB migration as they have higher risk. At least add the risk label while reviewing the PR. 
   @villebro 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org