You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/10/11 01:18:53 UTC

[GitHub] [flink] syhily opened a new pull request, #21010: [FLINK-29495][Connector/Pulsar] Refactor FailsOnJava11 class for supporting both JUnit4 and JUnit5.

syhily opened a new pull request, #21010:
URL: https://github.com/apache/flink/pull/21010

   ## What is the purpose of the change
   
   There are known issues with Pulsar on Java 11, which is why we want to disable test runs on Java 11. However, the tests still use the JUnit4 annotation for disabling a test on Java 11, which doesn't work. This PR changes that annotation to the JUnit5 equivalent.
   
   ## Brief change log
   
   Change the `FailsOnJava11` interface to an JUnit5 annotation.
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] syhily commented on pull request #21010: [FLINK-29495][Connector/Pulsar] Refactor FailsOnJava11 class for supporting both JUnit4 and JUnit5.

Posted by GitBox <gi...@apache.org>.
syhily commented on PR #21010:
URL: https://github.com/apache/flink/pull/21010#issuecomment-1274407281

   @zentol Thanks for you comments. But it does make sense to change the tag in `@FailsOnJava11` annotation, right?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] syhily closed pull request #21010: [FLINK-29495][Connector/Pulsar] Refactor FailsOnJava11 class for supporting both JUnit4 and JUnit5.

Posted by GitBox <gi...@apache.org>.
syhily closed pull request #21010: [FLINK-29495][Connector/Pulsar] Refactor FailsOnJava11 class for supporting both JUnit4 and JUnit5.
URL: https://github.com/apache/flink/pull/21010


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #21010: [FLINK-29495][Connector/Pulsar] Refactor FailsOnJava11 class for supporting both JUnit4 and JUnit5.

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #21010:
URL: https://github.com/apache/flink/pull/21010#issuecomment-1273971304

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "19da765ddf23e66964531ff98b7bb5691d67ae60",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "19da765ddf23e66964531ff98b7bb5691d67ae60",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 19da765ddf23e66964531ff98b7bb5691d67ae60 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] syhily commented on pull request #21010: [FLINK-29495][Connector/Pulsar] Refactor FailsOnJava11 class for supporting both JUnit4 and JUnit5.

Posted by GitBox <gi...@apache.org>.
syhily commented on PR #21010:
URL: https://github.com/apache/flink/pull/21010#issuecomment-1274418525

   > > But it does make sense to change the tag only in `@FailsOnJava11` annotation, right?
   > 
   > I'm not sure what you mean. The same logic applies to other categories we have at the moment. At some point, (that we can also move forward by porting affected tests; there aren't too many) they'll just be `@Tag("some short word")`.
   
   I see. I'll close this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on pull request #21010: [FLINK-29495][Connector/Pulsar] Refactor FailsOnJava11 class for supporting both JUnit4 and JUnit5.

Posted by GitBox <gi...@apache.org>.
zentol commented on PR #21010:
URL: https://github.com/apache/flink/pull/21010#issuecomment-1274411009

   > But it does make sense to change the tag only in `@FailsOnJava11` annotation, right?
   
   I'm not sure what you mean. The same logic applies to other categories we have at the moment.
   At some point, (that we can also move forward by porting affected tests; there aren't too many) they'll just be `@Tag("some short word")`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on pull request #21010: [FLINK-29495][Connector/Pulsar] Refactor FailsOnJava11 class for supporting both JUnit4 and JUnit5.

Posted by GitBox <gi...@apache.org>.
zentol commented on PR #21010:
URL: https://github.com/apache/flink/pull/21010#issuecomment-1274404351

   In the long-term this is unnecessary.
   
   Once the hbase e2e test was ported to junit5 we can reduce the tag to `@Tag("FailsOnJava11")` (optionally referring to some constant). I don't think a separate annotation is at that point required or worthwhile.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org