You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomee.apache.org by "Zowalla, Richard" <ri...@hs-heilbronn.de> on 2022/04/25 05:54:45 UTC

TCK Work - Smoothing the path (was Re: How can I help?)

> 
> > The trick is that setup is difficult to maintain and can be quite
> > intimidating.

I can remember ;) - my first attempts in May 21 were indeed
intimidating.

> Richard, have you tried to run any tests yet?  If not, are you
> possibly willing to be the brave guy who tries it first, hits the
> issues and works with myself or Jean-Louis to smooth the path for
> Zoltán and others?

Not for the current M8 Snapshot yet. Last time I did run (some) tests
of the ee9 tck was in May 21 - my tech stack switched, so I have to set
it up from scratch again. 

There can be no better environment to try and hit the (setup) issues -
so yes, count me in ;)

As far as I can remember, the README also needs an overhaul and we
should include the handy script, which does some of the setup
automatically. I think, that David posted it on the list.

I think, that we also need to switch to a dedicated tomee-8.x branch
and move the tomee-9.x branch to master in the tomee-tck harness repo.

Gruß
Richard

Am Sonntag, dem 24.04.2022 um 13:47 -0700 schrieb David Blevins:
> If we could get a few more people familiar with running the Jakarta
> EE TCK in TomEE and ready to start fixing test failures, that'd be
> the biggest impact on all our current and future certification
> efforts.
> 
> The trick is that setup is difficult to maintain and can be quite
> intimidating.
> 
> Richard, have you tried to run any tests yet?  If not, are you
> possibly willing to be the brave guy who tries it first, hits the
> issues and works with myself or Jean-Louis to smooth the path for
> Zoltán and others?
> 
> Truthfully, it's something we should be doing before every release on
> any branch.  It's another particularly large release process gap we
> do need to eventually fill.
> 
> 
> -David
> 
> 
> > On Apr 24, 2022, at 2:06 AM, Zowalla, Richard <
> > richard.zowalla@hs-heilbronn.de> wrote:
> > 
> > Hi Zoltán,
> > 
> > It's very great from you and it's truly awesome when a long time
> > user
> > of TomEE decides to contribute :)
> > 
> > First of all, do not get intimidated by your first ticket. If it
> > ends
> > up being too hard or just not fun, let's find something else for
> > you.
> > There is always plenty of work to do.
> > 
> > We are currently working on TomEE 9. Therefore, we moved away from
> > our
> > previous byte code transformation approach and switched TomEE
> > master to
> > TomEE 9 (Jakarta). 
> > 
> > While we made good progress, there is still a lot todo. The efforts
> > and
> > open tasks are tracked in [1]. A lot of effort is currently done to
> > switch the MicroProfile impl to MP Smallrye impls in order to move
> > to
> > the jakarta namespace [2].
> > 
> > If you are interested in contributing to our TomEE 9 efforts, we
> > can
> > surely find some beginner friendly tasks in this area.
> > 
> > Gruß
> > Richard
> > 
> > 
> > [1] https://issues.apache.org/jira/browse/TOMEE-3862
> > [2] 
> > https://lists.apache.org/thread/hdntdhwqkr91o2mszojq66qcfzszw96p
> > 
> > 
> > Am Samstag, dem 23.04.2022 um 20:21 +0200 schrieb Zoltán Tichov:
> > > Hi!
> > > 
> > > I live in Hungary. I am working at an IT company as a software
> > > developer, I
> > > develop java
> > > webapps with jsf (PrimeFaces) and microservice like apps without
> > > any
> > > container technology
> > > and Oracle database.
> > > 
> > > We want to switch to jakarta ee 9 at the company, but
> > > unfortunately
> > > we ran
> > > into problems with tomee 9 and I would like to contribute to
> > > fixing
> > > these
> > > bugs and possibly improving tomee jakarta 10. (I'm sorry to read
> > > on
> > > another
> > > tomee mailing list, that you had to skip jakarta ee 8 and 9
> > > compliance
> > > entirely)
> > > I use java 11 and netbeans on windows 10. If we don't have to, we
> > > don't
> > > want to use another app server because we've been using tomee
> > > since
> > > 1.7.3.
> > > 
> > > Best regards: Zoltán Tichov

Re: TCK Work - Smoothing the path (was Re: How can I help?)

Posted by "Zowalla, Richard" <ri...@hs-heilbronn.de>.
I slightly increased the default stack size limit of the forked test 
jvm in the related groovy script. It now works with Java 11 too.

To summarize: The documentation is updated and setting up the EE9.1 TCK
is quite easy. It basically boils down to:

(0) Ensure to have Maven and Java (11/14). 
(1) Run on a Linux / Mac OS system.
(2) Adjust the settings.xml according to the template
(3) Run the setup script (only oncE)
(4) Check that everything is available
(5) Add the TCK install into a local git repository to reset easily
without delete & extract it again and again (as a TCK run modifies the
isntallation)
(6) Run the TCK and have fun.

Nevertheless, we need to fix the javamail (javax vs jakarta) thing
first, but afterwards any new volunteer can happily start TCK work.  

Gruß
Richard


Am Dienstag, dem 26.04.2022 um 18:34 +0000 schrieb Zowalla, Richard:
> Thanks & You are right! Running with JDK 14 works. 
> 
> JDK 17 has some issues with illegal access within the groovy code
> used. 
> 
> With JDK 14 I am hitting the Javamail issue - so the setup procedere
> basically works. That are good news.
> 
> Gruß
> Richard
> 
> 
> Am Dienstag, dem 26.04.2022 um 19:48 +0200 schrieb Jean-Louis
> Monteiro:
> > Sorry for the late reply.
> > I managed to reproduce your issue. It does not seem to be a regular
> > stackoverflow (loop without exit condition).
> > Debugging the code with some additional traces, it looks like we
> > are
> > loading jar after jar and the stack isn't big enough to handle it
> > in
> > Java
> > 11.
> > 
> > I moved to a newer JDK like 14 or 17 and it worked.
> > --
> > Jean-Louis Monteiro
> > http://twitter.com/jlouismonteiro
> > http://www.tomitribe.com
> > 
> > 
> > On Tue, Apr 26, 2022 at 7:42 PM Zowalla, Richard <
> > richard.zowalla@hs-heilbronn.de> wrote:
> > 
> > > It looks like the SQL is not the real issue here - although it is
> > > a
> > > bit
> > > confusing because the select statements look ok to me.
> > > 
> > > However, after same additional digging / fiddling arround, I am
> > > at
> > > a
> > > point, there the JVM for the tests does not startup due to an
> > > StackOverflowError [1].
> > > 
> > > I tried remote debugging via "-dj" but have no glue why I am
> > > running to
> > > this StackOverflowError during the "ant.java(...)" call in the
> > > related
> > > groovy command. I bet, that I miss a little detail - so happy to
> > > any
> > > additional input ;)
> > > 
> > > Gruß
> > > R
> > > 
> > > 
> > > [1] https://gist.github.com/rzo1/0af90723dc0c6689a6f7d7bae9d2e8da
> > > 
> > > 
> > > Am Dienstag, dem 26.04.2022 um 09:59 +0000 schrieb Zowalla,
> > > Richard:
> > > > Hi,
> > > > 
> > > > I changed the script pointing to the released ee9.1 tck now and
> > > > updated
> > > > the README accordingly. If the instructions are followed
> > > > carefully,
> > > > it
> > > > will lead to a fresh installation.
> > > > 
> > > > In the process, I noticed, that Glassfish 6.0.0 isn't available
> > > > anymore
> > > > and is replaced by 6.2.5 - JL mentioned on Slack, that 6.2.5
> > > > should
> > > > also work.
> > > > 
> > > > I think, that we do not really need a public git repository.
> > > > Setting
> > > > it
> > > > up with the script is really straight forward. However, putting
> > > > the
> > > > TCK
> > > > installation into a local git repository makes totally sense in
> > > > order
> > > > to avoid delete / unpack cycles due to the modifications on the
> > > > installation, if the TCK is run.
> > > > 
> > > > I added some instructions in the README.
> > > > 
> > > > Currently, I am struggling with
> > > > 
> > > > [ERROR] java.sql.SQLSyntaxErrorException: Syntax error:
> > > > Encountered
> > > > "Simple_Select_Query" at line 1, column 1.
> > > > [INFO] 1130 of 1307 SQL statements executed successfully
> > > > 
> > > > when running
> > > > 
> > > > rm -rf target/ && ./runtests -Dhttps.protocols=TLSv1.1,TLSv1.2
> > > > --
> > > > ee91
> > > > --env -nc -c -U -w tomee-plume
> > > > com.sun.ts.tests.ejb30.lite.appexception.singleton.annotated.Cl
> > > > ie
> > > > nt
> > > > 
> > > > as the initial setup of the derby database seem to fail - don't
> > > > have
> > > > much ideas but using the search engine of trust I found an
> > > > entry,
> > > > that
> > > > this also happened on a tck.work build long time ago.
> > > > 
> > > > I guess, that I am just missing a little thing to fix it for my
> > > > setup.
> > > > 
> > > > Currently, the TCK runs will fail anyway as we need to fix java
> > > > mail
> > > > first but getting the same exception / outcome as JL would be
> > > > beneficial as it would prove, that the setup works and others
> > > > can
> > > > simply replicate - if this work, I will re-evaluate the
> > > > instructions
> > > > for debugging ;)
> > > > 
> > > > 
> > > > Gruß & thanks
> > > > Richard
> > > > 
> > > > 
> > > > Am Montag, dem 25.04.2022 um 14:13 -0700 schrieb David Blevins:
> > > > > Thanks for digging into this, Richard!
> > > > > 
> > > > > Agree with your prior statements about updating the README,
> > > > > branching
> > > > > for TomEE 8 and making TomEE 9 the master branch in the
> > > > > tomee-
> > > > > tck
> > > > > project.
> > > > > 
> > > > > 
> > > > > > On Apr 24, 2022, at 11:14 PM, Zowalla, Richard <
> > > > > > richard.zowalla@hs-heilbronn.de> wrote:
> > > > > > 
> > > > > > Ok, I found it:
> > > > > > 
> > > > > > -
> > > > > > https://lists.apache.org/thread/sfbvz76c527wojym71csv72k8j2qrrg7
> > > > > > 
> > > > > > If we adjust the script to target the (released) ee9.1 tck
> > > > > > (instead
> > > > > > of
> > > > > > the snapshots), it will certainly help. (This was the
> > > > > > script
> > > > > > I
> > > > > > had
> > > > > > in
> > > > > > mint)
> > > > > 
> > > > > Agree.  Maybe it needs a new name as well so it's more clear
> > > > > that
> > > > > it
> > > > > can be used to create a fresh setup.
> > > > > 
> > > > > > But while searching the list archive, I also found this
> > > > > > post
> > > > > > on
> > > > > > happy
> > > > > > TCK work:
> > > > > > 
> > > > > > -
> > > > > > https://lists.apache.org/thread/vgthyd8d7rww2p398r9swx8y37mwxf9c
> > > > > > 
> > > > > > Sadly the setup images from IntelliJ IDEA are gone (maybe
> > > > > > you
> > > > > > have
> > > > > > them
> > > > > > somewhere, David?).
> > > > > 
> > > > > Unfortunately, I don't have those images anymore.  We can
> > > > > maybe
> > > > > describe the menu steps instead of showing images.  Getting
> > > > > that on
> > > > > the website in the developer area would be good.
> > > > > 
> > > > > > Perhaps we should provide a similar jakartaeetck-9.x
> > > > > > installation
> > > > > > via a
> > > > > > Git repository?
> > > > > > 
> > > > > > Then we could adjust the "update" script and make it an
> > > > > > "install"
> > > > > > script.
> > > > > 
> > > > > The trick here is licensing of the TCK source code, which is
> > > > > EPL.  Here's the source of truth on "is this license ok"
> > > > > questions:
> > > > > 
> > > > >  -
> > > > > https://www.apache.org/legal/resolved.html#weak-copyleft-licenses
> > > > > 
> > > > > Effectively, we can use EPL in binary form.  In source form
> > > > > it's ok
> > > > > in small amounts where it generally can't be avoided.  An
> > > > > entire
> > > > > repository of EPL source code living under
> > > > > https://github.com/apache/
> > > > >  is likely not ok.
> > > > > 
> > > > > It doesn't mean the idea is shot, but it does mean that repo
> > > > > would
> > > > > have to live outside the Apache org in github.
> > > > > 
> > > > > > That would ease the necessary setup steps. Wdyt?
> > > > > 
> > > > > Definitely agree it's a great idea.  Perhaps we could create
> > > > > an
> > > > > org
> > > > > of our own?
> > > > > 
> > > > > 
> > > > > -David
> > > > > 

Re: TCK Work - Smoothing the path (was Re: How can I help?)

Posted by "Zowalla, Richard" <ri...@hs-heilbronn.de>.
Thanks & You are right! Running with JDK 14 works. 

JDK 17 has some issues with illegal access within the groovy code
used. 

With JDK 14 I am hitting the Javamail issue - so the setup procedere
basically works. That are good news.

Gruß
Richard


Am Dienstag, dem 26.04.2022 um 19:48 +0200 schrieb Jean-Louis Monteiro:
> Sorry for the late reply.
> I managed to reproduce your issue. It does not seem to be a regular
> stackoverflow (loop without exit condition).
> Debugging the code with some additional traces, it looks like we are
> loading jar after jar and the stack isn't big enough to handle it in
> Java
> 11.
> 
> I moved to a newer JDK like 14 or 17 and it worked.
> --
> Jean-Louis Monteiro
> http://twitter.com/jlouismonteiro
> http://www.tomitribe.com
> 
> 
> On Tue, Apr 26, 2022 at 7:42 PM Zowalla, Richard <
> richard.zowalla@hs-heilbronn.de> wrote:
> 
> > It looks like the SQL is not the real issue here - although it is a
> > bit
> > confusing because the select statements look ok to me.
> > 
> > However, after same additional digging / fiddling arround, I am at
> > a
> > point, there the JVM for the tests does not startup due to an
> > StackOverflowError [1].
> > 
> > I tried remote debugging via "-dj" but have no glue why I am
> > running to
> > this StackOverflowError during the "ant.java(...)" call in the
> > related
> > groovy command. I bet, that I miss a little detail - so happy to
> > any
> > additional input ;)
> > 
> > Gruß
> > R
> > 
> > 
> > [1] https://gist.github.com/rzo1/0af90723dc0c6689a6f7d7bae9d2e8da
> > 
> > 
> > Am Dienstag, dem 26.04.2022 um 09:59 +0000 schrieb Zowalla,
> > Richard:
> > > Hi,
> > > 
> > > I changed the script pointing to the released ee9.1 tck now and
> > > updated
> > > the README accordingly. If the instructions are followed
> > > carefully,
> > > it
> > > will lead to a fresh installation.
> > > 
> > > In the process, I noticed, that Glassfish 6.0.0 isn't available
> > > anymore
> > > and is replaced by 6.2.5 - JL mentioned on Slack, that 6.2.5
> > > should
> > > also work.
> > > 
> > > I think, that we do not really need a public git repository.
> > > Setting
> > > it
> > > up with the script is really straight forward. However, putting
> > > the
> > > TCK
> > > installation into a local git repository makes totally sense in
> > > order
> > > to avoid delete / unpack cycles due to the modifications on the
> > > installation, if the TCK is run.
> > > 
> > > I added some instructions in the README.
> > > 
> > > Currently, I am struggling with
> > > 
> > > [ERROR] java.sql.SQLSyntaxErrorException: Syntax error:
> > > Encountered
> > > "Simple_Select_Query" at line 1, column 1.
> > > [INFO] 1130 of 1307 SQL statements executed successfully
> > > 
> > > when running
> > > 
> > > rm -rf target/ && ./runtests -Dhttps.protocols=TLSv1.1,TLSv1.2 --
> > > ee91
> > > --env -nc -c -U -w tomee-plume
> > > com.sun.ts.tests.ejb30.lite.appexception.singleton.annotated.Clie
> > > nt
> > > 
> > > as the initial setup of the derby database seem to fail - don't
> > > have
> > > much ideas but using the search engine of trust I found an entry,
> > > that
> > > this also happened on a tck.work build long time ago.
> > > 
> > > I guess, that I am just missing a little thing to fix it for my
> > > setup.
> > > 
> > > Currently, the TCK runs will fail anyway as we need to fix java
> > > mail
> > > first but getting the same exception / outcome as JL would be
> > > beneficial as it would prove, that the setup works and others can
> > > simply replicate - if this work, I will re-evaluate the
> > > instructions
> > > for debugging ;)
> > > 
> > > 
> > > Gruß & thanks
> > > Richard
> > > 
> > > 
> > > Am Montag, dem 25.04.2022 um 14:13 -0700 schrieb David Blevins:
> > > > Thanks for digging into this, Richard!
> > > > 
> > > > Agree with your prior statements about updating the README,
> > > > branching
> > > > for TomEE 8 and making TomEE 9 the master branch in the tomee-
> > > > tck
> > > > project.
> > > > 
> > > > 
> > > > > On Apr 24, 2022, at 11:14 PM, Zowalla, Richard <
> > > > > richard.zowalla@hs-heilbronn.de> wrote:
> > > > > 
> > > > > Ok, I found it:
> > > > > 
> > > > > -
> > > > > https://lists.apache.org/thread/sfbvz76c527wojym71csv72k8j2qrrg7
> > > > > 
> > > > > If we adjust the script to target the (released) ee9.1 tck
> > > > > (instead
> > > > > of
> > > > > the snapshots), it will certainly help. (This was the script
> > > > > I
> > > > > had
> > > > > in
> > > > > mint)
> > > > 
> > > > Agree.  Maybe it needs a new name as well so it's more clear
> > > > that
> > > > it
> > > > can be used to create a fresh setup.
> > > > 
> > > > > But while searching the list archive, I also found this post
> > > > > on
> > > > > happy
> > > > > TCK work:
> > > > > 
> > > > > -
> > > > > https://lists.apache.org/thread/vgthyd8d7rww2p398r9swx8y37mwxf9c
> > > > > 
> > > > > Sadly the setup images from IntelliJ IDEA are gone (maybe you
> > > > > have
> > > > > them
> > > > > somewhere, David?).
> > > > 
> > > > Unfortunately, I don't have those images anymore.  We can maybe
> > > > describe the menu steps instead of showing images.  Getting
> > > > that on
> > > > the website in the developer area would be good.
> > > > 
> > > > > Perhaps we should provide a similar jakartaeetck-9.x
> > > > > installation
> > > > > via a
> > > > > Git repository?
> > > > > 
> > > > > Then we could adjust the "update" script and make it an
> > > > > "install"
> > > > > script.
> > > > 
> > > > The trick here is licensing of the TCK source code, which is
> > > > EPL.  Here's the source of truth on "is this license ok"
> > > > questions:
> > > > 
> > > >  -
> > > > https://www.apache.org/legal/resolved.html#weak-copyleft-licenses
> > > > 
> > > > Effectively, we can use EPL in binary form.  In source form
> > > > it's ok
> > > > in small amounts where it generally can't be avoided.  An
> > > > entire
> > > > repository of EPL source code living under
> > > > https://github.com/apache/
> > > >  is likely not ok.
> > > > 
> > > > It doesn't mean the idea is shot, but it does mean that repo
> > > > would
> > > > have to live outside the Apache org in github.
> > > > 
> > > > > That would ease the necessary setup steps. Wdyt?
> > > > 
> > > > Definitely agree it's a great idea.  Perhaps we could create an
> > > > org
> > > > of our own?
> > > > 
> > > > 
> > > > -David
> > > > 

Re: TCK Work - Smoothing the path (was Re: How can I help?)

Posted by Jean-Louis Monteiro <jl...@tomitribe.com>.
Sorry for the late reply.
I managed to reproduce your issue. It does not seem to be a regular
stackoverflow (loop without exit condition).
Debugging the code with some additional traces, it looks like we are
loading jar after jar and the stack isn't big enough to handle it in Java
11.

I moved to a newer JDK like 14 or 17 and it worked.
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Tue, Apr 26, 2022 at 7:42 PM Zowalla, Richard <
richard.zowalla@hs-heilbronn.de> wrote:

> It looks like the SQL is not the real issue here - although it is a bit
> confusing because the select statements look ok to me.
>
> However, after same additional digging / fiddling arround, I am at a
> point, there the JVM for the tests does not startup due to an
> StackOverflowError [1].
>
> I tried remote debugging via "-dj" but have no glue why I am running to
> this StackOverflowError during the "ant.java(...)" call in the related
> groovy command. I bet, that I miss a little detail - so happy to any
> additional input ;)
>
> Gruß
> R
>
>
> [1] https://gist.github.com/rzo1/0af90723dc0c6689a6f7d7bae9d2e8da
>
>
> Am Dienstag, dem 26.04.2022 um 09:59 +0000 schrieb Zowalla, Richard:
> > Hi,
> >
> > I changed the script pointing to the released ee9.1 tck now and
> > updated
> > the README accordingly. If the instructions are followed carefully,
> > it
> > will lead to a fresh installation.
> >
> > In the process, I noticed, that Glassfish 6.0.0 isn't available
> > anymore
> > and is replaced by 6.2.5 - JL mentioned on Slack, that 6.2.5 should
> > also work.
> >
> > I think, that we do not really need a public git repository. Setting
> > it
> > up with the script is really straight forward. However, putting the
> > TCK
> > installation into a local git repository makes totally sense in order
> > to avoid delete / unpack cycles due to the modifications on the
> > installation, if the TCK is run.
> >
> > I added some instructions in the README.
> >
> > Currently, I am struggling with
> >
> > [ERROR] java.sql.SQLSyntaxErrorException: Syntax error: Encountered
> > "Simple_Select_Query" at line 1, column 1.
> > [INFO] 1130 of 1307 SQL statements executed successfully
> >
> > when running
> >
> > rm -rf target/ && ./runtests -Dhttps.protocols=TLSv1.1,TLSv1.2 --ee91
> > --env -nc -c -U -w tomee-plume
> > com.sun.ts.tests.ejb30.lite.appexception.singleton.annotated.Client
> >
> > as the initial setup of the derby database seem to fail - don't have
> > much ideas but using the search engine of trust I found an entry,
> > that
> > this also happened on a tck.work build long time ago.
> >
> > I guess, that I am just missing a little thing to fix it for my
> > setup.
> >
> > Currently, the TCK runs will fail anyway as we need to fix java mail
> > first but getting the same exception / outcome as JL would be
> > beneficial as it would prove, that the setup works and others can
> > simply replicate - if this work, I will re-evaluate the instructions
> > for debugging ;)
> >
> >
> > Gruß & thanks
> > Richard
> >
> >
> > Am Montag, dem 25.04.2022 um 14:13 -0700 schrieb David Blevins:
> > > Thanks for digging into this, Richard!
> > >
> > > Agree with your prior statements about updating the README,
> > > branching
> > > for TomEE 8 and making TomEE 9 the master branch in the tomee-tck
> > > project.
> > >
> > >
> > > > On Apr 24, 2022, at 11:14 PM, Zowalla, Richard <
> > > > richard.zowalla@hs-heilbronn.de> wrote:
> > > >
> > > > Ok, I found it:
> > > >
> > > > -
> > > > https://lists.apache.org/thread/sfbvz76c527wojym71csv72k8j2qrrg7
> > > >
> > > > If we adjust the script to target the (released) ee9.1 tck
> > > > (instead
> > > > of
> > > > the snapshots), it will certainly help. (This was the script I
> > > > had
> > > > in
> > > > mint)
> > >
> > > Agree.  Maybe it needs a new name as well so it's more clear that
> > > it
> > > can be used to create a fresh setup.
> > >
> > > > But while searching the list archive, I also found this post on
> > > > happy
> > > > TCK work:
> > > >
> > > > -
> > > > https://lists.apache.org/thread/vgthyd8d7rww2p398r9swx8y37mwxf9c
> > > >
> > > > Sadly the setup images from IntelliJ IDEA are gone (maybe you
> > > > have
> > > > them
> > > > somewhere, David?).
> > >
> > > Unfortunately, I don't have those images anymore.  We can maybe
> > > describe the menu steps instead of showing images.  Getting that on
> > > the website in the developer area would be good.
> > >
> > > > Perhaps we should provide a similar jakartaeetck-9.x installation
> > > > via a
> > > > Git repository?
> > > >
> > > > Then we could adjust the "update" script and make it an "install"
> > > > script.
> > >
> > > The trick here is licensing of the TCK source code, which is
> > > EPL.  Here's the source of truth on "is this license ok" questions:
> > >
> > >  -
> > > https://www.apache.org/legal/resolved.html#weak-copyleft-licenses
> > >
> > > Effectively, we can use EPL in binary form.  In source form it's ok
> > > in small amounts where it generally can't be avoided.  An entire
> > > repository of EPL source code living under
> > > https://github.com/apache/
> > >  is likely not ok.
> > >
> > > It doesn't mean the idea is shot, but it does mean that repo would
> > > have to live outside the Apache org in github.
> > >
> > > > That would ease the necessary setup steps. Wdyt?
> > >
> > > Definitely agree it's a great idea.  Perhaps we could create an org
> > > of our own?
> > >
> > >
> > > -David
> > >
>

Re: TCK Work - Smoothing the path (was Re: How can I help?)

Posted by "Zowalla, Richard" <ri...@hs-heilbronn.de>.
It looks like the SQL is not the real issue here - although it is a bit
confusing because the select statements look ok to me. 

However, after same additional digging / fiddling arround, I am at a
point, there the JVM for the tests does not startup due to an
StackOverflowError [1].

I tried remote debugging via "-dj" but have no glue why I am running to
this StackOverflowError during the "ant.java(...)" call in the related
groovy command. I bet, that I miss a little detail - so happy to any
additional input ;)

Gruß
R


[1] https://gist.github.com/rzo1/0af90723dc0c6689a6f7d7bae9d2e8da


Am Dienstag, dem 26.04.2022 um 09:59 +0000 schrieb Zowalla, Richard:
> Hi,
> 
> I changed the script pointing to the released ee9.1 tck now and
> updated
> the README accordingly. If the instructions are followed carefully,
> it
> will lead to a fresh installation.
> 
> In the process, I noticed, that Glassfish 6.0.0 isn't available
> anymore
> and is replaced by 6.2.5 - JL mentioned on Slack, that 6.2.5 should
> also work. 
> 
> I think, that we do not really need a public git repository. Setting
> it
> up with the script is really straight forward. However, putting the
> TCK
> installation into a local git repository makes totally sense in order
> to avoid delete / unpack cycles due to the modifications on the
> installation, if the TCK is run.
> 
> I added some instructions in the README.
> 
> Currently, I am struggling with 
> 
> [ERROR] java.sql.SQLSyntaxErrorException: Syntax error: Encountered
> "Simple_Select_Query" at line 1, column 1.
> [INFO] 1130 of 1307 SQL statements executed successfully
> 
> when running
> 
> rm -rf target/ && ./runtests -Dhttps.protocols=TLSv1.1,TLSv1.2 --ee91
> --env -nc -c -U -w tomee-plume
> com.sun.ts.tests.ejb30.lite.appexception.singleton.annotated.Client
> 
> as the initial setup of the derby database seem to fail - don't have
> much ideas but using the search engine of trust I found an entry,
> that
> this also happened on a tck.work build long time ago.
> 
> I guess, that I am just missing a little thing to fix it for my
> setup.
> 
> Currently, the TCK runs will fail anyway as we need to fix java mail
> first but getting the same exception / outcome as JL would be
> beneficial as it would prove, that the setup works and others can
> simply replicate - if this work, I will re-evaluate the instructions
> for debugging ;)
> 
> 
> Gruß & thanks
> Richard
> 
> 
> Am Montag, dem 25.04.2022 um 14:13 -0700 schrieb David Blevins:
> > Thanks for digging into this, Richard!
> > 
> > Agree with your prior statements about updating the README,
> > branching
> > for TomEE 8 and making TomEE 9 the master branch in the tomee-tck
> > project.
> > 
> > 
> > > On Apr 24, 2022, at 11:14 PM, Zowalla, Richard <
> > > richard.zowalla@hs-heilbronn.de> wrote:
> > > 
> > > Ok, I found it:
> > > 
> > > - 
> > > https://lists.apache.org/thread/sfbvz76c527wojym71csv72k8j2qrrg7
> > > 
> > > If we adjust the script to target the (released) ee9.1 tck
> > > (instead
> > > of
> > > the snapshots), it will certainly help. (This was the script I
> > > had
> > > in
> > > mint)
> > 
> > Agree.  Maybe it needs a new name as well so it's more clear that
> > it
> > can be used to create a fresh setup.
> > 
> > > But while searching the list archive, I also found this post on
> > > happy
> > > TCK work:
> > > 
> > > - 
> > > https://lists.apache.org/thread/vgthyd8d7rww2p398r9swx8y37mwxf9c
> > > 
> > > Sadly the setup images from IntelliJ IDEA are gone (maybe you
> > > have
> > > them
> > > somewhere, David?).
> > 
> > Unfortunately, I don't have those images anymore.  We can maybe
> > describe the menu steps instead of showing images.  Getting that on
> > the website in the developer area would be good.  
> > 
> > > Perhaps we should provide a similar jakartaeetck-9.x installation
> > > via a
> > > Git repository?
> > > 
> > > Then we could adjust the "update" script and make it an "install"
> > > script.
> > 
> > The trick here is licensing of the TCK source code, which is
> > EPL.  Here's the source of truth on "is this license ok" questions:
> > 
> >  - 
> > https://www.apache.org/legal/resolved.html#weak-copyleft-licenses
> > 
> > Effectively, we can use EPL in binary form.  In source form it's ok
> > in small amounts where it generally can't be avoided.  An entire
> > repository of EPL source code living under 
> > https://github.com/apache/
> >  is likely not ok.
> > 
> > It doesn't mean the idea is shot, but it does mean that repo would
> > have to live outside the Apache org in github.
> > 
> > > That would ease the necessary setup steps. Wdyt?
> > 
> > Definitely agree it's a great idea.  Perhaps we could create an org
> > of our own?
> > 
> > 
> > -David
> > 

Re: TCK Work - Smoothing the path (was Re: How can I help?)

Posted by "Zowalla, Richard" <ri...@hs-heilbronn.de>.
Hi,

I changed the script pointing to the released ee9.1 tck now and updated
the README accordingly. If the instructions are followed carefully, it
will lead to a fresh installation.

In the process, I noticed, that Glassfish 6.0.0 isn't available anymore
and is replaced by 6.2.5 - JL mentioned on Slack, that 6.2.5 should
also work. 

I think, that we do not really need a public git repository. Setting it
up with the script is really straight forward. However, putting the TCK
installation into a local git repository makes totally sense in order
to avoid delete / unpack cycles due to the modifications on the
installation, if the TCK is run.

I added some instructions in the README.

Currently, I am struggling with 

[ERROR] java.sql.SQLSyntaxErrorException: Syntax error: Encountered
"Simple_Select_Query" at line 1, column 1.
[INFO] 1130 of 1307 SQL statements executed successfully

when running

rm -rf target/ && ./runtests -Dhttps.protocols=TLSv1.1,TLSv1.2 --ee91
--env -nc -c -U -w tomee-plume
com.sun.ts.tests.ejb30.lite.appexception.singleton.annotated.Client

as the initial setup of the derby database seem to fail - don't have
much ideas but using the search engine of trust I found an entry, that
this also happened on a tck.work build long time ago.

I guess, that I am just missing a little thing to fix it for my setup.

Currently, the TCK runs will fail anyway as we need to fix java mail
first but getting the same exception / outcome as JL would be
beneficial as it would prove, that the setup works and others can
simply replicate - if this work, I will re-evaluate the instructions
for debugging ;)


Gruß & thanks
Richard


Am Montag, dem 25.04.2022 um 14:13 -0700 schrieb David Blevins:
> Thanks for digging into this, Richard!
> 
> Agree with your prior statements about updating the README, branching
> for TomEE 8 and making TomEE 9 the master branch in the tomee-tck
> project.
> 
> 
> > On Apr 24, 2022, at 11:14 PM, Zowalla, Richard <
> > richard.zowalla@hs-heilbronn.de> wrote:
> > 
> > Ok, I found it:
> > 
> > - https://lists.apache.org/thread/sfbvz76c527wojym71csv72k8j2qrrg7
> > 
> > If we adjust the script to target the (released) ee9.1 tck (instead
> > of
> > the snapshots), it will certainly help. (This was the script I had
> > in
> > mint)
> 
> Agree.  Maybe it needs a new name as well so it's more clear that it
> can be used to create a fresh setup.
> 
> > But while searching the list archive, I also found this post on
> > happy
> > TCK work:
> > 
> > - https://lists.apache.org/thread/vgthyd8d7rww2p398r9swx8y37mwxf9c
> > 
> > Sadly the setup images from IntelliJ IDEA are gone (maybe you have
> > them
> > somewhere, David?).
> 
> Unfortunately, I don't have those images anymore.  We can maybe
> describe the menu steps instead of showing images.  Getting that on
> the website in the developer area would be good.  
> 
> > Perhaps we should provide a similar jakartaeetck-9.x installation
> > via a
> > Git repository?
> > 
> > Then we could adjust the "update" script and make it an "install"
> > script.
> 
> The trick here is licensing of the TCK source code, which is
> EPL.  Here's the source of truth on "is this license ok" questions:
> 
>  - https://www.apache.org/legal/resolved.html#weak-copyleft-licenses
> 
> Effectively, we can use EPL in binary form.  In source form it's ok
> in small amounts where it generally can't be avoided.  An entire
> repository of EPL source code living under https://github.com/apache/
>  is likely not ok.
> 
> It doesn't mean the idea is shot, but it does mean that repo would
> have to live outside the Apache org in github.
> 
> > That would ease the necessary setup steps. Wdyt?
> 
> Definitely agree it's a great idea.  Perhaps we could create an org
> of our own?
> 
> 
> -David
> 

Re: TCK Work - Smoothing the path (was Re: How can I help?)

Posted by David Blevins <da...@gmail.com>.
Thanks for digging into this, Richard!

Agree with your prior statements about updating the README, branching for TomEE 8 and making TomEE 9 the master branch in the tomee-tck project.


> On Apr 24, 2022, at 11:14 PM, Zowalla, Richard <ri...@hs-heilbronn.de> wrote:
> 
> Ok, I found it:
> 
> - https://lists.apache.org/thread/sfbvz76c527wojym71csv72k8j2qrrg7
> 
> If we adjust the script to target the (released) ee9.1 tck (instead of
> the snapshots), it will certainly help. (This was the script I had in
> mint)

Agree.  Maybe it needs a new name as well so it's more clear that it can be used to create a fresh setup.

> But while searching the list archive, I also found this post on happy
> TCK work:
> 
> - https://lists.apache.org/thread/vgthyd8d7rww2p398r9swx8y37mwxf9c
> 
> Sadly the setup images from IntelliJ IDEA are gone (maybe you have them
> somewhere, David?).

Unfortunately, I don't have those images anymore.  We can maybe describe the menu steps instead of showing images.  Getting that on the website in the developer area would be good.  

> Perhaps we should provide a similar jakartaeetck-9.x installation via a
> Git repository?
> 
> Then we could adjust the "update" script and make it an "install"
> script.

The trick here is licensing of the TCK source code, which is EPL.  Here's the source of truth on "is this license ok" questions:

 - https://www.apache.org/legal/resolved.html#weak-copyleft-licenses

Effectively, we can use EPL in binary form.  In source form it's ok in small amounts where it generally can't be avoided.  An entire repository of EPL source code living under https://github.com/apache/ is likely not ok.

It doesn't mean the idea is shot, but it does mean that repo would have to live outside the Apache org in github.

> That would ease the necessary setup steps. Wdyt?

Definitely agree it's a great idea.  Perhaps we could create an org of our own?


-David


Re: TCK Work - Smoothing the path (was Re: How can I help?)

Posted by "Zowalla, Richard" <ri...@hs-heilbronn.de>.
Ok, I found it:

- https://lists.apache.org/thread/sfbvz76c527wojym71csv72k8j2qrrg7

If we adjust the script to target the (released) ee9.1 tck (instead of
the snapshots), it will certainly help. (This was the script I had in
mint)

But while searching the list archive, I also found this post on happy
TCK work:

- https://lists.apache.org/thread/vgthyd8d7rww2p398r9swx8y37mwxf9c

Sadly the setup images from IntelliJ IDEA are gone (maybe you have them
somewhere, David?).

Perhaps we should provide a similar jakartaeetck-9.x installation via a
Git repository?

Then we could adjust the "update" script and make it an "install"
script. 

That would ease the necessary setup steps. Wdyt?

Gruß
Richard


Am Montag, dem 25.04.2022 um 05:54 +0000 schrieb Zowalla, Richard:
> > > The trick is that setup is difficult to maintain and can be quite
> > > intimidating.
> 
> I can remember ;) - my first attempts in May 21 were indeed
> intimidating.
> 
> > Richard, have you tried to run any tests yet?  If not, are you
> > possibly willing to be the brave guy who tries it first, hits the
> > issues and works with myself or Jean-Louis to smooth the path for
> > Zoltán and others?
> 
> Not for the current M8 Snapshot yet. Last time I did run (some) tests
> of the ee9 tck was in May 21 - my tech stack switched, so I have to
> set
> it up from scratch again. 
> 
> There can be no better environment to try and hit the (setup) issues
> -
> so yes, count me in ;)
> 
> As far as I can remember, the README also needs an overhaul and we
> should include the handy script, which does some of the setup
> automatically. I think, that David posted it on the list.
> 
> I think, that we also need to switch to a dedicated tomee-8.x branch
> and move the tomee-9.x branch to master in the tomee-tck harness
> repo.
> 
> Gruß
> Richard
> 
> Am Sonntag, dem 24.04.2022 um 13:47 -0700 schrieb David Blevins:
> > If we could get a few more people familiar with running the Jakarta
> > EE TCK in TomEE and ready to start fixing test failures, that'd be
> > the biggest impact on all our current and future certification
> > efforts.
> > 
> > The trick is that setup is difficult to maintain and can be quite
> > intimidating.
> > 
> > Richard, have you tried to run any tests yet?  If not, are you
> > possibly willing to be the brave guy who tries it first, hits the
> > issues and works with myself or Jean-Louis to smooth the path for
> > Zoltán and others?
> > 
> > Truthfully, it's something we should be doing before every release
> > on
> > any branch.  It's another particularly large release process gap we
> > do need to eventually fill.
> > 
> > 
> > -David
> > 
> > 
> > > On Apr 24, 2022, at 2:06 AM, Zowalla, Richard <
> > > richard.zowalla@hs-heilbronn.de> wrote:
> > > 
> > > Hi Zoltán,
> > > 
> > > It's very great from you and it's truly awesome when a long time
> > > user
> > > of TomEE decides to contribute :)
> > > 
> > > First of all, do not get intimidated by your first ticket. If it
> > > ends
> > > up being too hard or just not fun, let's find something else for
> > > you.
> > > There is always plenty of work to do.
> > > 
> > > We are currently working on TomEE 9. Therefore, we moved away
> > > from
> > > our
> > > previous byte code transformation approach and switched TomEE
> > > master to
> > > TomEE 9 (Jakarta). 
> > > 
> > > While we made good progress, there is still a lot todo. The
> > > efforts
> > > and
> > > open tasks are tracked in [1]. A lot of effort is currently done
> > > to
> > > switch the MicroProfile impl to MP Smallrye impls in order to
> > > move
> > > to
> > > the jakarta namespace [2].
> > > 
> > > If you are interested in contributing to our TomEE 9 efforts, we
> > > can
> > > surely find some beginner friendly tasks in this area.
> > > 
> > > Gruß
> > > Richard
> > > 
> > > 
> > > [1] https://issues.apache.org/jira/browse/TOMEE-3862
> > > [2] 
> > > https://lists.apache.org/thread/hdntdhwqkr91o2mszojq66qcfzszw96p
> > > 
> > > 
> > > Am Samstag, dem 23.04.2022 um 20:21 +0200 schrieb Zoltán Tichov:
> > > > Hi!
> > > > 
> > > > I live in Hungary. I am working at an IT company as a software
> > > > developer, I
> > > > develop java
> > > > webapps with jsf (PrimeFaces) and microservice like apps
> > > > without
> > > > any
> > > > container technology
> > > > and Oracle database.
> > > > 
> > > > We want to switch to jakarta ee 9 at the company, but
> > > > unfortunately
> > > > we ran
> > > > into problems with tomee 9 and I would like to contribute to
> > > > fixing
> > > > these
> > > > bugs and possibly improving tomee jakarta 10. (I'm sorry to
> > > > read
> > > > on
> > > > another
> > > > tomee mailing list, that you had to skip jakarta ee 8 and 9
> > > > compliance
> > > > entirely)
> > > > I use java 11 and netbeans on windows 10. If we don't have to,
> > > > we
> > > > don't
> > > > want to use another app server because we've been using tomee
> > > > since
> > > > 1.7.3.
> > > > 
> > > > Best regards: Zoltán Tichov