[GitHub] [cordova-electron] zoltan-mihalyi commented on issue #185: Specify electron version to use

[GitBox <gi...@apache.org>]

zoltan-mihalyi commented on issue #185:
URL: https://github.com/apache/cordova-electron/issues/185#issuecomment-759747999


   I think the `config.xml` is the right place:
   ```json
       <platform name="electron">
           <preference name="ElectronVersion" value="11.2.0" />
       </platform>
   ```
   Maybe the preference name should be "ExperimentalElectronVersion".
   
   Using this version in `build` seems an easy task to me, but it is difficult in `run`, because we should install electron with the given version.
   
   Installing electron would happen in `prepare`. I can see two solutions:
   - install `electron` with npm somewhere in platform folder
   - use `@electron/get` directly, and implement code similar to `electron/install.js` (version check, download, extract, determine executeble path)
   
   What do you think?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org