You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "clintropolis (via GitHub)" <gi...@apache.org> on 2023/09/29 21:34:19 UTC

Re: [PR] Fix missing format strings in calls to DruidException.build (druid)

clintropolis commented on code in PR #15056:
URL: https://github.com/apache/druid/pull/15056#discussion_r1341810438


##########
processing/src/test/java/org/apache/druid/java/util/common/StringUtilsTest.java:
##########
@@ -386,4 +386,19 @@ public void testJavaStringCompare()
       }
     }
   }
+
+  @Test(expected = NullPointerException.class)

Review Comment:
   nit: maybe use `Assert.assertThrows` instead of expected exceptions



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org