You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2016/04/06 18:35:35 UTC
Review Request 45818: Fixed flakiness in
PersistentVolumeTest.AccessPersistentVolume.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45818/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Bugs: MESOS-5128
https://issues.apache.org/jira/browse/MESOS-5128
Repository: mesos
Description
-------
Fixed flakiness in PersistentVolumeTest.AccessPersistentVolume.
Diffs
-----
src/tests/persistent_volume_tests.cpp 47867505f2f1d7a722b5a0d4ff3a0fca3188a193
Diff: https://reviews.apache.org/r/45818/diff/
Testing
-------
`./src/mesos-tests --gtest_filter="DiskResource/PersistentVolumeTest.AccessPersistentVolume/0" --gtest_repeat=1000 --gtest_break_on_failure` on both OSX and Linux.
Thanks,
Neil Conway
Re: Review Request 45818: Fixed flakiness in
PersistentVolumeTest.AccessPersistentVolume.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45818/#review127485
-----------------------------------------------------------
Patch looks great!
Reviews applied: [45817, 45818]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On April 6, 2016, 4:35 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45818/
> -----------------------------------------------------------
>
> (Updated April 6, 2016, 4:35 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-5128
> https://issues.apache.org/jira/browse/MESOS-5128
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed flakiness in PersistentVolumeTest.AccessPersistentVolume.
>
>
> Diffs
> -----
>
> src/tests/persistent_volume_tests.cpp 47867505f2f1d7a722b5a0d4ff3a0fca3188a193
>
> Diff: https://reviews.apache.org/r/45818/diff/
>
>
> Testing
> -------
>
> `./src/mesos-tests --gtest_filter="DiskResource/PersistentVolumeTest.AccessPersistentVolume/0" --gtest_repeat=1000 --gtest_break_on_failure` on both OSX and Linux.
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 45818: Fixed flakiness in
PersistentVolumeTest.AccessPersistentVolume.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45818/#review127370
-----------------------------------------------------------
lgtm
- Joris Van Remoortere
On April 6, 2016, 4:35 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45818/
> -----------------------------------------------------------
>
> (Updated April 6, 2016, 4:35 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-5128
> https://issues.apache.org/jira/browse/MESOS-5128
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed flakiness in PersistentVolumeTest.AccessPersistentVolume.
>
>
> Diffs
> -----
>
> src/tests/persistent_volume_tests.cpp 47867505f2f1d7a722b5a0d4ff3a0fca3188a193
>
> Diff: https://reviews.apache.org/r/45818/diff/
>
>
> Testing
> -------
>
> `./src/mesos-tests --gtest_filter="DiskResource/PersistentVolumeTest.AccessPersistentVolume/0" --gtest_repeat=1000 --gtest_break_on_failure` on both OSX and Linux.
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 45818: Fixed flakiness in
PersistentVolumeTest.AccessPersistentVolume.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45818/#review127505
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On April 6, 2016, 4:35 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45818/
> -----------------------------------------------------------
>
> (Updated April 6, 2016, 4:35 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-5128
> https://issues.apache.org/jira/browse/MESOS-5128
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed flakiness in PersistentVolumeTest.AccessPersistentVolume.
>
>
> Diffs
> -----
>
> src/tests/persistent_volume_tests.cpp 47867505f2f1d7a722b5a0d4ff3a0fca3188a193
>
> Diff: https://reviews.apache.org/r/45818/diff/
>
>
> Testing
> -------
>
> `./src/mesos-tests --gtest_filter="DiskResource/PersistentVolumeTest.AccessPersistentVolume/0" --gtest_repeat=1000 --gtest_break_on_failure` on both OSX and Linux.
>
>
> Thanks,
>
> Neil Conway
>
>