You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/06/21 02:29:53 UTC

[GitHub] [airflow] dwreeves opened a new pull request, #24573: Updated Snowflake provider connection documentation

dwreeves opened a new pull request, #24573:
URL: https://github.com/apache/airflow/pull/24573

   This PR addresses #24572.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] dwreeves commented on pull request #24573: Updated Snowflake provider connection documentation

Posted by GitBox <gi...@apache.org>.

dwreeves commented on PR #24573:
URL: https://github.com/apache/airflow/pull/24573#issuecomment-1166580414

   Excellent. Thank you for the review and for fixing the CI!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] dwreeves commented on a diff in pull request #24573: Updated Snowflake provider connection documentation

Posted by GitBox <gi...@apache.org>.

dwreeves commented on code in PR #24573:
URL: https://github.com/apache/airflow/pull/24573#discussion_r903031261


##########
docs/apache-airflow-providers-snowflake/connections/snowflake.rst:
##########
@@ -65,13 +62,35 @@ Extra (optional)
     * ``session_parameters``: Specify `session level parameters <https://docs.snowflake.com/en/user-guide/python-connector-example.html#setting-session-parameters>`_.
     * ``insecure_mode``: Turn off OCSP certificate checks. For details, see: `How To: Turn Off OCSP Checking in Snowflake Client Drivers - Snowflake Community <https://community.snowflake.com/s/article/How-to-turn-off-OCSP-checking-in-Snowflake-client-drivers>`_.
 
-When specifying the connection in environment variable you should specify
-it using URI syntax.
-
 Note that all components of the URI should be URL-encoded.

Review Comment:
   Done!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on pull request #24573: Updated Snowflake provider connection documentation

Posted by GitBox <gi...@apache.org>.

mik-laj commented on PR #24573:
URL: https://github.com/apache/airflow/pull/24573#issuecomment-1166561111

   LGTM, but CI is sad, so I rebased this branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #24573: Updated Snowflake provider connection documentation

Posted by GitBox <gi...@apache.org>.

boring-cyborg[bot] commented on PR #24573:
URL: https://github.com/apache/airflow/pull/24573#issuecomment-1161130573

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #24573: Updated Snowflake provider connection documentation

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on PR #24573:
URL: https://github.com/apache/airflow/pull/24573#issuecomment-1166561308

   The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #24573: Updated Snowflake provider connection documentation

Posted by GitBox <gi...@apache.org>.

boring-cyborg[bot] commented on PR #24573:
URL: https://github.com/apache/airflow/pull/24573#issuecomment-1167954528

   Awesome work, congrats on your first merged pull request!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on a diff in pull request #24573: Updated Snowflake provider connection documentation

Posted by GitBox <gi...@apache.org>.

mik-laj commented on code in PR #24573:
URL: https://github.com/apache/airflow/pull/24573#discussion_r902112212


##########
docs/apache-airflow-providers-snowflake/connections/snowflake.rst:
##########
@@ -65,13 +62,35 @@ Extra (optional)
     * ``session_parameters``: Specify `session level parameters <https://docs.snowflake.com/en/user-guide/python-connector-example.html#setting-session-parameters>`_.
     * ``insecure_mode``: Turn off OCSP certificate checks. For details, see: `How To: Turn Off OCSP Checking in Snowflake Client Drivers - Snowflake Community <https://community.snowflake.com/s/article/How-to-turn-off-OCSP-checking-in-Snowflake-client-drivers>`_.
 
-When specifying the connection in environment variable you should specify
-it using URI syntax.
-
 Note that all components of the URI should be URL-encoded.

Review Comment:
   Can you move this paragraph to section below?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj merged pull request #24573: Updated Snowflake provider connection documentation

Posted by GitBox <gi...@apache.org>.

mik-laj merged PR #24573:
URL: https://github.com/apache/airflow/pull/24573


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org