You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/11/25 07:19:26 UTC
[GitHub] [hudi] xuzifu666 opened a new pull request #4116: Bit cask disk map delete modified
xuzifu666 opened a new pull request #4116:
URL: https://github.com/apache/hudi/pull/4116
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
## What is the purpose of the pull request
*(For example: This pull request adds quick-start document.)*
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xuzifu666 commented on a change in pull request #4116: [HUDI-2856] Bit cask disk map delete modified
Posted by GitBox <gi...@apache.org>.
xuzifu666 commented on a change in pull request #4116:
URL: https://github.com/apache/hudi/pull/4116#discussion_r756667186
##########
File path: hudi-common/src/main/java/org/apache/hudi/common/util/collection/BitCaskDiskMap.java
##########
@@ -281,12 +281,12 @@ public void close() {
}
}
}
- writeOnlyFile.delete();
- this.iterators.forEach(ClosableIterator::close);
} catch (Exception e) {
// delete the file for any sort of exception
- writeOnlyFile.delete();
+ LOG.error("BitCaskDisMap close error ", e);
} finally {
+ this.iterators.forEach(ClosableIterator::close);
Review comment:
okey, had fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4116: [HUDI-2856] Bit cask disk map delete modified
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4116:
URL: https://github.com/apache/hudi/pull/4116#issuecomment-978952521
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cea0e6ae13eb5d8e43e8f0b2dd0027567d9bd03f",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3740",
"triggerID" : "cea0e6ae13eb5d8e43e8f0b2dd0027567d9bd03f",
"triggerType" : "PUSH"
}, {
"hash" : "cea0e6ae13eb5d8e43e8f0b2dd0027567d9bd03f",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3742",
"triggerID" : "978922867",
"triggerType" : "MANUAL"
}, {
"hash" : "cea0e6ae13eb5d8e43e8f0b2dd0027567d9bd03f",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3740",
"triggerID" : "978922867",
"triggerType" : "MANUAL"
}, {
"hash" : "4ffc1db7a06114c4bbd2d80d90156a243955da3f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3743",
"triggerID" : "4ffc1db7a06114c4bbd2d80d90156a243955da3f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cea0e6ae13eb5d8e43e8f0b2dd0027567d9bd03f Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3742) Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3740)
* 4ffc1db7a06114c4bbd2d80d90156a243955da3f Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3743)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4116: Bit cask disk map delete modified
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4116:
URL: https://github.com/apache/hudi/pull/4116#issuecomment-978904364
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cea0e6ae13eb5d8e43e8f0b2dd0027567d9bd03f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3740",
"triggerID" : "cea0e6ae13eb5d8e43e8f0b2dd0027567d9bd03f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cea0e6ae13eb5d8e43e8f0b2dd0027567d9bd03f Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3740)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua commented on pull request #4116: [HUDI-2856] Bit cask disk map delete modified
Posted by GitBox <gi...@apache.org>.
yihua commented on pull request #4116:
URL: https://github.com/apache/hudi/pull/4116#issuecomment-982139242
When running the Hudi Kafka Connect Sink, although the writes are successful, the sink keeps throwing the following repetitive errors, which can be noisy to users. After reverting this PR locally, the errors are gone.
```
14:23:40.363 [task-thread-hudi-sink-0] ERROR org.apache.hudi.common.util.collection.BitCaskDiskMap - BitCaskDisMap close error
java.nio.channels.ClosedChannelException: null
at sun.nio.ch.FileChannelImpl.ensureOpen(FileChannelImpl.java:110) ~[?:1.8.0_265]
at sun.nio.ch.FileChannelImpl.force(FileChannelImpl.java:379) ~[?:1.8.0_265]
at org.apache.hudi.common.util.collection.BitCaskDiskMap.close(BitCaskDiskMap.java:270) [hudi-kafka-connect-bundle-0.10.0-rc2.jar:0.10.0-rc2]
at org.apache.hudi.common.util.collection.ExternalSpillableMap.close(ExternalSpillableMap.java:261) [hudi-kafka-connect-bundle-0.10.0-rc2.jar:0.10.0-rc2]
at org.apache.hudi.connect.writers.BufferedConnectWriter.flushRecords(BufferedConnectWriter.java:121) [hudi-kafka-connect-bundle-0.10.0-rc2.jar:0.10.0-rc2]
at org.apache.hudi.connect.writers.AbstractConnectWriter.close(AbstractConnectWriter.java:95) [hudi-kafka-connect-bundle-0.10.0-rc2.jar:0.10.0-rc2]
at org.apache.hudi.connect.transaction.ConnectTransactionParticipant.cleanupOngoingTransaction(ConnectTransactionParticipant.java:249) [hudi-kafka-connect-bundle-0.10.0-rc2.jar:0.10.0-rc2]
at org.apache.hudi.connect.transaction.ConnectTransactionParticipant.handleAckCommit(ConnectTransactionParticipant.java:209) [hudi-kafka-connect-bundle-0.10.0-rc2.jar:0.10.0-rc2]
at org.apache.hudi.connect.transaction.ConnectTransactionParticipant.processRecords(ConnectTransactionParticipant.java:127) [hudi-kafka-connect-bundle-0.10.0-rc2.jar:0.10.0-rc2]
at org.apache.hudi.connect.HoodieSinkTask.put(HoodieSinkTask.java:114) [hudi-kafka-connect-bundle-0.10.0-rc2.jar:0.10.0-rc2]
at org.apache.kafka.connect.runtime.WorkerSinkTask.deliverMessages(WorkerSinkTask.java:581) [connect-runtime-3.0.0.jar:?]
at org.apache.kafka.connect.runtime.WorkerSinkTask.poll(WorkerSinkTask.java:329) [connect-runtime-3.0.0.jar:?]
at org.apache.kafka.connect.runtime.WorkerSinkTask.iteration(WorkerSinkTask.java:232) [connect-runtime-3.0.0.jar:?]
at org.apache.kafka.connect.runtime.WorkerSinkTask.execute(WorkerSinkTask.java:201) [connect-runtime-3.0.0.jar:?]
at org.apache.kafka.connect.runtime.WorkerTask.doRun(WorkerTask.java:186) [connect-runtime-3.0.0.jar:?]
at org.apache.kafka.connect.runtime.WorkerTask.run(WorkerTask.java:241) [connect-runtime-3.0.0.jar:?]
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:1.8.0_265]
at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:1.8.0_265]
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) [?:1.8.0_265]
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [?:1.8.0_265]
at java.lang.Thread.run(Thread.java:748) [?:1.8.0_265]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4116: Bit cask disk map delete modified
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4116:
URL: https://github.com/apache/hudi/pull/4116#issuecomment-978902858
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cea0e6ae13eb5d8e43e8f0b2dd0027567d9bd03f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cea0e6ae13eb5d8e43e8f0b2dd0027567d9bd03f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cea0e6ae13eb5d8e43e8f0b2dd0027567d9bd03f UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4116: [HUDI-2856] Bit cask disk map delete modified
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4116:
URL: https://github.com/apache/hudi/pull/4116#issuecomment-978926115
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cea0e6ae13eb5d8e43e8f0b2dd0027567d9bd03f",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3740",
"triggerID" : "cea0e6ae13eb5d8e43e8f0b2dd0027567d9bd03f",
"triggerType" : "PUSH"
}, {
"hash" : "cea0e6ae13eb5d8e43e8f0b2dd0027567d9bd03f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3742",
"triggerID" : "978922867",
"triggerType" : "MANUAL"
}, {
"hash" : "cea0e6ae13eb5d8e43e8f0b2dd0027567d9bd03f",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3740",
"triggerID" : "978922867",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* cea0e6ae13eb5d8e43e8f0b2dd0027567d9bd03f Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3742) Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3740)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua commented on pull request #4116: [HUDI-2856] Bit cask disk map delete modified
Posted by GitBox <gi...@apache.org>.
yihua commented on pull request #4116:
URL: https://github.com/apache/hudi/pull/4116#issuecomment-983202109
Reverting this change for 0.10.0-rc3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xuzifu666 edited a comment on pull request #4116: Bit cask disk map delete modified
Posted by GitBox <gi...@apache.org>.
xuzifu666 edited a comment on pull request #4116:
URL: https://github.com/apache/hudi/pull/4116#issuecomment-978901497
@danny0405 @leesf hi, review the pr plz, some modify maybe more suitable, because if occur exception, iterators alse need be deleted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xuzifu666 commented on pull request #4116: Bit cask disk map delete modified
Posted by GitBox <gi...@apache.org>.
xuzifu666 commented on pull request #4116:
URL: https://github.com/apache/hudi/pull/4116#issuecomment-978922867
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4116: [HUDI-2856] Bit cask disk map delete modified
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4116:
URL: https://github.com/apache/hudi/pull/4116#issuecomment-978952521
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cea0e6ae13eb5d8e43e8f0b2dd0027567d9bd03f",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3740",
"triggerID" : "cea0e6ae13eb5d8e43e8f0b2dd0027567d9bd03f",
"triggerType" : "PUSH"
}, {
"hash" : "cea0e6ae13eb5d8e43e8f0b2dd0027567d9bd03f",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3742",
"triggerID" : "978922867",
"triggerType" : "MANUAL"
}, {
"hash" : "cea0e6ae13eb5d8e43e8f0b2dd0027567d9bd03f",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3740",
"triggerID" : "978922867",
"triggerType" : "MANUAL"
}, {
"hash" : "4ffc1db7a06114c4bbd2d80d90156a243955da3f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3743",
"triggerID" : "4ffc1db7a06114c4bbd2d80d90156a243955da3f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cea0e6ae13eb5d8e43e8f0b2dd0027567d9bd03f Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3742) Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3740)
* 4ffc1db7a06114c4bbd2d80d90156a243955da3f Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3743)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4116: [HUDI-2856] Bit cask disk map delete modified
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4116:
URL: https://github.com/apache/hudi/pull/4116#issuecomment-978950620
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cea0e6ae13eb5d8e43e8f0b2dd0027567d9bd03f",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3740",
"triggerID" : "cea0e6ae13eb5d8e43e8f0b2dd0027567d9bd03f",
"triggerType" : "PUSH"
}, {
"hash" : "cea0e6ae13eb5d8e43e8f0b2dd0027567d9bd03f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3742",
"triggerID" : "978922867",
"triggerType" : "MANUAL"
}, {
"hash" : "cea0e6ae13eb5d8e43e8f0b2dd0027567d9bd03f",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3740",
"triggerID" : "978922867",
"triggerType" : "MANUAL"
}, {
"hash" : "4ffc1db7a06114c4bbd2d80d90156a243955da3f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4ffc1db7a06114c4bbd2d80d90156a243955da3f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cea0e6ae13eb5d8e43e8f0b2dd0027567d9bd03f Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3742) Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3740)
* 4ffc1db7a06114c4bbd2d80d90156a243955da3f UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4116: Bit cask disk map delete modified
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4116:
URL: https://github.com/apache/hudi/pull/4116#issuecomment-978902858
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cea0e6ae13eb5d8e43e8f0b2dd0027567d9bd03f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cea0e6ae13eb5d8e43e8f0b2dd0027567d9bd03f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cea0e6ae13eb5d8e43e8f0b2dd0027567d9bd03f UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4116: Bit cask disk map delete modified
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4116:
URL: https://github.com/apache/hudi/pull/4116#issuecomment-978924365
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cea0e6ae13eb5d8e43e8f0b2dd0027567d9bd03f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3740",
"triggerID" : "cea0e6ae13eb5d8e43e8f0b2dd0027567d9bd03f",
"triggerType" : "PUSH"
}, {
"hash" : "cea0e6ae13eb5d8e43e8f0b2dd0027567d9bd03f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3742",
"triggerID" : "978922867",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* cea0e6ae13eb5d8e43e8f0b2dd0027567d9bd03f Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3740) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3742)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a change in pull request #4116: [HUDI-2856] Bit cask disk map delete modified
Posted by GitBox <gi...@apache.org>.
danny0405 commented on a change in pull request #4116:
URL: https://github.com/apache/hudi/pull/4116#discussion_r756658842
##########
File path: hudi-common/src/main/java/org/apache/hudi/common/util/collection/BitCaskDiskMap.java
##########
@@ -281,12 +281,12 @@ public void close() {
}
}
}
- writeOnlyFile.delete();
- this.iterators.forEach(ClosableIterator::close);
} catch (Exception e) {
// delete the file for any sort of exception
- writeOnlyFile.delete();
+ LOG.error("BitCaskDisMap close error ", e);
} finally {
+ this.iterators.forEach(ClosableIterator::close);
Review comment:
Fix the indentention.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xuzifu666 commented on pull request #4116: Bit cask disk map delete modified
Posted by GitBox <gi...@apache.org>.
xuzifu666 commented on pull request #4116:
URL: https://github.com/apache/hudi/pull/4116#issuecomment-978920670
@hudi-bot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4116: Bit cask disk map delete modified
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4116:
URL: https://github.com/apache/hudi/pull/4116#issuecomment-978926115
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cea0e6ae13eb5d8e43e8f0b2dd0027567d9bd03f",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3740",
"triggerID" : "cea0e6ae13eb5d8e43e8f0b2dd0027567d9bd03f",
"triggerType" : "PUSH"
}, {
"hash" : "cea0e6ae13eb5d8e43e8f0b2dd0027567d9bd03f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3742",
"triggerID" : "978922867",
"triggerType" : "MANUAL"
}, {
"hash" : "cea0e6ae13eb5d8e43e8f0b2dd0027567d9bd03f",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3740",
"triggerID" : "978922867",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* cea0e6ae13eb5d8e43e8f0b2dd0027567d9bd03f Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3742) Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3740)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xuzifu666 commented on pull request #4116: Bit cask disk map delete modified
Posted by GitBox <gi...@apache.org>.
xuzifu666 commented on pull request #4116:
URL: https://github.com/apache/hudi/pull/4116#issuecomment-978901497
@danny0405 @leesf hi, review the pr plz, some modify maybe more suitable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] rmahindra123 commented on pull request #4116: [HUDI-2856] Bit cask disk map delete modified
Posted by GitBox <gi...@apache.org>.
rmahindra123 commented on pull request #4116:
URL: https://github.com/apache/hudi/pull/4116#issuecomment-980346738
lgtm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar merged pull request #4116: [HUDI-2856] Bit cask disk map delete modified
Posted by GitBox <gi...@apache.org>.
vinothchandar merged pull request #4116:
URL: https://github.com/apache/hudi/pull/4116
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4116: Bit cask disk map delete modified
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4116:
URL: https://github.com/apache/hudi/pull/4116#issuecomment-978904364
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cea0e6ae13eb5d8e43e8f0b2dd0027567d9bd03f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3740",
"triggerID" : "cea0e6ae13eb5d8e43e8f0b2dd0027567d9bd03f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cea0e6ae13eb5d8e43e8f0b2dd0027567d9bd03f Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3740)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4116: [HUDI-2856] Bit cask disk map delete modified
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4116:
URL: https://github.com/apache/hudi/pull/4116#issuecomment-978950620
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cea0e6ae13eb5d8e43e8f0b2dd0027567d9bd03f",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3740",
"triggerID" : "cea0e6ae13eb5d8e43e8f0b2dd0027567d9bd03f",
"triggerType" : "PUSH"
}, {
"hash" : "cea0e6ae13eb5d8e43e8f0b2dd0027567d9bd03f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3742",
"triggerID" : "978922867",
"triggerType" : "MANUAL"
}, {
"hash" : "cea0e6ae13eb5d8e43e8f0b2dd0027567d9bd03f",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3740",
"triggerID" : "978922867",
"triggerType" : "MANUAL"
}, {
"hash" : "4ffc1db7a06114c4bbd2d80d90156a243955da3f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4ffc1db7a06114c4bbd2d80d90156a243955da3f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cea0e6ae13eb5d8e43e8f0b2dd0027567d9bd03f Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3742) Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3740)
* 4ffc1db7a06114c4bbd2d80d90156a243955da3f UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4116: Bit cask disk map delete modified
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4116:
URL: https://github.com/apache/hudi/pull/4116#issuecomment-978924365
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cea0e6ae13eb5d8e43e8f0b2dd0027567d9bd03f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3740",
"triggerID" : "cea0e6ae13eb5d8e43e8f0b2dd0027567d9bd03f",
"triggerType" : "PUSH"
}, {
"hash" : "cea0e6ae13eb5d8e43e8f0b2dd0027567d9bd03f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3742",
"triggerID" : "978922867",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* cea0e6ae13eb5d8e43e8f0b2dd0027567d9bd03f Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3740) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3742)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xuzifu666 removed a comment on pull request #4116: Bit cask disk map delete modified
Posted by GitBox <gi...@apache.org>.
xuzifu666 removed a comment on pull request #4116:
URL: https://github.com/apache/hudi/pull/4116#issuecomment-978920670
@hudi-bot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4116: [HUDI-2856] Bit cask disk map delete modified
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4116:
URL: https://github.com/apache/hudi/pull/4116#issuecomment-979010760
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cea0e6ae13eb5d8e43e8f0b2dd0027567d9bd03f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3740",
"triggerID" : "cea0e6ae13eb5d8e43e8f0b2dd0027567d9bd03f",
"triggerType" : "PUSH"
}, {
"hash" : "cea0e6ae13eb5d8e43e8f0b2dd0027567d9bd03f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3742",
"triggerID" : "978922867",
"triggerType" : "MANUAL"
}, {
"hash" : "cea0e6ae13eb5d8e43e8f0b2dd0027567d9bd03f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3740",
"triggerID" : "978922867",
"triggerType" : "MANUAL"
}, {
"hash" : "4ffc1db7a06114c4bbd2d80d90156a243955da3f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3743",
"triggerID" : "4ffc1db7a06114c4bbd2d80d90156a243955da3f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4ffc1db7a06114c4bbd2d80d90156a243955da3f Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3743)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org