You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2021/06/22 19:09:48 UTC

[GitHub] [accumulo] DomGarguilo opened a new issue #2174: Make listscans show #of files

DomGarguilo opened a new issue #2174:
URL: https://github.com/apache/accumulo/issues/2174


   **Is your feature request related to a problem? Please describe.**
   First posted on Jira Ticket: [here](https://issues.apache.org/jira/browse/ACCUMULO-385)
   
   Quote from the Ticket:
   
       Look into making the list scans shell command show the number of files in use by the scan.
   
   Wanted to recreate this ticket to elicit discussion.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [accumulo] EdColeman edited a comment on issue #2174: Make listscans show #of files

Posted by GitBox <gi...@apache.org>.
EdColeman edited a comment on issue #2174:
URL: https://github.com/apache/accumulo/issues/2174#issuecomment-870756297


   If the file count needs to be added, it might make sense to also publish those as some sort of metric. Just raising this as a question - I'm not sure if this would be a useful metric or not  - but it might be worth checking.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [accumulo] milleruntime commented on issue #2174: Make listscans show #of files

Posted by GitBox <gi...@apache.org>.
milleruntime commented on issue #2174:
URL: https://github.com/apache/accumulo/issues/2174#issuecomment-869700675


   You could add a new method to `ActiveScan` class and use it to get the number of files. This [class](https://github.com/apache/accumulo/blob/3fd5cad92f9b63ac19e4466f3f2d5237b905262c/core/src/main/java/org/apache/accumulo/core/client/admin/ActiveScan.java) is returned by the getActiveScans() method on the `InstaceOperations` API. This would probably also require adding another value on the thrift endpoint as well in [tabletserver.thrift](https://github.com/apache/accumulo/blob/cd2dfa12943a1fce279c8399c68e1b7f4f752958/core/src/main/thrift/tabletserver.thrift#L83)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [accumulo] DomGarguilo commented on issue #2174: Make listscans show #of files

Posted by GitBox <gi...@apache.org>.
DomGarguilo commented on issue #2174:
URL: https://github.com/apache/accumulo/issues/2174#issuecomment-866258508


   I would like to be assigned to this ticket.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [accumulo] EdColeman commented on issue #2174: Make listscans show #of files

Posted by GitBox <gi...@apache.org>.
EdColeman commented on issue #2174:
URL: https://github.com/apache/accumulo/issues/2174#issuecomment-870756297


   If the file count needs to be added, it might make sense to also public those as some sort of metric. Just raising this as a question - I'm not sure if this would be a useful metric or not  - but it might be worth checking.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [accumulo] DomGarguilo commented on issue #2174: Make listscans show #of files

Posted by GitBox <gi...@apache.org>.
DomGarguilo commented on issue #2174:
URL: https://github.com/apache/accumulo/issues/2174#issuecomment-869811909


   @milleruntime The problem is getting the file count. It seems like the file count is something that would need to be measured as the scan itself is taking place. I'm not sure of a way to determine which files were scanned given the info available from an activescan.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [accumulo] DomGarguilo commented on issue #2174: Make listscans show #of files

Posted by GitBox <gi...@apache.org>.
DomGarguilo commented on issue #2174:
URL: https://github.com/apache/accumulo/issues/2174#issuecomment-867928978


   After some investigation, it seems this feature may be harder to implement than I originally anticipated. It looks like most of the work to make this happen would need to be done to the scan command rather than the listscans command. As it stands (unless I am overlooking something, which is very possible) there is no apparent clean or easy way to display the file count for a given scan. Before continuing I wanted to see if there is still any desire for this feature or see if anyone had ideas that might make implementing this easier/better/etc.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [accumulo] DomGarguilo commented on issue #2174: Make listscans show #of files

Posted by GitBox <gi...@apache.org>.
DomGarguilo commented on issue #2174:
URL: https://github.com/apache/accumulo/issues/2174#issuecomment-874990652


   After further investigation and discussion it seems that this change would require more work than it is worth. Instead, the number of files in a scan may be added as a metric.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [accumulo] DomGarguilo commented on issue #2174: Make listscans show #of files

Posted by GitBox <gi...@apache.org>.
DomGarguilo commented on issue #2174:
URL: https://github.com/apache/accumulo/issues/2174#issuecomment-869811909


   @milleruntime The problem is getting the file count. It seems like the file count is something that would need to be measured as the scan itself is taking place. I'm not sure of a way to determine which files were scanned given the info available from an activescan.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [accumulo] DomGarguilo closed issue #2174: Make listscans show #of files

Posted by GitBox <gi...@apache.org>.
DomGarguilo closed issue #2174:
URL: https://github.com/apache/accumulo/issues/2174


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [accumulo] milleruntime commented on issue #2174: Make listscans show #of files

Posted by GitBox <gi...@apache.org>.
milleruntime commented on issue #2174:
URL: https://github.com/apache/accumulo/issues/2174#issuecomment-869700675


   You could add a new method to `ActiveScan` class and use it to get the number of files. This [class](https://github.com/apache/accumulo/blob/3fd5cad92f9b63ac19e4466f3f2d5237b905262c/core/src/main/java/org/apache/accumulo/core/client/admin/ActiveScan.java) is returned by the getActiveScans() method on the `InstaceOperations` API. This would probably also require adding another value on the thrift endpoint as well in [tabletserver.thrift](https://github.com/apache/accumulo/blob/cd2dfa12943a1fce279c8399c68e1b7f4f752958/core/src/main/thrift/tabletserver.thrift#L83)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org