You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "John Russell (Code Review)" <ge...@cloudera.org> on 2017/01/11 18:47:07 UTC
[Impala-ASF-CR] Clean up tags for 2 query options
John Russell has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5682
Change subject: Clean up <navtitle> tags for 2 query options
......................................................................
Clean up <navtitle> tags for 2 query options
One query option was missing a <navtitle> tag.
The other had a <navtitle> tag but it was blank.
The results could have been inconsistent or missing
link text for auto-generated navigational links
such as "next page" and "previous page" links.
Change-Id: I2350baffeb216655380d4055bff8bdc09457ec3f
---
M docs/topics/impala_parquet_annotate_strings_utf8.xml
M docs/topics/impala_scan_node_codegen_threshold.xml
2 files changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/5682/1
--
To view, visit http://gerrit.cloudera.org:8080/5682
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2350baffeb216655380d4055bff8bdc09457ec3f
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
[Impala-ASF-CR] Clean up tags for 2 query options
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: Clean up <navtitle> tags for 2 query options
......................................................................
Patch Set 1:
Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/17/
--
To view, visit http://gerrit.cloudera.org:8080/5682
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2350baffeb216655380d4055bff8bdc09457ec3f
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] Clean up tags for 2 query options
Posted by "Laurel Hale (Code Review)" <ge...@cloudera.org>.
Laurel Hale has posted comments on this change.
Change subject: Clean up <navtitle> tags for 2 query options
......................................................................
Patch Set 1: Code-Review+1
pulled and built the changes in a new branch--no merge conflicts. HTML nav titles look good.
--
To view, visit http://gerrit.cloudera.org:8080/5682
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2350baffeb216655380d4055bff8bdc09457ec3f
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] Clean up tags for 2 query options
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: Clean up <navtitle> tags for 2 query options
......................................................................
Clean up <navtitle> tags for 2 query options
One query option was missing a <navtitle> tag.
The other had a <navtitle> tag but it was blank.
The results could have been inconsistent or missing
link text for auto-generated navigational links
such as "next page" and "previous page" links.
Change-Id: I2350baffeb216655380d4055bff8bdc09457ec3f
Reviewed-on: http://gerrit.cloudera.org:8080/5682
Reviewed-by: Laurel Hale <la...@cloudera.com>
Reviewed-by: John Russell <jr...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M docs/topics/impala_parquet_annotate_strings_utf8.xml
M docs/topics/impala_scan_node_codegen_threshold.xml
2 files changed, 2 insertions(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Verified
Laurel Hale: Looks good to me, but someone else must approve
John Russell: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/5682
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2350baffeb216655380d4055bff8bdc09457ec3f
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
[Impala-ASF-CR] Clean up tags for 2 query options
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: Clean up <navtitle> tags for 2 query options
......................................................................
Patch Set 1: Code-Review+2
Confirming based on independent review with doc contributor.
--
To view, visit http://gerrit.cloudera.org:8080/5682
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2350baffeb216655380d4055bff8bdc09457ec3f
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] Clean up tags for 2 query options
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: Clean up <navtitle> tags for 2 query options
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/5682
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2350baffeb216655380d4055bff8bdc09457ec3f
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No