You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/18 00:48:10 UTC
[GitHub] [beam] pabloem opened a new pull request, #21939: Removing playground from main page due to scrolling
pabloem opened a new pull request, #21939:
URL: https://github.com/apache/beam/pull/21939
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on pull request #21939: Removing playground from main page due to scrolling
Posted by GitBox <gi...@apache.org>.
aaltay commented on PR #21939:
URL: https://github.com/apache/beam/pull/21939#issuecomment-1159604995
Thank you @pabloem.
As a side note, I do not understand how this works. Why would removing a div and not any js will fix the autoscrolling?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #21939: Removing playground from main page due to scrolling
Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #21939:
URL: https://github.com/apache/beam/pull/21939#issuecomment-1159609608
The JS that causes the scroll is part of the playground. By removing the
playground iframe we remove that JS.
On Sat, Jun 18, 2022, 7:49 PM Ahmet Altay ***@***.***> wrote:
> Thank you @pabloem <https://github.com/pabloem>.
>
> As a side note, I do not understand how this works. Why would removing a
> div and not any js will fix the autoscrolling?
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/beam/pull/21939#issuecomment-1159604995>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAJ5Z3B44WODOEQEOZQFF5TVP2DELANCNFSM5ZD45DZQ>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on pull request #21939: Removing playground from main page due to scrolling
Posted by GitBox <gi...@apache.org>.
aaltay commented on PR #21939:
URL: https://github.com/apache/beam/pull/21939#issuecomment-1159791971
>
Got it. And thank you for the explanation!
This goes beyond my JS understanding. I though the JS in the iframe would have been sandboxed and not able to affect the main page. It sounds like my understanding is not correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #21939: Removing playground from main page due to scrolling
Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #21939:
URL: https://github.com/apache/beam/pull/21939#issuecomment-1159537860
merging to hotfix the issue and we can figure out what to do afterwards
fyi @aijamalnk @aaltay @AKosolapov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #21939: Removing playground from main page due to scrolling
Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #21939:
URL: https://github.com/apache/beam/pull/21939#issuecomment-1159796552
I thought so too. But oh well : )
On Sun, Jun 19, 2022, 11:51 AM Ahmet Altay ***@***.***> wrote:
> Got it. And thank you for the explanation!
>
> This goes beyond my JS understanding. I though the JS in the iframe would
> have been sandboxed and not able to affect the main page. It sounds like my
> understanding is not correct.
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/beam/pull/21939#issuecomment-1159791971>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAJ5Z3E72N4QVR2ZY66NZQTVP5T2PANCNFSM5ZD45DZQ>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem merged pull request #21939: Removing playground from main page due to scrolling
Posted by GitBox <gi...@apache.org>.
pabloem merged PR #21939:
URL: https://github.com/apache/beam/pull/21939
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org