You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/16 20:18:50 UTC
[GitHub] [spark] amaliujia opened a new pull request, #38678: [SPARK-41164][CONNECT] Update relations.proto to follow Connect Proto development guide
amaliujia opened a new pull request, #38678:
URL: https://github.com/apache/spark/pull/38678
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
As we have a guidance for Connect proto ([adding proto messages](https://github.com/apache/spark/blob/master/connector/connect/docs/adding-proto-messages.md)), this PR updates `relations.proto` to follow the development guide.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Follow development guide.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
NO
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
Existing UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #38678: [SPARK-41164][CONNECT] Update relations.proto to follow Connect proto development guide
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #38678: [SPARK-41164][CONNECT] Update relations.proto to follow Connect proto development guide
URL: https://github.com/apache/spark/pull/38678
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #38678: [SPARK-41164][CONNECT] Update relations.proto to follow Connect proto development guide
Posted by GitBox <gi...@apache.org>.
amaliujia commented on code in PR #38678:
URL: https://github.com/apache/spark/pull/38678#discussion_r1025552911
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -106,24 +113,39 @@ message Project {
//
// For example, `SELECT ABS(-1)` is valid plan without an input plan.
Relation input = 1;
+
+ // (Required) A Project requires at least one expression.
repeated Expression expressions = 3;
}
// Relation that applies a boolean expression `condition` on each row of `input` to produce
// the output result.
message Filter {
+ // (Required) Input relation for a Filter.
Relation input = 1;
+
+ // (Required) A Filter must have a condition expression.
Expression condition = 2;
}
// Relation of type [[Join]].
//
// `left` and `right` must be present.
message Join {
+ // (Required) Left input relation for a Join.
Relation left = 1;
+
+ // (Required) Right input relation for a Join.
Relation right = 2;
+
+ // (Optional) The join condition. Could be unset when `using_columns` is utilized.
+ //
+ // This field does not co-exist with using_columns.
Expression join_condition = 3;
Review Comment:
In fact, not sure if we need to improve the proto style:
For a optional Message field, we also use `optional` to mark to keep consistency?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on pull request #38678: [SPARK-41164][CONNECT] Update relations.proto to follow Connect proto development guide
Posted by GitBox <gi...@apache.org>.
amaliujia commented on PR #38678:
URL: https://github.com/apache/spark/pull/38678#issuecomment-1317617606
@cloud-fan @grundprinzip @zhengruifeng
cc @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #38678: [SPARK-41164][CONNECT] Update relations.proto to follow Connect proto development guide
Posted by GitBox <gi...@apache.org>.
amaliujia commented on code in PR #38678:
URL: https://github.com/apache/spark/pull/38678#discussion_r1025551926
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -106,24 +113,39 @@ message Project {
//
// For example, `SELECT ABS(-1)` is valid plan without an input plan.
Relation input = 1;
+
+ // (Required) A Project requires at least one expression.
repeated Expression expressions = 3;
}
// Relation that applies a boolean expression `condition` on each row of `input` to produce
// the output result.
message Filter {
+ // (Required) Input relation for a Filter.
Relation input = 1;
+
+ // (Required) A Filter must have a condition expression.
Expression condition = 2;
}
// Relation of type [[Join]].
//
// `left` and `right` must be present.
message Join {
+ // (Required) Left input relation for a Join.
Relation left = 1;
+
+ // (Required) Right input relation for a Join.
Relation right = 2;
+
+ // (Optional) The join condition. Could be unset when `using_columns` is utilized.
+ //
+ // This field does not co-exist with using_columns.
Expression join_condition = 3;
Review Comment:
This is `Expression` which is a message. By default it has `has_field_name`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #38678: [SPARK-41164][CONNECT] Update relations.proto to follow Connect proto development guide
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on code in PR #38678:
URL: https://github.com/apache/spark/pull/38678#discussion_r1025196133
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -106,24 +113,39 @@ message Project {
//
// For example, `SELECT ABS(-1)` is valid plan without an input plan.
Relation input = 1;
+
+ // (Required) A Project requires at least one expression.
repeated Expression expressions = 3;
}
// Relation that applies a boolean expression `condition` on each row of `input` to produce
// the output result.
message Filter {
+ // (Required) Input relation for a Filter.
Relation input = 1;
+
+ // (Required) A Filter must have a condition expression.
Expression condition = 2;
}
// Relation of type [[Join]].
//
// `left` and `right` must be present.
message Join {
+ // (Required) Left input relation for a Join.
Relation left = 1;
+
+ // (Required) Right input relation for a Join.
Relation right = 2;
+
+ // (Optional) The join condition. Could be unset when `using_columns` is utilized.
+ //
+ // This field does not co-exist with using_columns.
Expression join_condition = 3;
Review Comment:
why is this not optional?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #38678: [SPARK-41164][CONNECT] Update relations.proto to follow Connect proto development guide
Posted by GitBox <gi...@apache.org>.
amaliujia commented on code in PR #38678:
URL: https://github.com/apache/spark/pull/38678#discussion_r1025551926
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -106,24 +113,39 @@ message Project {
//
// For example, `SELECT ABS(-1)` is valid plan without an input plan.
Relation input = 1;
+
+ // (Required) A Project requires at least one expression.
repeated Expression expressions = 3;
}
// Relation that applies a boolean expression `condition` on each row of `input` to produce
// the output result.
message Filter {
+ // (Required) Input relation for a Filter.
Relation input = 1;
+
+ // (Required) A Filter must have a condition expression.
Expression condition = 2;
}
// Relation of type [[Join]].
//
// `left` and `right` must be present.
message Join {
+ // (Required) Left input relation for a Join.
Relation left = 1;
+
+ // (Required) Right input relation for a Join.
Relation right = 2;
+
+ // (Optional) The join condition. Could be unset when `using_columns` is utilized.
+ //
+ // This field does not co-exist with using_columns.
Expression join_condition = 3;
Review Comment:
This is `Expression` which is a message. By default it has `has_field_name`.
I think per current proto sytle guide we do not need `optional` for messages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #38678: [SPARK-41164][CONNECT] Update relations.proto to follow Connect proto development guide
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #38678:
URL: https://github.com/apache/spark/pull/38678#issuecomment-1318461338
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org