[GitHub] [iceberg] rdblue commented on a change in pull request #3938: API: Disallow Namespace with null byte character or null level in it

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #3938:
URL: https://github.com/apache/iceberg/pull/3938#discussion_r805434503



##########
File path: api/src/main/java/org/apache/iceberg/catalog/Namespace.java
##########
@@ -29,6 +31,8 @@
 public class Namespace {
   private static final Namespace EMPTY_NAMESPACE = new Namespace(new String[] {});
   private static final Joiner DOT = Joiner.on('.');
+  private static final Predicate<String> CONTAINS_NULL_BYTE =
+      Pattern.compile("\0|\u0000", Pattern.UNICODE_CHARACTER_CLASS).asPredicate();

Review comment:
       What's the difference between `\0` and `\u0000`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org