You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Daniel Barclay <db...@maprtech.com> on 2015/04/10 03:32:41 UTC
Review Request 33044: DRILL-2613: 2-Core: Impl. ResultSet.getXxx(...)
number-to-number data conversions.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33044/
-----------------------------------------------------------
Review request for drill, Mehant Baid and Parth Chandra.
Bugs: DRILL-2613
https://issues.apache.org/jira/browse/DRILL-2613
Repository: drill-git
Description
-------
- Created tests:
- integration-level unit test ResultSetGetMethodConversionsTest
- unit-level unit test TypeConvertingAccessorSqlTest
- Created number-converting TypeConvertingSqlAccessor.
- Created conversion exceptions (SQLConversionException, SQLConversionOverflowException).
- Adjusted things:
- Moved InvalidAccessException out into its own file, refined ancestry.
- Moved getType() up to SqlAccessor (for access by TypeConvertingSqlAccessor).
- Made AbstractSqlAccessor public (for use by TypeConvertingSqlAccessor).
- Documented supported ResultSet.getXxx(...) conversions (on new interface
DrillResultSet).
Diffs
-----
exec/java-exec/src/main/codegen/templates/SqlAccessors.java c0ece9b
exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/AbstractSqlAccessor.java 1605c7d
exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/BoundCheckingAccessor.java c8d6cc7
exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/GenericAccessor.java adee171
exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/InvalidAccessException.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/SqlAccessor.java 6007bf4
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillAccessorList.java ccf2658
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillResultSet.java 74900bc
exec/jdbc/src/main/java/org/apache/drill/jdbc/SQLConversionException.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/SQLConversionOverflowException.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/TypeConvertingSqlAccessor.java PRE-CREATION
exec/jdbc/src/test/java/org/apache/drill/jdbc/ResultSetGetMethodConversionsTest.java PRE-CREATION
exec/jdbc/src/test/java/org/apache/drill/jdbc/impl/TypeConvertingSqlAccessorTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/33044/diff/
Testing
-------
Ran new specific tests.
Ran existing tests.
Thanks,
Daniel Barclay
Re: Review Request 33044: DRILL-2613: 2-Core: Impl.
ResultSet.getXxx(...) number-to-number data conversions.
Posted by Parth Chandra <pc...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33044/#review79892
-----------------------------------------------------------
Ship it!
Ship It!
- Parth Chandra
On April 10, 2015, 1:32 a.m., Daniel Barclay wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33044/
> -----------------------------------------------------------
>
> (Updated April 10, 2015, 1:32 a.m.)
>
>
> Review request for drill, Mehant Baid and Parth Chandra.
>
>
> Bugs: DRILL-2613
> https://issues.apache.org/jira/browse/DRILL-2613
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> - Created tests:
> - integration-level unit test ResultSetGetMethodConversionsTest
> - unit-level unit test TypeConvertingAccessorSqlTest
> - Created number-converting TypeConvertingSqlAccessor.
> - Created conversion exceptions (SQLConversionException, SQLConversionOverflowException).
> - Adjusted things:
> - Moved InvalidAccessException out into its own file, refined ancestry.
> - Moved getType() up to SqlAccessor (for access by TypeConvertingSqlAccessor).
> - Made AbstractSqlAccessor public (for use by TypeConvertingSqlAccessor).
> - Documented supported ResultSet.getXxx(...) conversions (on new interface
> DrillResultSet).
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/codegen/templates/SqlAccessors.java c0ece9b
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/AbstractSqlAccessor.java 1605c7d
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/BoundCheckingAccessor.java c8d6cc7
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/GenericAccessor.java adee171
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/InvalidAccessException.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/SqlAccessor.java 6007bf4
> exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillAccessorList.java ccf2658
> exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillResultSet.java 74900bc
> exec/jdbc/src/main/java/org/apache/drill/jdbc/SQLConversionException.java PRE-CREATION
> exec/jdbc/src/main/java/org/apache/drill/jdbc/SQLConversionOverflowException.java PRE-CREATION
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/TypeConvertingSqlAccessor.java PRE-CREATION
> exec/jdbc/src/test/java/org/apache/drill/jdbc/ResultSetGetMethodConversionsTest.java PRE-CREATION
> exec/jdbc/src/test/java/org/apache/drill/jdbc/impl/TypeConvertingSqlAccessorTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33044/diff/
>
>
> Testing
> -------
>
> Ran new specific tests.
>
> Ran existing tests.
>
>
> Thanks,
>
> Daniel Barclay
>
>
Re: Review Request 33044: DRILL-2613: 2-Core: Impl.
ResultSet.getXxx(...) number-to-number data conversions.
Posted by Daniel Barclay <db...@maprtech.com>.
> On April 10, 2015, 9:11 p.m., Parth Chandra wrote:
> > exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/AbstractSqlAccessor.java, line 37
> > <https://reviews.apache.org/r/33044/diff/1/?file=922057#file922057line37>
> >
> > Did you mean to remove the space between new and InvalidAccessException?
Yes; it's now calling a utility method to create the exception (so that the utility method, rather than the exception class, deals with the specifics of assembling the message).
> On April 10, 2015, 9:11 p.m., Parth Chandra wrote:
> > exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillResultSet.java, line 372
> > <https://reviews.apache.org/r/33044/diff/1/?file=922063#file922063line372>
> >
> > Can we remove all these commented out methods?
I'd rather not remove them until I'm done making JDBC changes that use the order information in them.
I simplified the comments to try to reduce the clutter:
- eliminated tokens other than those needed to identify the specific method (the method signature).
- eliminated the blank lines between and line breaks within the method signatures.
Does that help enough?
> On April 10, 2015, 9:11 p.m., Parth Chandra wrote:
> > exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/TypeConvertingSqlAccessor.java, line 406
> > <https://reviews.apache.org/r/33044/diff/1/?file=922066#file922066line406>
> >
> > call getIntValueorThrow instead?
Not the method taking type double that was there.
However, I did add a method taking type long, paralleling that sibling method and the surrounding pattern.
- Daniel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33044/#review79736
-----------------------------------------------------------
On April 10, 2015, 1:32 a.m., Daniel Barclay wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33044/
> -----------------------------------------------------------
>
> (Updated April 10, 2015, 1:32 a.m.)
>
>
> Review request for drill, Mehant Baid and Parth Chandra.
>
>
> Bugs: DRILL-2613
> https://issues.apache.org/jira/browse/DRILL-2613
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> - Created tests:
> - integration-level unit test ResultSetGetMethodConversionsTest
> - unit-level unit test TypeConvertingAccessorSqlTest
> - Created number-converting TypeConvertingSqlAccessor.
> - Created conversion exceptions (SQLConversionException, SQLConversionOverflowException).
> - Adjusted things:
> - Moved InvalidAccessException out into its own file, refined ancestry.
> - Moved getType() up to SqlAccessor (for access by TypeConvertingSqlAccessor).
> - Made AbstractSqlAccessor public (for use by TypeConvertingSqlAccessor).
> - Documented supported ResultSet.getXxx(...) conversions (on new interface
> DrillResultSet).
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/codegen/templates/SqlAccessors.java c0ece9b
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/AbstractSqlAccessor.java 1605c7d
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/BoundCheckingAccessor.java c8d6cc7
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/GenericAccessor.java adee171
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/InvalidAccessException.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/SqlAccessor.java 6007bf4
> exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillAccessorList.java ccf2658
> exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillResultSet.java 74900bc
> exec/jdbc/src/main/java/org/apache/drill/jdbc/SQLConversionException.java PRE-CREATION
> exec/jdbc/src/main/java/org/apache/drill/jdbc/SQLConversionOverflowException.java PRE-CREATION
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/TypeConvertingSqlAccessor.java PRE-CREATION
> exec/jdbc/src/test/java/org/apache/drill/jdbc/ResultSetGetMethodConversionsTest.java PRE-CREATION
> exec/jdbc/src/test/java/org/apache/drill/jdbc/impl/TypeConvertingSqlAccessorTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33044/diff/
>
>
> Testing
> -------
>
> Ran new specific tests.
>
> Ran existing tests.
>
>
> Thanks,
>
> Daniel Barclay
>
>
Re: Review Request 33044: DRILL-2613: 2-Core: Impl.
ResultSet.getXxx(...) number-to-number data conversions.
Posted by Parth Chandra <pc...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33044/#review79736
-----------------------------------------------------------
exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/AbstractSqlAccessor.java
<https://reviews.apache.org/r/33044/#comment129271>
Did you mean to remove the space between new and InvalidAccessException?
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillResultSet.java
<https://reviews.apache.org/r/33044/#comment129272>
Can we remove all these commented out methods?
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/TypeConvertingSqlAccessor.java
<https://reviews.apache.org/r/33044/#comment129282>
call getIntValueorThrow instead?
- Parth Chandra
On April 10, 2015, 1:32 a.m., Daniel Barclay wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33044/
> -----------------------------------------------------------
>
> (Updated April 10, 2015, 1:32 a.m.)
>
>
> Review request for drill, Mehant Baid and Parth Chandra.
>
>
> Bugs: DRILL-2613
> https://issues.apache.org/jira/browse/DRILL-2613
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> - Created tests:
> - integration-level unit test ResultSetGetMethodConversionsTest
> - unit-level unit test TypeConvertingAccessorSqlTest
> - Created number-converting TypeConvertingSqlAccessor.
> - Created conversion exceptions (SQLConversionException, SQLConversionOverflowException).
> - Adjusted things:
> - Moved InvalidAccessException out into its own file, refined ancestry.
> - Moved getType() up to SqlAccessor (for access by TypeConvertingSqlAccessor).
> - Made AbstractSqlAccessor public (for use by TypeConvertingSqlAccessor).
> - Documented supported ResultSet.getXxx(...) conversions (on new interface
> DrillResultSet).
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/codegen/templates/SqlAccessors.java c0ece9b
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/AbstractSqlAccessor.java 1605c7d
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/BoundCheckingAccessor.java c8d6cc7
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/GenericAccessor.java adee171
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/InvalidAccessException.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/SqlAccessor.java 6007bf4
> exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillAccessorList.java ccf2658
> exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillResultSet.java 74900bc
> exec/jdbc/src/main/java/org/apache/drill/jdbc/SQLConversionException.java PRE-CREATION
> exec/jdbc/src/main/java/org/apache/drill/jdbc/SQLConversionOverflowException.java PRE-CREATION
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/TypeConvertingSqlAccessor.java PRE-CREATION
> exec/jdbc/src/test/java/org/apache/drill/jdbc/ResultSetGetMethodConversionsTest.java PRE-CREATION
> exec/jdbc/src/test/java/org/apache/drill/jdbc/impl/TypeConvertingSqlAccessorTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33044/diff/
>
>
> Testing
> -------
>
> Ran new specific tests.
>
> Ran existing tests.
>
>
> Thanks,
>
> Daniel Barclay
>
>