You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/08/03 14:33:02 UTC
[GitHub] [ozone] adoroszlai opened a new pull request, #3651: HDDS-7043. Disallow trailing ellipsis in PR title
adoroszlai opened a new pull request, #3651:
URL: https://github.com/apache/ozone/pull/3651
## What changes were proposed in this pull request?
When opening a PR on Github, title is filled from commit message. If it is too long, an ellipsis (…) is added, and the rest of the message is moved to the PR description. The partial PR title could then end up in the final commit message if not corrected during merge. We should avoid such titles.
https://issues.apache.org/jira/browse/HDDS-7043
## How was this patch tested?
Added test case in `pr_title_check.bats`.
https://github.com/adoroszlai/hadoop-ozone/runs/7651057967?check_suite_focus=true#step:5:41
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kerneltime commented on a diff in pull request #3651: HDDS-7043. Disallow trailing ellipsis in PR title
Posted by GitBox <gi...@apache.org>.
kerneltime commented on code in PR #3651:
URL: https://github.com/apache/ozone/pull/3651#discussion_r940776988
##########
dev-support/ci/pr_title_check.sh:
##########
@@ -42,6 +42,8 @@ assertMatch '^HDDS-[1-9][0-9]{0,4}[^0-9]' 'Fail: Jira must be 1 to 5 di
assertMatch '^HDDS-[1-9][0-9]{0,4}\.' 'Fail: missing dot after Jira'
assertMatch '^HDDS-[1-9][0-9]{0,4}\. ' 'Fail: missing space after Jira'
assertNotMatch '[[:space:]]$' 'Fail: trailing space'
+assertNotMatch '\.{3,}$' 'Fail: trailing ellipsis indicates title is cut'
Review Comment:
Nit: Should this be length + trailing ellipsis? If not, the message can be that trailing ellipsis is not permitted.
The length (72) is the main cause here as it has prescriptive titles for commits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #3651: HDDS-7043. Disallow trailing ellipsis in PR title
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on PR #3651:
URL: https://github.com/apache/ozone/pull/3651#issuecomment-1214779620
> If only we can prevent GitHub new PR from wrapping long titles in the first place.
@smengcl It can be avoided by using command-line tool to open pull requests. (I use `hub`, but I guess `gh` also works for this.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kerneltime merged pull request #3651: HDDS-7043. Disallow trailing ellipsis in PR title
Posted by GitBox <gi...@apache.org>.
kerneltime merged PR #3651:
URL: https://github.com/apache/ozone/pull/3651
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #3651: HDDS-7043. Disallow trailing ellipsis in PR title
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on PR #3651:
URL: https://github.com/apache/ozone/pull/3651#issuecomment-1214777100
Thanks @kerneltime and @smengcl for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org