You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@bookkeeper.apache.org by "Ivan Kelly (JIRA)" <ji...@apache.org> on 2012/11/14 18:24:12 UTC

[jira] [Commented] (BOOKKEEPER-445) LOG.trace calls in Bookie.java

    [ https://issues.apache.org/jira/browse/BOOKKEEPER-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497241#comment-13497241 ] 

Ivan Kelly commented on BOOKKEEPER-445:
---------------------------------------

This change is unnecessary. The whole point of "{}" is that the string formatting is not done if the log category is not enabled.
                
> LOG.trace calls in Bookie.java
> ------------------------------
>
>                 Key: BOOKKEEPER-445
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-445
>             Project: Bookkeeper
>          Issue Type: Improvement
>            Reporter: Flavio Junqueira
>            Assignee: Flavio Junqueira
>            Priority: Minor
>         Attachments: BOOKKEEPER-445.patch, BOOKKEEPER-445.patch
>
>
> I suggest we put them in an if block.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira