You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "Technoboy- (via GitHub)" <gi...@apache.org> on 2024/01/18 16:45:59 UTC
[PR] [improve] [broker] PIP-299-part-5: Add namespace-level policy: dispatcherPauseOnAckStatePersistent [pulsar]
Technoboy- opened a new pull request, #21926:
URL: https://github.com/apache/pulsar/pull/21926
### Motivation
The part 5 of [PIP-299](https://github.com/apache/pulsar/pull/21118/files?short_path=cf766b5#diff-cf766b5d463b6832017e482baad14832f6a4d41dc969da279b98b69e26ec6f6a): the implementation of "Add dynamic config support: dispatcherPauseOnAckStatePersistentEnabled"
Related PRs:
- [x] https://github.com/apache/pulsar/pull/21423
- [x] https://github.com/apache/pulsar/pull/21370
- [x] https://github.com/apache/pulsar/pull/21837
- [x] https://github.com/apache/pulsar/pull/21874
- part-5: Namespace level policies support
- part-6: Doc
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve] [broker] PIP-299-part-5: Add namespace-level policy: dispatcherPauseOnAckStatePersistent [pulsar]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #21926:
URL: https://github.com/apache/pulsar/pull/21926#issuecomment-1899774940
## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/21926?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: `11 lines` in your changes are missing coverage. Please review.
> Comparison is base [(`22838ea`)](https://app.codecov.io/gh/apache/pulsar/commit/22838eae2f3b365abe09e305d15dbc198b58a231?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 36.46% compared to head [(`1190461`)](https://app.codecov.io/gh/apache/pulsar/pull/21926?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 73.61%.
> Report is 2 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/pulsar/pull/21926?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #21926 +/- ##
=============================================
+ Coverage 36.46% 73.61% +37.14%
- Complexity 12390 32422 +20032
=============================================
Files 1725 1861 +136
Lines 131701 138664 +6963
Branches 14401 15186 +785
=============================================
+ Hits 48027 102072 +54045
+ Misses 77254 28705 -48549
- Partials 6420 7887 +1467
```
| [Flag](https://app.codecov.io/gh/apache/pulsar/pull/21926/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [inttests](https://app.codecov.io/gh/apache/pulsar/pull/21926/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `24.10% <5.26%> (-0.01%)` | :arrow_down: |
| [systests](https://app.codecov.io/gh/apache/pulsar/pull/21926/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `23.60% <3.94%> (-0.07%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/pulsar/pull/21926/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `72.90% <85.52%> (+40.86%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files](https://app.codecov.io/gh/apache/pulsar/pull/21926?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...rg/apache/pulsar/broker/service/AbstractTopic.java](https://app.codecov.io/gh/apache/pulsar/pull/21926?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL0Fic3RyYWN0VG9waWMuamF2YQ==) | `87.91% <100.00%> (+24.65%)` | :arrow_up: |
| [...ava/org/apache/pulsar/client/admin/Namespaces.java](https://app.codecov.io/gh/apache/pulsar/pull/21926?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWNsaWVudC1hZG1pbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3B1bHNhci9jbGllbnQvYWRtaW4vTmFtZXNwYWNlcy5qYXZh) | `66.66% <ø> (+66.66%)` | :arrow_up: |
| [...e/pulsar/client/admin/internal/NamespacesImpl.java](https://app.codecov.io/gh/apache/pulsar/pull/21926?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWNsaWVudC1hZG1pbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC9hZG1pbi9pbnRlcm5hbC9OYW1lc3BhY2VzSW1wbC5qYXZh) | `95.44% <100.00%> (+74.90%)` | :arrow_up: |
| [...ava/org/apache/pulsar/admin/cli/CmdNamespaces.java](https://app.codecov.io/gh/apache/pulsar/pull/21926?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWNsaWVudC10b29scy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2FkbWluL2NsaS9DbWROYW1lc3BhY2VzLmphdmE=) | `78.57% <100.00%> (+78.57%)` | :arrow_up: |
| [...apache/pulsar/common/policies/data/PolicyName.java](https://app.codecov.io/gh/apache/pulsar/pull/21926?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NvbW1vbi9wb2xpY2llcy9kYXRhL1BvbGljeU5hbWUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...che/pulsar/common/policies/data/TopicPolicies.java](https://app.codecov.io/gh/apache/pulsar/pull/21926?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NvbW1vbi9wb2xpY2llcy9kYXRhL1RvcGljUG9saWNpZXMuamF2YQ==) | `58.73% <100.00%> (+6.34%)` | :arrow_up: |
| [...pache/pulsar/broker/admin/impl/NamespacesBase.java](https://app.codecov.io/gh/apache/pulsar/pull/21926?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9hZG1pbi9pbXBsL05hbWVzcGFjZXNCYXNlLmphdmE=) | `73.04% <81.81%> (+43.69%)` | :arrow_up: |
| [...g/apache/pulsar/common/policies/data/Policies.java](https://app.codecov.io/gh/apache/pulsar/pull/21926?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWNsaWVudC1hZG1pbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3B1bHNhci9jb21tb24vcG9saWNpZXMvZGF0YS9Qb2xpY2llcy5qYXZh) | `57.14% <0.00%> (+3.80%)` | :arrow_up: |
| [.../org/apache/pulsar/broker/admin/v2/Namespaces.java](https://app.codecov.io/gh/apache/pulsar/pull/21926?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9hZG1pbi92Mi9OYW1lc3BhY2VzLmphdmE=) | `69.09% <79.31%> (+52.59%)` | :arrow_up: |
... and [1431 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/21926/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve] [broker] PIP-299-part-5: Add namespace-level policy: dispatcherPauseOnAckStatePersistent [pulsar]
Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- commented on PR #21926:
URL: https://github.com/apache/pulsar/pull/21926#issuecomment-1899513314
> We can enable the case `TypeOfUpdateTopicConfig.NAMESPACE_LEVEL_POLICY` of the test `testBrokerDynamicConfig` now.
>
> ```java
> @DataProvider(name = "typesOfSetDispatcherPauseOnAckStatePersistent")
> public Object[][] typesOfSetDispatcherPauseOnAckStatePersistent() {
> return new Object[][]{
> {TypeOfUpdateTopicConfig.BROKER_CONF},
> // {TypeOfUpdateTopicConfig.NAMESPACE_LEVEL_POLICY},
> {TypeOfUpdateTopicConfig.TOPIC_LEVEL_POLICY}
> };
> }
> ```
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve] [broker] PIP-299-part-5: Add namespace-level policy: dispatcherPauseOnAckStatePersistent [pulsar]
Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- merged PR #21926:
URL: https://github.com/apache/pulsar/pull/21926
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org