[jira] [Commented] (GEODE-3145) Add New Protocol to Geode JAR

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-3145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16067223#comment-16067223 ] 

ASF GitHub Bot commented on GEODE-3145:
---------------------------------------

GitHub user pivotal-amurmann opened a pull request:

    https://github.com/apache/geode/pull/611

    GEODE-3145 Add new protocol to Geode JAR

    Thank you for submitting a contribution to Apache Geode.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
    GEODE-3145
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    - [x] Does `gradlew build` run cleanly?
    
    - [ ] Have you written or updated unit tests to verify your changes?
    
    - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
    submit an update to your PR as soon as possible. If you need help, please send an
    email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pivotal-amurmann/geode feature/GEODE-3145

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/611.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #611
    
----
commit 3c19ea2a5ac3d5265b94aa55c453acadb198e340
Author: Alexander Murmann <am...@pivotal.io>
Date:   2017-06-28T20:59:43Z

    GEODE-3145 Add new protocol to Geode JAR

----


> Add New Protocol to Geode JAR
> -----------------------------
>
>                 Key: GEODE-3145
>                 URL: https://issues.apache.org/jira/browse/GEODE-3145
>             Project: Geode
>          Issue Type: Sub-task
>          Components: client/server
>            Reporter: Galen O'Sullivan
>            Assignee: Galen O'Sullivan
>
> Trying to use a Geode server with the new protocol flag enabled currently leads to the error "ClientProtocolMessageHandler implementation not found in JVM".
> This seems to be caused by the build script not linking geode-protobuf (and probably the protobuf dependency) into the assembled JAR.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)