You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2023/01/10 12:40:13 UTC
[GitHub] [arrow] js8544 opened a new pull request, #15293: GH-15292: [C++] Typeclass alias is missing in ExtensionArray
js8544 opened a new pull request, #15293:
URL: https://github.com/apache/arrow/pull/15293
# Which issue does this PR close?
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of old issues on JIRA the title also supports:
ARROW-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
Closes #15292
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
All array classes have the `using TypeClass = xxx` type alias except for ExtensionArray.
With the alias, it will be easier to write templated inline visitors such as the following code block:
```Cpp
class ExampleVisitor {
public:
template <typename T>
Status Visit(const T& arr) {
if constexpr (arrow::is_number_type<typename T::TypeClass>::value) {
///
} else {
///
}
return Status::OK();
}
};
```
Current it fails to compile with message: `No type named 'TypeClass' in 'arrow::ExtensionArray'`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #15293: GH-15292: [C++] Typeclass alias is missing in ExtensionArray
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #15293:
URL: https://github.com/apache/arrow/pull/15293#issuecomment-1381376215
Benchmark runs are scheduled for baseline = 252e1e04d1dbed684efb11f550a6b4c8a9603d45 and contender = df2aa384eedc6dfd2a816f66e3ef8af1ecda3e8f. df2aa384eedc6dfd2a816f66e3ef8af1ecda3e8f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/95fc77f256f340eba952a4acd6fecff0...954f278a036843789c3d44d0071f148f/)
[Failed :arrow_down:0.48% :arrow_up:0.03%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/8a3503d2d4db46bf9ee685587d6121dd...19d9be025a114580978aec5be3ff1530/)
[Finished :arrow_down:0.51% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/839b9918db7642df957c68ae4a580da0...e027839b7c584255ad65d1cf60330b90/)
[Finished :arrow_down:0.56% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/e7a392547f8b4afba137c2043274a456...fd042d57fc7f4bb5a37aa51a52bfeec7/)
Buildkite builds:
[Finished] [`df2aa384` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2163)
[Finished] [`df2aa384` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2186)
[Finished] [`df2aa384` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2158)
[Finished] [`df2aa384` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2179)
[Finished] [`252e1e04` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2162)
[Failed] [`252e1e04` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2185)
[Finished] [`252e1e04` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2157)
[Finished] [`252e1e04` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2178)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #15293: GH-15292: [C++] Typeclass alias is missing in ExtensionArray
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15293:
URL: https://github.com/apache/arrow/pull/15293#issuecomment-1377201302
:warning: GitHub issue #15292 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou merged pull request #15293: GH-15292: [C++] Typeclass alias is missing in ExtensionArray
Posted by GitBox <gi...@apache.org>.
pitrou merged PR #15293:
URL: https://github.com/apache/arrow/pull/15293
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #15293: GH-15292: [C++] Typeclass alias is missing in ExtensionArray
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15293:
URL: https://github.com/apache/arrow/pull/15293#issuecomment-1377201261
* Closes: #15292
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org