[jira] Commented: (COUCHDB-664) Terminate running replication tasks

["Chris Stockton (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/COUCHDB-664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12879116#action_12879116 ] 

Chris Stockton commented on COUCHDB-664:
----------------------------------------

I think this patch is good, but I am not sure it should be required for arguments to match. I.E.

Given a replication command of:
curl -X POST http://localhost:5984/_replicate  -d '{"source":"db1","target":"db2","continuous":true,"cancel":false, "create": true}' 
-> OK

curl -X POST http://localhost:5984/_replicate  -d '{"source":"db1","target":"db2","continuous":true,"cancel":true, "create": true}' 
-> OK

curl -X POST http://localhost:5984/_replicate  -d '{"source":"db1","target":"db2","continuous":true,"cancel":true, "create": true}' 
-> ERROR (create flag was true, instead of false)

curl -X POST http://localhost:5984/_replicate  -d '{"source":"db1","target":"db2","continuous":false,"cancel":true, "create": true}' 
-> ERROR (continuous flag was false, instead of true, this one is debatable)

In my opinion, the following should be sufficient.
curl -X POST http://localhost:5984/_replicate  -d '{"source":"db1","target":"db2","cancel":true}' 

> Terminate running replication tasks
> -----------------------------------
>
>                 Key: COUCHDB-664
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-664
>             Project: CouchDB
>          Issue Type: New Feature
>          Components: Database Core
>    Affects Versions: 0.11
>            Reporter: Robert Newson
>             Fix For: 0.11
>
>         Attachments: 0001-add-ability-to-cancel-replication-tasks.patch
>
>
> a patch to kill running replication tasks.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.