[GitHub] hughhhh commented on a change in pull request #5376: [bugfix] make MetricsControl work with DECK visualizations

[GitBox <gi...@apache.org>]

hughhhh commented on a change in pull request #5376: [bugfix] make MetricsControl work with DECK visualizations
URL: https://github.com/apache/incubator-superset/pull/5376#discussion_r201844996
 
 

 ##########
 File path: superset/viz.py
 ##########
 @@ -2079,6 +2079,14 @@ def process_spatial_query_obj(self, key, group_by):
         elif spatial.get('type') == 'geohash':
             group_by += [spatial.get('geohashCol')]
 
+    @staticmethod
+    def parse_coordinates(s):
 
 Review comment:
   Can we get a unit test here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org