You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Francis Liu (JIRA)" <ji...@apache.org> on 2012/10/24 09:22:12 UTC
[jira] [Created] (HBASE-7042) Master Coprocessor Endpoint
Francis Liu created HBASE-7042:
----------------------------------
Summary: Master Coprocessor Endpoint
Key: HBASE-7042
URL: https://issues.apache.org/jira/browse/HBASE-7042
Project: HBase
Issue Type: Sub-task
Reporter: Francis Liu
Assignee: Francis Liu
Attachments: HBASE-7042_94.patch
Having support for a master coprocessor endpoint would enable developers to easily extended HMaster functionality/features. As is the case for region server grouping.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7042) Master Coprocessor Endpoint
Posted by "Francis Liu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Francis Liu updated HBASE-7042:
-------------------------------
Attachment: HBASE-7042_94_4.patch
> Master Coprocessor Endpoint
> ---------------------------
>
> Key: HBASE-7042
> URL: https://issues.apache.org/jira/browse/HBASE-7042
> Project: HBase
> Issue Type: Sub-task
> Reporter: Francis Liu
> Assignee: Francis Liu
> Fix For: 0.96.0
>
> Attachments: 7042-trunk.txt, HBASE-7042_2.patch, HBASE-7042_3.patch, HBASE-7042_94_2.patch, HBASE-7042_94_3.patch, HBASE-7042_94_4.patch, HBASE-7042_94_4.patch, HBASE-7042_94.patch, HBASE-7042.patch
>
>
> Having support for a master coprocessor endpoint would enable developers to easily extended HMaster functionality/features. As is the case for region server grouping.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7042) Master Coprocessor Endpoint
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497042#comment-13497042 ]
Hadoop QA commented on HBASE-7042:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12553486/HBASE-7042_3.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 93 warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 17 new Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3336//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3336//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3336//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3336//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3336//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3336//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3336//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3336//console
This message is automatically generated.
> Master Coprocessor Endpoint
> ---------------------------
>
> Key: HBASE-7042
> URL: https://issues.apache.org/jira/browse/HBASE-7042
> Project: HBase
> Issue Type: Sub-task
> Reporter: Francis Liu
> Assignee: Francis Liu
> Fix For: 0.96.0
>
> Attachments: 7042-trunk.txt, HBASE-7042_2.patch, HBASE-7042_3.patch, HBASE-7042_3.patch, HBASE-7042_94_2.patch, HBASE-7042_94_3.patch, HBASE-7042_94_4.patch, HBASE-7042_94_4.patch, HBASE-7042_94.patch, HBASE-7042.patch
>
>
> Having support for a master coprocessor endpoint would enable developers to easily extended HMaster functionality/features. As is the case for region server grouping.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7042) Master Coprocessor Endpoint
Posted by "Francis Liu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Francis Liu updated HBASE-7042:
-------------------------------
Attachment: HBASE-7042.patch
Protobuf version for trunk. I had to change the name of the master service to execMasterSerice() because Methods are cached only by name in a static map in ProtobufRPCEngine, which causes the unit test to fail because of an overlap in name. Seems a bit limiting was there a reason for this?
> Master Coprocessor Endpoint
> ---------------------------
>
> Key: HBASE-7042
> URL: https://issues.apache.org/jira/browse/HBASE-7042
> Project: HBase
> Issue Type: Sub-task
> Reporter: Francis Liu
> Assignee: Francis Liu
> Fix For: 0.96.0
>
> Attachments: HBASE-7042_94_2.patch, HBASE-7042_94.patch, HBASE-7042.patch
>
>
> Having support for a master coprocessor endpoint would enable developers to easily extended HMaster functionality/features. As is the case for region server grouping.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7042) Master Coprocessor Endpoint
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497665#comment-13497665 ]
stack commented on HBASE-7042:
------------------------------
Any of you fellas see this:
{code}
ERROR: java.lang.Error: Unresolved compilation problems:
The import org.apache.hadoop.hbase.ipc.MasterCoprocessorRpcChannel cannot be resolved
MasterCoprocessorRpcChannel cannot be resolved to a type
{code}
When try to run the shell and then create a table?
> Master Coprocessor Endpoint
> ---------------------------
>
> Key: HBASE-7042
> URL: https://issues.apache.org/jira/browse/HBASE-7042
> Project: HBase
> Issue Type: Sub-task
> Reporter: Francis Liu
> Assignee: Francis Liu
> Fix For: 0.96.0
>
> Attachments: HBASE-7042_2.patch, HBASE-7042_3.patch, HBASE-7042_94_2.patch, HBASE-7042_94_3.patch, HBASE-7042_94_4.patch, HBASE-7042_94_4.patch, HBASE-7042_94.patch, HBASE-7042.patch
>
>
> Having support for a master coprocessor endpoint would enable developers to easily extended HMaster functionality/features. As is the case for region server grouping.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7042) Master Coprocessor Endpoint
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13494751#comment-13494751 ]
Hadoop QA commented on HBASE-7042:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12552988/7042-trunk.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 87 warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 18 new Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3302//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3302//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3302//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3302//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3302//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3302//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3302//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3302//console
This message is automatically generated.
> Master Coprocessor Endpoint
> ---------------------------
>
> Key: HBASE-7042
> URL: https://issues.apache.org/jira/browse/HBASE-7042
> Project: HBase
> Issue Type: Sub-task
> Reporter: Francis Liu
> Assignee: Francis Liu
> Fix For: 0.96.0
>
> Attachments: 7042-trunk.txt, HBASE-7042_2.patch, HBASE-7042_94_2.patch, HBASE-7042_94_3.patch, HBASE-7042_94.patch, HBASE-7042.patch
>
>
> Having support for a master coprocessor endpoint would enable developers to easily extended HMaster functionality/features. As is the case for region server grouping.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7042) Master Coprocessor Endpoint
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Yu updated HBASE-7042:
--------------------------
Attachment: (was: 7042-trunk.txt)
> Master Coprocessor Endpoint
> ---------------------------
>
> Key: HBASE-7042
> URL: https://issues.apache.org/jira/browse/HBASE-7042
> Project: HBase
> Issue Type: Sub-task
> Reporter: Francis Liu
> Assignee: Francis Liu
> Fix For: 0.96.0
>
> Attachments: HBASE-7042_2.patch, HBASE-7042_3.patch, HBASE-7042_94_2.patch, HBASE-7042_94_3.patch, HBASE-7042_94_4.patch, HBASE-7042_94_4.patch, HBASE-7042_94.patch, HBASE-7042.patch
>
>
> Having support for a master coprocessor endpoint would enable developers to easily extended HMaster functionality/features. As is the case for region server grouping.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7042) Master Coprocessor Endpoint
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Yu updated HBASE-7042:
--------------------------
Attachment: 7042-trunk.txt
> Master Coprocessor Endpoint
> ---------------------------
>
> Key: HBASE-7042
> URL: https://issues.apache.org/jira/browse/HBASE-7042
> Project: HBase
> Issue Type: Sub-task
> Reporter: Francis Liu
> Assignee: Francis Liu
> Fix For: 0.96.0
>
> Attachments: HBASE-7042_94_2.patch, HBASE-7042_94_3.patch, HBASE-7042_94.patch, HBASE-7042.patch
>
>
> Having support for a master coprocessor endpoint would enable developers to easily extended HMaster functionality/features. As is the case for region server grouping.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7042) Master Coprocessor Endpoint
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Yu updated HBASE-7042:
--------------------------
Attachment: 7042-trunk.txt
> Master Coprocessor Endpoint
> ---------------------------
>
> Key: HBASE-7042
> URL: https://issues.apache.org/jira/browse/HBASE-7042
> Project: HBase
> Issue Type: Sub-task
> Reporter: Francis Liu
> Assignee: Francis Liu
> Fix For: 0.96.0
>
> Attachments: 7042-trunk.txt, HBASE-7042_94_2.patch, HBASE-7042_94_3.patch, HBASE-7042_94.patch, HBASE-7042.patch
>
>
> Having support for a master coprocessor endpoint would enable developers to easily extended HMaster functionality/features. As is the case for region server grouping.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7042) Master Coprocessor Endpoint
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497271#comment-13497271 ]
stack commented on HBASE-7042:
------------------------------
Thanks. I missed Gary's review. Thanks for committing.
> Master Coprocessor Endpoint
> ---------------------------
>
> Key: HBASE-7042
> URL: https://issues.apache.org/jira/browse/HBASE-7042
> Project: HBase
> Issue Type: Sub-task
> Reporter: Francis Liu
> Assignee: Francis Liu
> Fix For: 0.96.0
>
> Attachments: HBASE-7042_2.patch, HBASE-7042_3.patch, HBASE-7042_94_2.patch, HBASE-7042_94_3.patch, HBASE-7042_94_4.patch, HBASE-7042_94_4.patch, HBASE-7042_94.patch, HBASE-7042.patch
>
>
> Having support for a master coprocessor endpoint would enable developers to easily extended HMaster functionality/features. As is the case for region server grouping.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7042) Master Coprocessor Endpoint
Posted by "Francis Liu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Francis Liu updated HBASE-7042:
-------------------------------
Attachment: HBASE-7042_2.patch
addressed Ted's comments.
> Master Coprocessor Endpoint
> ---------------------------
>
> Key: HBASE-7042
> URL: https://issues.apache.org/jira/browse/HBASE-7042
> Project: HBase
> Issue Type: Sub-task
> Reporter: Francis Liu
> Assignee: Francis Liu
> Fix For: 0.96.0
>
> Attachments: 7042-trunk.txt, HBASE-7042_2.patch, HBASE-7042_94_2.patch, HBASE-7042_94_3.patch, HBASE-7042_94.patch, HBASE-7042.patch
>
>
> Having support for a master coprocessor endpoint would enable developers to easily extended HMaster functionality/features. As is the case for region server grouping.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7042) Master Coprocessor Endpoint
Posted by "Francis Liu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13491252#comment-13491252 ]
Francis Liu commented on HBASE-7042:
------------------------------------
0.94 patch
https://reviews.apache.org/r/7892/diff/#index_header
> Master Coprocessor Endpoint
> ---------------------------
>
> Key: HBASE-7042
> URL: https://issues.apache.org/jira/browse/HBASE-7042
> Project: HBase
> Issue Type: Sub-task
> Reporter: Francis Liu
> Assignee: Francis Liu
> Fix For: 0.96.0
>
> Attachments: HBASE-7042_94_2.patch, HBASE-7042_94_3.patch, HBASE-7042_94.patch, HBASE-7042.patch
>
>
> Having support for a master coprocessor endpoint would enable developers to easily extended HMaster functionality/features. As is the case for region server grouping.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7042) Master Coprocessor Endpoint
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489829#comment-13489829 ]
Andrew Purtell commented on HBASE-7042:
---------------------------------------
bq. Apart from being a bit clunky I made them separate so that each class can evolve without master/region usages stepping/confusing on each other. If you think this is ok I'm fine with reusing the Exec and ExecResult.
Sounds great.
bq. I believe your concern can be addressed by making system coprocessors reloadable. Which I think we should do for both master and region coprocessors anyway. This we can address in a separate jira?
Ok.
> Master Coprocessor Endpoint
> ---------------------------
>
> Key: HBASE-7042
> URL: https://issues.apache.org/jira/browse/HBASE-7042
> Project: HBase
> Issue Type: Sub-task
> Reporter: Francis Liu
> Assignee: Francis Liu
> Fix For: 0.96.0
>
> Attachments: HBASE-7042_94.patch
>
>
> Having support for a master coprocessor endpoint would enable developers to easily extended HMaster functionality/features. As is the case for region server grouping.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7042) Master Coprocessor Endpoint
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483062#comment-13483062 ]
Hadoop QA commented on HBASE-7042:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12550596/HBASE-7042_94.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:green}+1 tests included{color}. The patch appears to include 9 new or modified tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3136//console
This message is automatically generated.
> Master Coprocessor Endpoint
> ---------------------------
>
> Key: HBASE-7042
> URL: https://issues.apache.org/jira/browse/HBASE-7042
> Project: HBase
> Issue Type: Sub-task
> Reporter: Francis Liu
> Assignee: Francis Liu
> Fix For: 0.96.0
>
> Attachments: HBASE-7042_94.patch
>
>
> Having support for a master coprocessor endpoint would enable developers to easily extended HMaster functionality/features. As is the case for region server grouping.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7042) Master Coprocessor Endpoint
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13491107#comment-13491107 ]
Hadoop QA commented on HBASE-7042:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12552197/HBASE-7042_94_2.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new or modified tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3230//console
This message is automatically generated.
> Master Coprocessor Endpoint
> ---------------------------
>
> Key: HBASE-7042
> URL: https://issues.apache.org/jira/browse/HBASE-7042
> Project: HBase
> Issue Type: Sub-task
> Reporter: Francis Liu
> Assignee: Francis Liu
> Fix For: 0.96.0
>
> Attachments: HBASE-7042_94_2.patch, HBASE-7042_94.patch
>
>
> Having support for a master coprocessor endpoint would enable developers to easily extended HMaster functionality/features. As is the case for region server grouping.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7042) Master Coprocessor Endpoint
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Yu updated HBASE-7042:
--------------------------
Attachment: (was: HBASE-7042_3.patch)
> Master Coprocessor Endpoint
> ---------------------------
>
> Key: HBASE-7042
> URL: https://issues.apache.org/jira/browse/HBASE-7042
> Project: HBase
> Issue Type: Sub-task
> Reporter: Francis Liu
> Assignee: Francis Liu
> Fix For: 0.96.0
>
> Attachments: HBASE-7042_2.patch, HBASE-7042_3.patch, HBASE-7042_94_2.patch, HBASE-7042_94_3.patch, HBASE-7042_94_4.patch, HBASE-7042_94_4.patch, HBASE-7042_94.patch, HBASE-7042.patch
>
>
> Having support for a master coprocessor endpoint would enable developers to easily extended HMaster functionality/features. As is the case for region server grouping.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7042) Master Coprocessor Endpoint
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13491227#comment-13491227 ]
Ted Yu commented on HBASE-7042:
-------------------------------
Line below is not needed:
{code}
+ * Copyright 2010 The Apache Software Foundation
{code}
{code}
+ private Map<String, Class<? extends CoprocessorProtocol>>
+ protocolHandlerNames = Maps.newHashMap();
{code}
The above is a map. How about naming it protocolsByName ?
MasterExec is referenced in two places, such as:
{code}
+ * be available for handling
+ * {@link HMaster#execCoprocessor(org.apache.hadoop.hbase.client.coprocessor.MasterExec)} calls.
{code}
Please replace it with Exec.
> Master Coprocessor Endpoint
> ---------------------------
>
> Key: HBASE-7042
> URL: https://issues.apache.org/jira/browse/HBASE-7042
> Project: HBase
> Issue Type: Sub-task
> Reporter: Francis Liu
> Assignee: Francis Liu
> Fix For: 0.96.0
>
> Attachments: HBASE-7042_94_2.patch, HBASE-7042_94.patch
>
>
> Having support for a master coprocessor endpoint would enable developers to easily extended HMaster functionality/features. As is the case for region server grouping.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7042) Master Coprocessor Endpoint
Posted by "Francis Liu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13491245#comment-13491245 ]
Francis Liu commented on HBASE-7042:
------------------------------------
{quote}
The above is a map. How about naming it protocolsByName ?
{quote}
Handler makes more sense since it is an implementation of a protocol and not the protocol itself. Also this is the same name used for the RegionEndpoint :-).
> Master Coprocessor Endpoint
> ---------------------------
>
> Key: HBASE-7042
> URL: https://issues.apache.org/jira/browse/HBASE-7042
> Project: HBase
> Issue Type: Sub-task
> Reporter: Francis Liu
> Assignee: Francis Liu
> Fix For: 0.96.0
>
> Attachments: HBASE-7042_94_2.patch, HBASE-7042_94.patch, HBASE-7042.patch
>
>
> Having support for a master coprocessor endpoint would enable developers to easily extended HMaster functionality/features. As is the case for region server grouping.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7042) Master Coprocessor Endpoint
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13496890#comment-13496890 ]
Hadoop QA commented on HBASE-7042:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12553460/HBASE-7042_94_4.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new or modified tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3333//console
This message is automatically generated.
> Master Coprocessor Endpoint
> ---------------------------
>
> Key: HBASE-7042
> URL: https://issues.apache.org/jira/browse/HBASE-7042
> Project: HBase
> Issue Type: Sub-task
> Reporter: Francis Liu
> Assignee: Francis Liu
> Fix For: 0.96.0
>
> Attachments: 7042-trunk.txt, HBASE-7042_2.patch, HBASE-7042_3.patch, HBASE-7042_94_2.patch, HBASE-7042_94_3.patch, HBASE-7042_94_4.patch, HBASE-7042_94_4.patch, HBASE-7042_94.patch, HBASE-7042.patch
>
>
> Having support for a master coprocessor endpoint would enable developers to easily extended HMaster functionality/features. As is the case for region server grouping.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7042) Master Coprocessor Endpoint
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497252#comment-13497252 ]
stack commented on HBASE-7042:
------------------------------
@Ted Did you get enough +1s to commit this?
> Master Coprocessor Endpoint
> ---------------------------
>
> Key: HBASE-7042
> URL: https://issues.apache.org/jira/browse/HBASE-7042
> Project: HBase
> Issue Type: Sub-task
> Reporter: Francis Liu
> Assignee: Francis Liu
> Fix For: 0.96.0
>
> Attachments: HBASE-7042_2.patch, HBASE-7042_3.patch, HBASE-7042_94_2.patch, HBASE-7042_94_3.patch, HBASE-7042_94_4.patch, HBASE-7042_94_4.patch, HBASE-7042_94.patch, HBASE-7042.patch
>
>
> Having support for a master coprocessor endpoint would enable developers to easily extended HMaster functionality/features. As is the case for region server grouping.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7042) Master Coprocessor Endpoint
Posted by "Francis Liu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488845#comment-13488845 ]
Francis Liu commented on HBASE-7042:
------------------------------------
Though I believe your concern can be addressed by making system coprocessors reloadable. Which I think we should do for both master and region coprocessors anyway. This we can address in a separate jira?
> Master Coprocessor Endpoint
> ---------------------------
>
> Key: HBASE-7042
> URL: https://issues.apache.org/jira/browse/HBASE-7042
> Project: HBase
> Issue Type: Sub-task
> Reporter: Francis Liu
> Assignee: Francis Liu
> Fix For: 0.96.0
>
> Attachments: HBASE-7042_94.patch
>
>
> Having support for a master coprocessor endpoint would enable developers to easily extended HMaster functionality/features. As is the case for region server grouping.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7042) Master Coprocessor Endpoint
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486443#comment-13486443 ]
Ted Yu commented on HBASE-7042:
-------------------------------
Would rolling-restart continue to work with this feature ?
> Master Coprocessor Endpoint
> ---------------------------
>
> Key: HBASE-7042
> URL: https://issues.apache.org/jira/browse/HBASE-7042
> Project: HBase
> Issue Type: Sub-task
> Reporter: Francis Liu
> Assignee: Francis Liu
> Fix For: 0.96.0
>
> Attachments: HBASE-7042_94.patch
>
>
> Having support for a master coprocessor endpoint would enable developers to easily extended HMaster functionality/features. As is the case for region server grouping.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7042) Master Coprocessor Endpoint
Posted by "Francis Liu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Francis Liu updated HBASE-7042:
-------------------------------
Attachment: HBASE-7042_3.patch
> Master Coprocessor Endpoint
> ---------------------------
>
> Key: HBASE-7042
> URL: https://issues.apache.org/jira/browse/HBASE-7042
> Project: HBase
> Issue Type: Sub-task
> Reporter: Francis Liu
> Assignee: Francis Liu
> Fix For: 0.96.0
>
> Attachments: 7042-trunk.txt, HBASE-7042_2.patch, HBASE-7042_3.patch, HBASE-7042_94_2.patch, HBASE-7042_94_3.patch, HBASE-7042_94.patch, HBASE-7042.patch
>
>
> Having support for a master coprocessor endpoint would enable developers to easily extended HMaster functionality/features. As is the case for region server grouping.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7042) Master Coprocessor Endpoint
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Yu updated HBASE-7042:
--------------------------
Attachment: HBASE-7042_3.patch
> Master Coprocessor Endpoint
> ---------------------------
>
> Key: HBASE-7042
> URL: https://issues.apache.org/jira/browse/HBASE-7042
> Project: HBase
> Issue Type: Sub-task
> Reporter: Francis Liu
> Assignee: Francis Liu
> Fix For: 0.96.0
>
> Attachments: 7042-trunk.txt, HBASE-7042_2.patch, HBASE-7042_3.patch, HBASE-7042_3.patch, HBASE-7042_94_2.patch, HBASE-7042_94_3.patch, HBASE-7042_94_4.patch, HBASE-7042_94_4.patch, HBASE-7042_94.patch, HBASE-7042.patch
>
>
> Having support for a master coprocessor endpoint would enable developers to easily extended HMaster functionality/features. As is the case for region server grouping.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7042) Master Coprocessor Endpoint
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497229#comment-13497229 ]
Ted Yu commented on HBASE-7042:
-------------------------------
Integrated to trunk.
Thanks for the patch, Francis.
Thanks for the review, Andy and Gary.
> Master Coprocessor Endpoint
> ---------------------------
>
> Key: HBASE-7042
> URL: https://issues.apache.org/jira/browse/HBASE-7042
> Project: HBase
> Issue Type: Sub-task
> Reporter: Francis Liu
> Assignee: Francis Liu
> Fix For: 0.96.0
>
> Attachments: HBASE-7042_2.patch, HBASE-7042_3.patch, HBASE-7042_94_2.patch, HBASE-7042_94_3.patch, HBASE-7042_94_4.patch, HBASE-7042_94_4.patch, HBASE-7042_94.patch, HBASE-7042.patch
>
>
> Having support for a master coprocessor endpoint would enable developers to easily extended HMaster functionality/features. As is the case for region server grouping.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7042) Master Coprocessor Endpoint
Posted by "Francis Liu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Francis Liu updated HBASE-7042:
-------------------------------
Attachment: HBASE-7042_94.patch
> Master Coprocessor Endpoint
> ---------------------------
>
> Key: HBASE-7042
> URL: https://issues.apache.org/jira/browse/HBASE-7042
> Project: HBase
> Issue Type: Sub-task
> Reporter: Francis Liu
> Assignee: Francis Liu
> Fix For: 0.96.0
>
> Attachments: HBASE-7042_94.patch
>
>
> Having support for a master coprocessor endpoint would enable developers to easily extended HMaster functionality/features. As is the case for region server grouping.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7042) Master Coprocessor Endpoint
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13494759#comment-13494759 ]
Hadoop QA commented on HBASE-7042:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12552991/HBASE-7042_2.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 87 warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 18 new Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.master.TestSplitLogManager
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3303//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3303//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3303//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3303//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3303//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3303//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3303//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3303//console
This message is automatically generated.
> Master Coprocessor Endpoint
> ---------------------------
>
> Key: HBASE-7042
> URL: https://issues.apache.org/jira/browse/HBASE-7042
> Project: HBase
> Issue Type: Sub-task
> Reporter: Francis Liu
> Assignee: Francis Liu
> Fix For: 0.96.0
>
> Attachments: 7042-trunk.txt, HBASE-7042_2.patch, HBASE-7042_94_2.patch, HBASE-7042_94_3.patch, HBASE-7042_94.patch, HBASE-7042.patch
>
>
> Having support for a master coprocessor endpoint would enable developers to easily extended HMaster functionality/features. As is the case for region server grouping.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7042) Master Coprocessor Endpoint
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497486#comment-13497486 ]
Ted Yu commented on HBASE-7042:
-------------------------------
Integrated to 0.94 as well.
> Master Coprocessor Endpoint
> ---------------------------
>
> Key: HBASE-7042
> URL: https://issues.apache.org/jira/browse/HBASE-7042
> Project: HBase
> Issue Type: Sub-task
> Reporter: Francis Liu
> Assignee: Francis Liu
> Fix For: 0.96.0
>
> Attachments: HBASE-7042_2.patch, HBASE-7042_3.patch, HBASE-7042_94_2.patch, HBASE-7042_94_3.patch, HBASE-7042_94_4.patch, HBASE-7042_94_4.patch, HBASE-7042_94.patch, HBASE-7042.patch
>
>
> Having support for a master coprocessor endpoint would enable developers to easily extended HMaster functionality/features. As is the case for region server grouping.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7042) Master Coprocessor Endpoint
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497286#comment-13497286 ]
Ted Yu commented on HBASE-7042:
-------------------------------
@Francis:
0.94 build #588 still had test failures.
I will wait for Lars' to give green light before integrating to 0.94 branch.
> Master Coprocessor Endpoint
> ---------------------------
>
> Key: HBASE-7042
> URL: https://issues.apache.org/jira/browse/HBASE-7042
> Project: HBase
> Issue Type: Sub-task
> Reporter: Francis Liu
> Assignee: Francis Liu
> Fix For: 0.96.0
>
> Attachments: HBASE-7042_2.patch, HBASE-7042_3.patch, HBASE-7042_94_2.patch, HBASE-7042_94_3.patch, HBASE-7042_94_4.patch, HBASE-7042_94_4.patch, HBASE-7042_94.patch, HBASE-7042.patch
>
>
> Having support for a master coprocessor endpoint would enable developers to easily extended HMaster functionality/features. As is the case for region server grouping.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7042) Master Coprocessor Endpoint
Posted by "Francis Liu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487560#comment-13487560 ]
Francis Liu commented on HBASE-7042:
------------------------------------
Ted, not sure why this would break rolling restart?
> Master Coprocessor Endpoint
> ---------------------------
>
> Key: HBASE-7042
> URL: https://issues.apache.org/jira/browse/HBASE-7042
> Project: HBase
> Issue Type: Sub-task
> Reporter: Francis Liu
> Assignee: Francis Liu
> Fix For: 0.96.0
>
> Attachments: HBASE-7042_94.patch
>
>
> Having support for a master coprocessor endpoint would enable developers to easily extended HMaster functionality/features. As is the case for region server grouping.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7042) Master Coprocessor Endpoint
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Yu updated HBASE-7042:
--------------------------
Attachment: (was: 7042-trunk.txt)
> Master Coprocessor Endpoint
> ---------------------------
>
> Key: HBASE-7042
> URL: https://issues.apache.org/jira/browse/HBASE-7042
> Project: HBase
> Issue Type: Sub-task
> Reporter: Francis Liu
> Assignee: Francis Liu
> Fix For: 0.96.0
>
> Attachments: HBASE-7042_94_2.patch, HBASE-7042_94_3.patch, HBASE-7042_94.patch, HBASE-7042.patch
>
>
> Having support for a master coprocessor endpoint would enable developers to easily extended HMaster functionality/features. As is the case for region server grouping.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7042) Master Coprocessor Endpoint
Posted by "Francis Liu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498163#comment-13498163 ]
Francis Liu commented on HBASE-7042:
------------------------------------
Just saw this today, thanks for trying it out again Stack.
Thanks for the reviews guys!
> Master Coprocessor Endpoint
> ---------------------------
>
> Key: HBASE-7042
> URL: https://issues.apache.org/jira/browse/HBASE-7042
> Project: HBase
> Issue Type: Sub-task
> Reporter: Francis Liu
> Assignee: Francis Liu
> Fix For: 0.96.0, 0.94.4
>
> Attachments: HBASE-7042_2.patch, HBASE-7042_3.patch, HBASE-7042_94_2.patch, HBASE-7042_94_3.patch, HBASE-7042_94_4.patch, HBASE-7042_94_4.patch, HBASE-7042_94.patch, HBASE-7042.patch
>
>
> Having support for a master coprocessor endpoint would enable developers to easily extended HMaster functionality/features. As is the case for region server grouping.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7042) Master Coprocessor Endpoint
Posted by "Francis Liu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Francis Liu updated HBASE-7042:
-------------------------------
Attachment: HBASE-7042_94_4.patch
> Master Coprocessor Endpoint
> ---------------------------
>
> Key: HBASE-7042
> URL: https://issues.apache.org/jira/browse/HBASE-7042
> Project: HBase
> Issue Type: Sub-task
> Reporter: Francis Liu
> Assignee: Francis Liu
> Fix For: 0.96.0
>
> Attachments: 7042-trunk.txt, HBASE-7042_2.patch, HBASE-7042_3.patch, HBASE-7042_94_2.patch, HBASE-7042_94_3.patch, HBASE-7042_94_4.patch, HBASE-7042_94.patch, HBASE-7042.patch
>
>
> Having support for a master coprocessor endpoint would enable developers to easily extended HMaster functionality/features. As is the case for region server grouping.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7042) Master Coprocessor Endpoint
Posted by "Francis Liu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483045#comment-13483045 ]
Francis Liu commented on HBASE-7042:
------------------------------------
Putting up a 0.94 patch for initial comments.
> Master Coprocessor Endpoint
> ---------------------------
>
> Key: HBASE-7042
> URL: https://issues.apache.org/jira/browse/HBASE-7042
> Project: HBase
> Issue Type: Sub-task
> Reporter: Francis Liu
> Assignee: Francis Liu
> Fix For: 0.96.0
>
> Attachments: HBASE-7042_94.patch
>
>
> Having support for a master coprocessor endpoint would enable developers to easily extended HMaster functionality/features. As is the case for region server grouping.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7042) Master Coprocessor Endpoint
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488753#comment-13488753 ]
Andrew Purtell commented on HBASE-7042:
---------------------------------------
It is possible to reuse Exec and ExecResult. Just ignore / don't set the row fields etc. Having separate classes for master exec only is not a clean API in my opinion.
The issue I see with supporting only system coprocessors is it requires deployment by way of XML config update as the sole option, which requires a process restart. Table CPs can be deployed to HDFS and then loaded dynamically with a schema update without needing to stop any process. Not supporting this latter option on the master seems a shortcut and limiting.
> Master Coprocessor Endpoint
> ---------------------------
>
> Key: HBASE-7042
> URL: https://issues.apache.org/jira/browse/HBASE-7042
> Project: HBase
> Issue Type: Sub-task
> Reporter: Francis Liu
> Assignee: Francis Liu
> Fix For: 0.96.0
>
> Attachments: HBASE-7042_94.patch
>
>
> Having support for a master coprocessor endpoint would enable developers to easily extended HMaster functionality/features. As is the case for region server grouping.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7042) Master Coprocessor Endpoint
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497753#comment-13497753 ]
stack commented on HBASE-7042:
------------------------------
Hmm... I tried it again and it just worked so nvm.
> Master Coprocessor Endpoint
> ---------------------------
>
> Key: HBASE-7042
> URL: https://issues.apache.org/jira/browse/HBASE-7042
> Project: HBase
> Issue Type: Sub-task
> Reporter: Francis Liu
> Assignee: Francis Liu
> Fix For: 0.96.0
>
> Attachments: HBASE-7042_2.patch, HBASE-7042_3.patch, HBASE-7042_94_2.patch, HBASE-7042_94_3.patch, HBASE-7042_94_4.patch, HBASE-7042_94_4.patch, HBASE-7042_94.patch, HBASE-7042.patch
>
>
> Having support for a master coprocessor endpoint would enable developers to easily extended HMaster functionality/features. As is the case for region server grouping.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7042) Master Coprocessor Endpoint
Posted by "Francis Liu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Francis Liu updated HBASE-7042:
-------------------------------
Status: Patch Available (was: Open)
> Master Coprocessor Endpoint
> ---------------------------
>
> Key: HBASE-7042
> URL: https://issues.apache.org/jira/browse/HBASE-7042
> Project: HBase
> Issue Type: Sub-task
> Reporter: Francis Liu
> Assignee: Francis Liu
> Fix For: 0.96.0
>
> Attachments: HBASE-7042_94.patch
>
>
> Having support for a master coprocessor endpoint would enable developers to easily extended HMaster functionality/features. As is the case for region server grouping.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7042) Master Coprocessor Endpoint
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Yu updated HBASE-7042:
--------------------------
Resolution: Fixed
Fix Version/s: 0.94.4
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
> Master Coprocessor Endpoint
> ---------------------------
>
> Key: HBASE-7042
> URL: https://issues.apache.org/jira/browse/HBASE-7042
> Project: HBase
> Issue Type: Sub-task
> Reporter: Francis Liu
> Assignee: Francis Liu
> Fix For: 0.96.0, 0.94.4
>
> Attachments: HBASE-7042_2.patch, HBASE-7042_3.patch, HBASE-7042_94_2.patch, HBASE-7042_94_3.patch, HBASE-7042_94_4.patch, HBASE-7042_94_4.patch, HBASE-7042_94.patch, HBASE-7042.patch
>
>
> Having support for a master coprocessor endpoint would enable developers to easily extended HMaster functionality/features. As is the case for region server grouping.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7042) Master Coprocessor Endpoint
Posted by "Francis Liu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Francis Liu updated HBASE-7042:
-------------------------------
Attachment: HBASE-7042_94_3.patch
addressed Ted's comments.
> Master Coprocessor Endpoint
> ---------------------------
>
> Key: HBASE-7042
> URL: https://issues.apache.org/jira/browse/HBASE-7042
> Project: HBase
> Issue Type: Sub-task
> Reporter: Francis Liu
> Assignee: Francis Liu
> Fix For: 0.96.0
>
> Attachments: HBASE-7042_94_2.patch, HBASE-7042_94_3.patch, HBASE-7042_94.patch, HBASE-7042.patch
>
>
> Having support for a master coprocessor endpoint would enable developers to easily extended HMaster functionality/features. As is the case for region server grouping.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7042) Master Coprocessor Endpoint
Posted by "Francis Liu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13491106#comment-13491106 ]
Francis Liu commented on HBASE-7042:
------------------------------------
Patch reusing Exec and ExecResult
> Master Coprocessor Endpoint
> ---------------------------
>
> Key: HBASE-7042
> URL: https://issues.apache.org/jira/browse/HBASE-7042
> Project: HBase
> Issue Type: Sub-task
> Reporter: Francis Liu
> Assignee: Francis Liu
> Fix For: 0.96.0
>
> Attachments: HBASE-7042_94_2.patch, HBASE-7042_94.patch
>
>
> Having support for a master coprocessor endpoint would enable developers to easily extended HMaster functionality/features. As is the case for region server grouping.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7042) Master Coprocessor Endpoint
Posted by "Francis Liu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497247#comment-13497247 ]
Francis Liu commented on HBASE-7042:
------------------------------------
Can we commit the 94 patch as well?
> Master Coprocessor Endpoint
> ---------------------------
>
> Key: HBASE-7042
> URL: https://issues.apache.org/jira/browse/HBASE-7042
> Project: HBase
> Issue Type: Sub-task
> Reporter: Francis Liu
> Assignee: Francis Liu
> Fix For: 0.96.0
>
> Attachments: HBASE-7042_2.patch, HBASE-7042_3.patch, HBASE-7042_94_2.patch, HBASE-7042_94_3.patch, HBASE-7042_94_4.patch, HBASE-7042_94_4.patch, HBASE-7042_94.patch, HBASE-7042.patch
>
>
> Having support for a master coprocessor endpoint would enable developers to easily extended HMaster functionality/features. As is the case for region server grouping.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7042) Master Coprocessor Endpoint
Posted by "Francis Liu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13491243#comment-13491243 ]
Francis Liu commented on HBASE-7042:
------------------------------------
reviewboard for trunk:
https://reviews.apache.org/r/7890/
> Master Coprocessor Endpoint
> ---------------------------
>
> Key: HBASE-7042
> URL: https://issues.apache.org/jira/browse/HBASE-7042
> Project: HBase
> Issue Type: Sub-task
> Reporter: Francis Liu
> Assignee: Francis Liu
> Fix For: 0.96.0
>
> Attachments: HBASE-7042_94_2.patch, HBASE-7042_94.patch, HBASE-7042.patch
>
>
> Having support for a master coprocessor endpoint would enable developers to easily extended HMaster functionality/features. As is the case for region server grouping.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7042) Master Coprocessor Endpoint
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13491250#comment-13491250 ]
Hadoop QA commented on HBASE-7042:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12552222/HBASE-7042_94_3.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new or modified tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3231//console
This message is automatically generated.
> Master Coprocessor Endpoint
> ---------------------------
>
> Key: HBASE-7042
> URL: https://issues.apache.org/jira/browse/HBASE-7042
> Project: HBase
> Issue Type: Sub-task
> Reporter: Francis Liu
> Assignee: Francis Liu
> Fix For: 0.96.0
>
> Attachments: HBASE-7042_94_2.patch, HBASE-7042_94_3.patch, HBASE-7042_94.patch, HBASE-7042.patch
>
>
> Having support for a master coprocessor endpoint would enable developers to easily extended HMaster functionality/features. As is the case for region server grouping.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7042) Master Coprocessor Endpoint
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497297#comment-13497297 ]
Hudson commented on HBASE-7042:
-------------------------------
Integrated in HBase-TRUNK #3541 (See [https://builds.apache.org/job/HBase-TRUNK/3541/])
HBASE-7042 Master Coprocessor Endpoint (Francis Liu) (Revision 1409257)
Result = FAILURE
tedyu :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/HTable.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/CoprocessorRpcChannel.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/MasterCoprocessorRpcChannel.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RegionCoprocessorRpcChannel.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterServices.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/generated/MasterAdminProtos.java
* /hbase/trunk/hbase-server/src/main/protobuf/MasterAdmin.proto
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorEndpoint.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java
> Master Coprocessor Endpoint
> ---------------------------
>
> Key: HBASE-7042
> URL: https://issues.apache.org/jira/browse/HBASE-7042
> Project: HBase
> Issue Type: Sub-task
> Reporter: Francis Liu
> Assignee: Francis Liu
> Fix For: 0.96.0
>
> Attachments: HBASE-7042_2.patch, HBASE-7042_3.patch, HBASE-7042_94_2.patch, HBASE-7042_94_3.patch, HBASE-7042_94_4.patch, HBASE-7042_94_4.patch, HBASE-7042_94.patch, HBASE-7042.patch
>
>
> Having support for a master coprocessor endpoint would enable developers to easily extended HMaster functionality/features. As is the case for region server grouping.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7042) Master Coprocessor Endpoint
Posted by "Francis Liu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488849#comment-13488849 ]
Francis Liu commented on HBASE-7042:
------------------------------------
{quote}
It is possible to reuse Exec and ExecResult. Just ignore / don't set the row fields etc. Having separate classes for master exec only is not a clean API in my opinion.
{quote}
Apart from being a bit clunky I made them separate so that each class can evolve without master/region usages stepping/confusing on each other. If you think this is ok I'm fine with reusing the Exec and ExecResult.
> Master Coprocessor Endpoint
> ---------------------------
>
> Key: HBASE-7042
> URL: https://issues.apache.org/jira/browse/HBASE-7042
> Project: HBase
> Issue Type: Sub-task
> Reporter: Francis Liu
> Assignee: Francis Liu
> Fix For: 0.96.0
>
> Attachments: HBASE-7042_94.patch
>
>
> Having support for a master coprocessor endpoint would enable developers to easily extended HMaster functionality/features. As is the case for region server grouping.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7042) Master Coprocessor Endpoint
Posted by "Francis Liu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488384#comment-13488384 ]
Francis Liu commented on HBASE-7042:
------------------------------------
Gary, Yep, I'll be working on a trunk patch as well. I did 0.94 first as it's what we'll be deploying to production. This change shouldn't break binary backward compatibity for 0.94?
> Master Coprocessor Endpoint
> ---------------------------
>
> Key: HBASE-7042
> URL: https://issues.apache.org/jira/browse/HBASE-7042
> Project: HBase
> Issue Type: Sub-task
> Reporter: Francis Liu
> Assignee: Francis Liu
> Fix For: 0.96.0
>
> Attachments: HBASE-7042_94.patch
>
>
> Having support for a master coprocessor endpoint would enable developers to easily extended HMaster functionality/features. As is the case for region server grouping.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7042) Master Coprocessor Endpoint
Posted by "Francis Liu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488394#comment-13488394 ]
Francis Liu commented on HBASE-7042:
------------------------------------
{quote}
Can we use the same Exec and ExecResponse classes for both master and RS endpoint invocations? (I.e. get rid of MasterExec and MasterExecResult?)
{quote}
It's not possible since the region classes contains relations to regions/row/etc.
{quote}
The patch handles system coprocessors, those registered by Configuration, but what about table coprocessors? Table coprocessors are loaded as dictated by table attributes. Should the master load those when creating or updating table schema and discovers that coprocessor load directives now exist in the schema? We wouldn't need to load a table coprocessor into the master if the table is disabled, but once the table is enabled, then we would?
{quote}
Do we really need a table specific MasterEndpoint? For Region's it was really useful since it'd enable you to do distributed computation across regions apart from being able to extend Region/RegionServer functionality. In the master's case, most use cases would be to extend the master's functionality?
> Master Coprocessor Endpoint
> ---------------------------
>
> Key: HBASE-7042
> URL: https://issues.apache.org/jira/browse/HBASE-7042
> Project: HBase
> Issue Type: Sub-task
> Reporter: Francis Liu
> Assignee: Francis Liu
> Fix For: 0.96.0
>
> Attachments: HBASE-7042_94.patch
>
>
> Having support for a master coprocessor endpoint would enable developers to easily extended HMaster functionality/features. As is the case for region server grouping.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7042) Master Coprocessor Endpoint
Posted by "Gary Helmling (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488347#comment-13488347 ]
Gary Helmling commented on HBASE-7042:
--------------------------------------
Unfortunately this code would need to be completely reworked for the PB service support in 0.96. The Writable based CoprocessorProtocol support you're using will be completely removed for 0.96 (see HBASE-6895).
Since 0.96 seems like the right target for a new feature like this, would you mind redoing this based on the CoprocessorService handling in trunk?
> Master Coprocessor Endpoint
> ---------------------------
>
> Key: HBASE-7042
> URL: https://issues.apache.org/jira/browse/HBASE-7042
> Project: HBase
> Issue Type: Sub-task
> Reporter: Francis Liu
> Assignee: Francis Liu
> Fix For: 0.96.0
>
> Attachments: HBASE-7042_94.patch
>
>
> Having support for a master coprocessor endpoint would enable developers to easily extended HMaster functionality/features. As is the case for region server grouping.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7042) Master Coprocessor Endpoint
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497260#comment-13497260 ]
Ted Yu commented on HBASE-7042:
-------------------------------
@Stack:
See https://reviews.apache.org/r/7890/ for Gary's comments which have been addressed by Francis.
bq. Two comments below for fix up, but otherwise the patch looks good to me.
I am +1 on patch v3.
> Master Coprocessor Endpoint
> ---------------------------
>
> Key: HBASE-7042
> URL: https://issues.apache.org/jira/browse/HBASE-7042
> Project: HBase
> Issue Type: Sub-task
> Reporter: Francis Liu
> Assignee: Francis Liu
> Fix For: 0.96.0
>
> Attachments: HBASE-7042_2.patch, HBASE-7042_3.patch, HBASE-7042_94_2.patch, HBASE-7042_94_3.patch, HBASE-7042_94_4.patch, HBASE-7042_94_4.patch, HBASE-7042_94.patch, HBASE-7042.patch
>
>
> Having support for a master coprocessor endpoint would enable developers to easily extended HMaster functionality/features. As is the case for region server grouping.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7042) Master Coprocessor Endpoint
Posted by "Francis Liu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488838#comment-13488838 ]
Francis Liu commented on HBASE-7042:
------------------------------------
{quote}
The issue I see with supporting only system coprocessors is it requires deployment by way of XML config update as the sole option, which requires a process restart. Table CPs can be deployed to HDFS and then loaded dynamically with a schema update without needing to stop any process. Not supporting this latter option on the master seems a shortcut and limiting.
{quote}
Don't we already have a precedent for this with MasterObserver? From a use case perspective it would seem to me that Master Coprocessors are cluster owner decisions and are prolly fewer and slower moving than region coprocessors which are owned by table owners. In the former case updating and restarting the master should be acceptable?
> Master Coprocessor Endpoint
> ---------------------------
>
> Key: HBASE-7042
> URL: https://issues.apache.org/jira/browse/HBASE-7042
> Project: HBase
> Issue Type: Sub-task
> Reporter: Francis Liu
> Assignee: Francis Liu
> Fix For: 0.96.0
>
> Attachments: HBASE-7042_94.patch
>
>
> Having support for a master coprocessor endpoint would enable developers to easily extended HMaster functionality/features. As is the case for region server grouping.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7042) Master Coprocessor Endpoint
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488105#comment-13488105 ]
Andrew Purtell commented on HBASE-7042:
---------------------------------------
Seems reasonable.
On the current patch:
- Can we use the same Exec and ExecResponse classes for both master and RS endpoint invocations? (I.e. get rid of MasterExec and MasterExecResult?)
- The patch handles system coprocessors, those registered by Configuration, but what about table coprocessors? Table coprocessors are loaded as dictated by table attributes. Should the master load those when creating or updating table schema and discovers that coprocessor load directives now exist in the schema? We wouldn't need to load a table coprocessor into the master if the table is disabled, but once the table is enabled, then we would?
> Master Coprocessor Endpoint
> ---------------------------
>
> Key: HBASE-7042
> URL: https://issues.apache.org/jira/browse/HBASE-7042
> Project: HBase
> Issue Type: Sub-task
> Reporter: Francis Liu
> Assignee: Francis Liu
> Fix For: 0.96.0
>
> Attachments: HBASE-7042_94.patch
>
>
> Having support for a master coprocessor endpoint would enable developers to easily extended HMaster functionality/features. As is the case for region server grouping.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7042) Master Coprocessor Endpoint
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497660#comment-13497660 ]
Hudson commented on HBASE-7042:
-------------------------------
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #261 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/261/])
HBASE-7042 Master Coprocessor Endpoint (Francis Liu) (Revision 1409257)
Result = FAILURE
tedyu :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/HTable.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/CoprocessorRpcChannel.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/MasterCoprocessorRpcChannel.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RegionCoprocessorRpcChannel.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterServices.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/generated/MasterAdminProtos.java
* /hbase/trunk/hbase-server/src/main/protobuf/MasterAdmin.proto
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorEndpoint.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java
> Master Coprocessor Endpoint
> ---------------------------
>
> Key: HBASE-7042
> URL: https://issues.apache.org/jira/browse/HBASE-7042
> Project: HBase
> Issue Type: Sub-task
> Reporter: Francis Liu
> Assignee: Francis Liu
> Fix For: 0.96.0
>
> Attachments: HBASE-7042_2.patch, HBASE-7042_3.patch, HBASE-7042_94_2.patch, HBASE-7042_94_3.patch, HBASE-7042_94_4.patch, HBASE-7042_94_4.patch, HBASE-7042_94.patch, HBASE-7042.patch
>
>
> Having support for a master coprocessor endpoint would enable developers to easily extended HMaster functionality/features. As is the case for region server grouping.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7042) Master Coprocessor Endpoint
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497621#comment-13497621 ]
Hudson commented on HBASE-7042:
-------------------------------
Integrated in HBase-0.94 #592 (See [https://builds.apache.org/job/HBase-0.94/592/])
HBASE-7042 Master Coprocessor Endpoint (Francis) (Revision 1409431)
Result = FAILURE
tedyu :
Files :
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/coprocessor/Exec.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/coprocessor/ExecResult.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/ipc/MasterExecRPCInvoker.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/MasterServices.java
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorEndpoint.java
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java
> Master Coprocessor Endpoint
> ---------------------------
>
> Key: HBASE-7042
> URL: https://issues.apache.org/jira/browse/HBASE-7042
> Project: HBase
> Issue Type: Sub-task
> Reporter: Francis Liu
> Assignee: Francis Liu
> Fix For: 0.96.0
>
> Attachments: HBASE-7042_2.patch, HBASE-7042_3.patch, HBASE-7042_94_2.patch, HBASE-7042_94_3.patch, HBASE-7042_94_4.patch, HBASE-7042_94_4.patch, HBASE-7042_94.patch, HBASE-7042.patch
>
>
> Having support for a master coprocessor endpoint would enable developers to easily extended HMaster functionality/features. As is the case for region server grouping.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7042) Master Coprocessor Endpoint
Posted by "Francis Liu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Francis Liu updated HBASE-7042:
-------------------------------
Attachment: HBASE-7042_94_2.patch
> Master Coprocessor Endpoint
> ---------------------------
>
> Key: HBASE-7042
> URL: https://issues.apache.org/jira/browse/HBASE-7042
> Project: HBase
> Issue Type: Sub-task
> Reporter: Francis Liu
> Assignee: Francis Liu
> Fix For: 0.96.0
>
> Attachments: HBASE-7042_94_2.patch, HBASE-7042_94.patch
>
>
> Having support for a master coprocessor endpoint would enable developers to easily extended HMaster functionality/features. As is the case for region server grouping.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira