You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by geomacy <gi...@git.apache.org> on 2016/07/22 17:07:38 UTC
[GitHub] brooklyn-server pull request #271: Do not merge, for review: Move karaf dist...
GitHub user geomacy opened a pull request:
https://github.com/apache/brooklyn-server/pull/271
Do not merge, for review: Move karaf distribution to brooklyn-dist.
This PR is the first of three that together move the karaf distribution to brooklyn-dist and separate out the software from brooklyn-library into separate catalog bom and feature files.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/geomacy/brooklyn-server move-karaf-to-dist
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/271.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #271
----
commit e020f7e9d8fcc2e37a06dc9785bb2db74451aa67
Author: Geoff Macartney <ge...@cloudsoftcorp.com>
Date: 2016-07-22T11:34:08Z
Move karaf distribution to brooklyn-dist.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request #271: Do not merge, for review: Move karaf dist...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/271#discussion_r72025419
--- Diff: karaf/features/src/main/feature/feature.xml ---
@@ -276,60 +276,6 @@
<feature>jclouds-api-filesystem</feature>
<bundle start-level="85">mvn:org.apache.brooklyn/brooklyn-locations-jclouds/${project.version}</bundle>
- <feature>brooklyn-software-winrm</feature>
--- End diff --
`winrm` is part of core. Don't see where do you include the feature back (in -library and -dist PRs)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request #271: Move karaf distribution to brooklyn-dist.
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/271
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #271: Do not merge, for review: Move karaf distributio...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the issue:
https://github.com/apache/brooklyn-server/pull/271
LGTM (apart from the missing winrm dependency)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #271: Move karaf distribution to brooklyn-dist.
Posted by duncangrant <gi...@git.apache.org>.
Github user duncangrant commented on the issue:
https://github.com/apache/brooklyn-server/pull/271
I've tested this - all seems to work
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #271: Do not merge, for review: Move karaf distributio...
Posted by geomacy <gi...@git.apache.org>.
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/271
Review comments applied, squashed and pushed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request #271: Do not merge, for review: Move karaf dist...
Posted by geomacy <gi...@git.apache.org>.
Github user geomacy commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/271#discussion_r72227840
--- Diff: karaf/features/src/main/feature/feature.xml ---
@@ -276,60 +276,6 @@
<feature>jclouds-api-filesystem</feature>
<bundle start-level="85">mvn:org.apache.brooklyn/brooklyn-locations-jclouds/${project.version}</bundle>
- <feature>brooklyn-software-winrm</feature>
--- End diff --
I had meant to move it to brooklyn-library and then realised it didn't belong there, must have missed putting it back here. Will fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---