You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ratis.apache.org by GitBox <gi...@apache.org> on 2020/06/12 12:33:02 UTC

[GitHub] [incubator-ratis] runzhiwang opened a new pull request #123: RATIS-904. Failed UT: testFileStoreAsync

runzhiwang opened a new pull request #123:
URL: https://github.com/apache/incubator-ratis/pull/123


   ## What changes were proposed in this pull request?
   
   1. It's hard to finish write one 10M file and hundred 1M file in 100 seconds, if the leader re-election happens when write, timeout will happens.
   
   2. `if (offset < writeSize)`  we can not throw exception. For example,  if leader finish write data with offset = 4096 and length = 4096, then writeSize become 8192, and 2 follower has not written the data with offset = 4096 and length = 4096, then start a leader re-election. So client will retry send the data with offset = 4096 and length = 4096, then offset < writeSize in leader. 
   If we throw exception, leader can not write successfully forever.
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/RATIS-904
   
   ## How was this patch tested?
   
   Existed test.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ratis] runzhiwang commented on pull request #123: RATIS-904. Failed UT: testFileStoreAsync

Posted by GitBox <gi...@apache.org>.
runzhiwang commented on pull request #123:
URL: https://github.com/apache/incubator-ratis/pull/123#issuecomment-643248283


   @bshashikant @lokeshj1703 Could you help review this patch ? Thank you very much.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ratis] bshashikant merged pull request #123: RATIS-904. Fix Failed UT: testFileStoreAsync

Posted by GitBox <gi...@apache.org>.
bshashikant merged pull request #123:
URL: https://github.com/apache/incubator-ratis/pull/123


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org