You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/12/15 23:09:58 UTC
[jira] [Commented] (BEAM-1125) Rename PTransform.apply to
PTransform.expand
[ https://issues.apache.org/jira/browse/BEAM-1125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15752796#comment-15752796 ]
ASF GitHub Bot commented on BEAM-1125:
--------------------------------------
GitHub user aaltay opened a pull request:
https://github.com/apache/incubator-beam/pull/1634
[BEAM-1125] Rename PTransform.apply() to PTransform.expand()
Rename apply function to expand to match the recent change in the Java SDK.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aaltay/incubator-beam expand
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1634.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1634
----
commit b6a0974375e5c7414a52cd3ffd2a9e9fe8d1889f
Author: Ahmet Altay <al...@google.com>
Date: 2016-12-15T22:27:08Z
Rename PTransform.apply() to PTransform.expand()
----
> Rename PTransform.apply to PTransform.expand
> --------------------------------------------
>
> Key: BEAM-1125
> URL: https://issues.apache.org/jira/browse/BEAM-1125
> Project: Beam
> Issue Type: Bug
> Components: sdk-py
> Reporter: Ahmet Altay
> Assignee: Ahmet Altay
> Labels: sdk-consistency
>
> For context see:
> [BEAM-438] https://issues.apache.org/jira/browse/BEAM-438
> [PR #1538] https://github.com/apache/incubator-beam/pull/1538
> https://lists.apache.org/thread.html/b4d9bcfbfeaa5dbcd5b68fd2344cdffe45587ff88cb714638504e759@%3Cdev.beam.apache.org%3E
> This requires renaming the apply method, updating all custom PTransforms, and runners where transform.apply is called. (Based on the Java PR, this could be easily done with a refactoring tool.)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)