You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by skambha <gi...@git.apache.org> on 2017/12/07 18:06:39 UTC
[GitHub] spark pull request #19921: [SPARK-22452][SQL] Add getDouble to DataSourceV2O...
GitHub user skambha opened a pull request:
https://github.com/apache/spark/pull/19921
[SPARK-22452][SQL] Add getDouble to DataSourceV2Options
- Implemented getDouble method in DataSourceV2Options
- Add unit test
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/skambha/spark ds2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/19921.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19921
----
commit 2d4c2b0bdf89badf25f2d1d98903125e48e7cd5c
Author: Sunitha Kambhampati <sk...@us.ibm.com>
Date: 2017-12-07T17:59:11Z
Add getDouble to DataSourceV2Options and add unit test
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19921: [SPARK-22452][SQL] Add getDouble to DataSourceV2Options
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19921
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19921: [SPARK-22452][SQL] Add getDouble to DataSourceV2Options
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19921
**[Test build #84626 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84626/testReport)** for PR 19921 at commit [`2d4c2b0`](https://github.com/apache/spark/commit/2d4c2b0bdf89badf25f2d1d98903125e48e7cd5c).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19921: [SPARK-22452][SQL] Add getDouble to DataSourceV2Options
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19921
**[Test build #84626 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84626/testReport)** for PR 19921 at commit [`2d4c2b0`](https://github.com/apache/spark/commit/2d4c2b0bdf89badf25f2d1d98903125e48e7cd5c).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19921: [SPARK-22452][SQL] Add getDouble to DataSourceV2Options
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19921
thanks, merging to master!
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19921: [SPARK-22452][SQL] Add getDouble to DataSourceV2Options
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19921
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19921: [SPARK-22452][SQL] Add getDouble to DataSourceV2O...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19921
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19921: [SPARK-22452][SQL] Add getDouble to DataSourceV2Options
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19921
ok to test
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19921: [SPARK-22452][SQL] Add getDouble to DataSourceV2Options
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19921
LGTM
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19921: [SPARK-22452][SQL] Add getDouble to DataSourceV2Options
Posted by skambha <gi...@git.apache.org>.
Github user skambha commented on the issue:
https://github.com/apache/spark/pull/19921
Thanks @cloud-fan, @gatorsmile
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19921: [SPARK-22452][SQL] Add getDouble to DataSourceV2Options
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19921
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84626/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org