[GitHub] rymanluk commented on a change in pull request #351: Bt5 extended advertising - host part

[gi...@git.apache.org]

rymanluk commented on a change in pull request #351: Bt5 extended advertising - host part
URL: https://github.com/apache/incubator-mynewt-core/pull/351#discussion_r124522683
 
 

 ##########
 File path: net/nimble/host/src/ble_gap.c
 ##########
 @@ -2154,6 +2155,66 @@ ble_gap_disc_tx_params(uint8_t own_addr_type,
     return 0;
 }
 
+#if MYNEWT_VAL(BLE_EXT_ADV)
+static int
+ble_gap_ext_disc_tx_params(uint8_t own_addr_type, uint8_t filter_policy,
+                       const struct ble_hs_hci_ext_scan_param *uncoded_params,
+                       const struct ble_hs_hci_ext_scan_param *coded_params)
+{
+    uint8_t buf[BLE_HCI_CMD_HDR_LEN + BLE_HCI_LE_EXT_SCAN_BASE_LEN +
+                                2 * BLE_HCI_LE_EXT_SCAN_SINGLE_PARAM_LEN];
+    uint8_t phy_mask = 0;
+    struct ble_hs_hci_ext_scan_param param[2] = {0};
 
 Review comment:
   @ccollins476ad 
   Actually it compiles. I think that it would not compile if there would be anything else than 0.
   Anyway, I can do suggested fix
   
   @wes3  Thanks will try that
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services