You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2020/09/21 20:00:12 UTC
[kudu-CR](branch-1.13.x) [kudu-tool-test] fix ClusterNameResolverFileCorrupt with glibc 2.31
Hello Kudu Jenkins, Grant Henke,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/16488
to review the following change.
Change subject: [kudu-tool-test] fix ClusterNameResolverFileCorrupt with glibc 2.31
......................................................................
[kudu-tool-test] fix ClusterNameResolverFileCorrupt with glibc 2.31
This patch updates the expected error message in the
ToolTest.ClusterNameResolverFileCorrupt scenario to make the test
pass on Ubuntu 20.04 LTS (it should fix it on other platforms which
use newer glibc versions).
Without this patch, the scenario failed on Ubuntu 20.04 LTS:
src/kudu/tools/kudu-tool-test.cc:637: Failure
Value of: stderr
Expected: has substring "Network error: Could not connect to the cluster: unable to resolve address for bad: Name or service not known"
Actual: "W0919 23:39:50.032436 1041101 flags.cc:405] Enabled unsafe flag: --openssl_security_level_override=0\nW0919 23:39:50.032559 1041101 flags.cc:405] Enabled unsafe flag: --never_fsync=true\nNetwork error: Could not connect to the cluster: unable to resolve address for bad: Temporary failure in name resolution"
Instead of tailoring the errno-converted message for every platform,
it's easier to rely in the essential part of it that corresponds
to the DNS resolver failure.
In addition, I did a minor cleanup on the code around, removing
calls of the Substitute() function where a fixed string is enough.
Change-Id: I3eb0991cb2d4311051e55e231cb4fe6d065aa632
Reviewed-on: http://gerrit.cloudera.org:8080/16478
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke <gr...@apache.org>
(cherry picked from commit d8ab44c6864172d4b990adf31f7d84fd33e4ae15)
---
M src/kudu/tools/kudu-tool-test.cc
1 file changed, 4 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/88/16488/1
--
To view, visit http://gerrit.cloudera.org:8080/16488
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.13.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3eb0991cb2d4311051e55e231cb4fe6d065aa632
Gerrit-Change-Number: 16488
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.13.x) [kudu-tool-test] fix ClusterNameResolverFileCorrupt with glibc 2.31
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16488 )
Change subject: [kudu-tool-test] fix ClusterNameResolverFileCorrupt with glibc 2.31
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16488
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.13.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I3eb0991cb2d4311051e55e231cb4fe6d065aa632
Gerrit-Change-Number: 16488
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 22 Sep 2020 16:07:31 +0000
Gerrit-HasComments: No