You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by tg...@apache.org on 2016/11/29 23:38:11 UTC
[1/2] incubator-beam git commit: Remove
TransformApplicationsForTesting
Repository: incubator-beam
Updated Branches:
refs/heads/master 8d127beb8 -> b1f7013d8
Remove TransformApplicationsForTesting
This field is mutated but never queried.
Remove Pipeline#addValueInternal
This method is never called and not suitable for use.
Project: http://git-wip-us.apache.org/repos/asf/incubator-beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-beam/commit/1184bfa7
Tree: http://git-wip-us.apache.org/repos/asf/incubator-beam/tree/1184bfa7
Diff: http://git-wip-us.apache.org/repos/asf/incubator-beam/diff/1184bfa7
Branch: refs/heads/master
Commit: 1184bfa7a3ee5d58d65c9ba9200e91f71856ce4a
Parents: 8d127be
Author: Thomas Groh <tg...@google.com>
Authored: Tue Nov 29 14:30:09 2016 -0800
Committer: Thomas Groh <tg...@google.com>
Committed: Tue Nov 29 15:37:57 2016 -0800
----------------------------------------------------------------------
.../src/main/java/org/apache/beam/sdk/Pipeline.java | 15 ---------------
1 file changed, 15 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/1184bfa7/sdks/java/core/src/main/java/org/apache/beam/sdk/Pipeline.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/Pipeline.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/Pipeline.java
index e188b35..9edf496 100644
--- a/sdks/java/core/src/main/java/org/apache/beam/sdk/Pipeline.java
+++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/Pipeline.java
@@ -17,8 +17,6 @@
*/
package org.apache.beam.sdk;
-import com.google.common.collect.HashMultimap;
-import com.google.common.collect.Multimap;
import java.util.ArrayList;
import java.util.Collection;
import java.util.HashSet;
@@ -329,8 +327,6 @@ public class Pipeline {
private Collection<PValue> values = new ArrayList<>();
private Set<String> usedFullNames = new HashSet<>();
private CoderRegistry coderRegistry;
- private Multimap<PTransform<?, ?>, AppliedPTransform<?, ?, ?>> transformApplicationsForTesting =
- HashMultimap.create();
/**
* @deprecated replaced by {@link #Pipeline(PipelineRunner, PipelineOptions)}
@@ -399,7 +395,6 @@ public class Pipeline {
AppliedPTransform<?, ?, ?> applied = AppliedPTransform.of(
child.getFullName(), input, output, transform);
- transformApplicationsForTesting.put(transform, applied);
// recordAsOutput is a NOOP if already called;
output.recordAsOutput(applied);
verifyOutputState(output, child);
@@ -513,14 +508,4 @@ public class Pipeline {
private String buildName(String namePrefix, String name) {
return namePrefix.isEmpty() ? name : namePrefix + "/" + name;
}
-
- /**
- * Adds the given {@link PValue} to this {@link Pipeline}.
- *
- * <p>For internal use only.
- */
- public void addValueInternal(PValue value) {
- this.values.add(value);
- LOG.debug("Adding {} to {}", value, this);
- }
}
[2/2] incubator-beam git commit: This closes #1457
Posted by tg...@apache.org.
This closes #1457
Project: http://git-wip-us.apache.org/repos/asf/incubator-beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-beam/commit/b1f7013d
Tree: http://git-wip-us.apache.org/repos/asf/incubator-beam/tree/b1f7013d
Diff: http://git-wip-us.apache.org/repos/asf/incubator-beam/diff/b1f7013d
Branch: refs/heads/master
Commit: b1f7013d88cea1290f92898b36d6a761546f8e60
Parents: 8d127be 1184bfa
Author: Thomas Groh <tg...@google.com>
Authored: Tue Nov 29 15:37:58 2016 -0800
Committer: Thomas Groh <tg...@google.com>
Committed: Tue Nov 29 15:37:58 2016 -0800
----------------------------------------------------------------------
.../src/main/java/org/apache/beam/sdk/Pipeline.java | 15 ---------------
1 file changed, 15 deletions(-)
----------------------------------------------------------------------