[GitHub] [cordova-plugin-whitelist] jcesarmobile commented on a change in pull request #59: breaking: deprecate plugin

[GitBox <gi...@apache.org>]

jcesarmobile commented on a change in pull request #59:
URL: https://github.com/apache/cordova-plugin-whitelist/pull/59#discussion_r621214635



##########
File path: package.json
##########
@@ -26,7 +26,8 @@
         "cordova-android": ">=4.0.0"
       },
       "2.0.0": {
-        "cordova": ">100"
+        "cordova": ">100",

Review comment:
       What the `"cordova": ">100"` does is to prevent the install of the plugin in case we do a major release and forget to adjust the engines properly, as it will prevent the install, we will notice and update the engines in a new patch release.
   What we usually do is to move it to the next major, in this case 3.0.0, but considering that 2.0.0 will be the last one, this line can just be removed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org