You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by kiszk <gi...@git.apache.org> on 2018/10/21 17:56:27 UTC

[GitHub] spark pull request #22754: [SPARK-25776][CORE][MINOR]The disk write buffer s...

Github user kiszk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22754#discussion_r226871894
  
    --- Diff: core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeSorterSpillWriter.java ---
    @@ -62,6 +62,8 @@ public UnsafeSorterSpillWriter(
           int fileBufferSize,
           ShuffleWriteMetrics writeMetrics,
           int numRecordsToWrite) throws IOException {
    +    // space used by prefix + len is (4 + 8) bytes
    --- End diff --
    
    Can we refine this comment to explain more than 12 bytes are required?
    For example, `space used by prefix + len + recordLength is more than 4 + 8 bytes`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org