You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "rgala (via GitHub)" <gi...@apache.org> on 2023/07/25 12:59:15 UTC

[GitHub] [camel] rgala opened a new pull request, #10821: org.apache.kafka.clients.producer.internals.DefaultPartitioner is dep…

rgala opened a new pull request, #10821:
URL: https://github.com/apache/camel/pull/10821

   Empty partitioner for default partitioning behavior


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] orpiske commented on a diff in pull request #10821: CAMEL-19651: camel-kafka - Use default partitioning logic as the default

Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on code in PR #10821:
URL: https://github.com/apache/camel/pull/10821#discussion_r1273652060


##########
components/camel-kafka/src/main/java/org/apache/camel/component/kafka/KafkaConstants.java:
##########
@@ -61,7 +61,7 @@ public final class KafkaConstants {
 
     public static final String KAFKA_DEFAULT_SERIALIZER = "org.apache.kafka.common.serialization.StringSerializer";
     public static final String KAFKA_DEFAULT_DESERIALIZER = "org.apache.kafka.common.serialization.StringDeserializer";
-    public static final String KAFKA_DEFAULT_PARTITIONER = "org.apache.kafka.clients.producer.internals.DefaultPartitioner";
+    public static final String KAFKA_DEFAULT_PARTITIONER = "";

Review Comment:
   +1 to remove it. 
   
   Just, please, beware that there are a couple of tests referring to this constant. They will need to be adjusted accordingly. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] rgala commented on pull request #10821: org.apache.kafka.clients.producer.internals.DefaultPartitioner is dep…

Posted by "rgala (via GitHub)" <gi...@apache.org>.
rgala commented on PR #10821:
URL: https://github.com/apache/camel/pull/10821#issuecomment-1649819119

   Of course, there you go: [CAMEL-19651] (https://issues.apache.org/jira/browse/CAMEL-19651)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] github-actions[bot] commented on pull request #10821: org.apache.kafka.clients.producer.internals.DefaultPartitioner is dep…

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10821:
URL: https://github.com/apache/camel/pull/10821#issuecomment-1649797903

   :star2: Thank you for your contribution to the Apache Camel project! :star2: 
   
   :camel: Maintainers, please note that first-time contributors *require manual approval* for the GitHub Actions to run.
   
   :warning: Please note that the changes on this PR may be **tested automatically** if they change components.
   
   :robot: Use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
   
   If necessary Apache Camel Committers may access logs and test results in the job summaries!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] essobedo commented on pull request #10821: org.apache.kafka.clients.producer.internals.DefaultPartitioner is dep…

Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo commented on PR #10821:
URL: https://github.com/apache/camel/pull/10821#issuecomment-1649811465

   Thx for the PR, but could you please create a JIRA ticket first in https://issues.apache.org/jira/projects/CAMEL to describe the problem and to better track it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] essobedo commented on pull request #10821: CAMEL-19651: camel-kafka - Use default partitioning logic as the default

Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo commented on PR #10821:
URL: https://github.com/apache/camel/pull/10821#issuecomment-1651062261

   There are failing tests https://github.com/apache/camel/actions/runs/5659712656/attempts/2#summary-15335168165
   
   Try to launch `mvn clean install -pl components/camel-kafka` from the project root directory


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] rgala commented on a diff in pull request #10821: CAMEL-19651: camel-kafka - Use default partitioning logic as the default

Posted by "rgala (via GitHub)" <gi...@apache.org>.
rgala commented on code in PR #10821:
URL: https://github.com/apache/camel/pull/10821#discussion_r1273819407


##########
components/camel-kafka/src/main/java/org/apache/camel/component/kafka/KafkaConstants.java:
##########
@@ -61,7 +61,7 @@ public final class KafkaConstants {
 
     public static final String KAFKA_DEFAULT_SERIALIZER = "org.apache.kafka.common.serialization.StringSerializer";
     public static final String KAFKA_DEFAULT_DESERIALIZER = "org.apache.kafka.common.serialization.StringDeserializer";
-    public static final String KAFKA_DEFAULT_PARTITIONER = "org.apache.kafka.clients.producer.internals.DefaultPartitioner";
+    public static final String KAFKA_DEFAULT_PARTITIONER = "";

Review Comment:
   I have removed the constant



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] essobedo commented on pull request #10821: org.apache.kafka.clients.producer.internals.DefaultPartitioner is dep…

Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo commented on PR #10821:
URL: https://github.com/apache/camel/pull/10821#issuecomment-1649846785

   For the sake of clarity/consistency, could you please change your commit message to something of the type: "CAMEL-19651: camel-kafka - <my short description here>"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] essobedo merged pull request #10821: CAMEL-19651: camel-kafka - Use default partitioning logic as the default

Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo merged PR #10821:
URL: https://github.com/apache/camel/pull/10821


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] essobedo commented on pull request #10821: CAMEL-19651: camel-kafka - Use default partitioning logic as the default

Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo commented on PR #10821:
URL: https://github.com/apache/camel/pull/10821#issuecomment-1649894379

   Please use the same commit message as the new PR title.
   
   Regarding the build failure, there are some uncommitted files, so you will need to launch `mvn clean install -Dquickly` from the root of the camel project, see https://camel.apache.org/camel-core/contributing/#_building_camel_4 for more details


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] essobedo commented on a diff in pull request #10821: CAMEL-19651: camel-kafka - Use default partitioning logic as the default

Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo commented on code in PR #10821:
URL: https://github.com/apache/camel/pull/10821#discussion_r1273589140


##########
components/camel-kafka/src/main/java/org/apache/camel/component/kafka/KafkaConstants.java:
##########
@@ -61,7 +61,7 @@ public final class KafkaConstants {
 
     public static final String KAFKA_DEFAULT_SERIALIZER = "org.apache.kafka.common.serialization.StringSerializer";
     public static final String KAFKA_DEFAULT_DESERIALIZER = "org.apache.kafka.common.serialization.StringDeserializer";
-    public static final String KAFKA_DEFAULT_PARTITIONER = "org.apache.kafka.clients.producer.internals.DefaultPartitioner";
+    public static final String KAFKA_DEFAULT_PARTITIONER = "";

Review Comment:
   About the change itself, I would rather prefer to have it removed instead of keeping a static field with an empty String as value, but we can wait for other points of views



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] essobedo commented on pull request #10821: CAMEL-19651: camel-kafka - Use default partitioning logic as the default

Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo commented on PR #10821:
URL: https://github.com/apache/camel/pull/10821#issuecomment-1649901222

   Since a default behavior change, I believe you will need to update the migration guide too https://github.com/apache/camel/blob/main/docs/user-manual/modules/ROOT/pages/camel-4-migration-guide.adoc


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org