[GitHub] [flink] liuml07 opened a new pull request, #21471: [FLINK-29940] ExecutionGraph logs job state change at WARN level when job fails

[GitBox <gi...@apache.org>]

liuml07 opened a new pull request, #21471:
URL: https://github.com/apache/flink/pull/21471

   ## What is the purpose of the change
   
   When job switched to FAILED state, the log is very useful to understand why it failed along with the root cause exception stack. However, the current log level is INFO - a bit inconvenient for users to search from logging with so many surrounding log lines.
   
   ## Brief change log
   
   We can log at WARN level when the job switched to FAILED state. I firstly proposed ERROR level which is only for the cases when system can not proceed normally.
   
   ## Verifying this change
   
   Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #21471: [FLINK-29940][runtime] ExecutionGraph logs job state change at WARN level when job fails

[GitBox <gi...@apache.org>]

flinkbot commented on PR #21471:
URL: https://github.com/apache/flink/pull/21471#issuecomment-1343847686

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "19c2cc5fdcaccc137649f63f8f7408496fe7ad66",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "19c2cc5fdcaccc137649f63f8f7408496fe7ad66",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 19c2cc5fdcaccc137649f63f8f7408496fe7ad66 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] liuml07 commented on pull request #21471: [FLINK-29940] ExecutionGraph logs job state change at WARN level when job fails

[GitBox <gi...@apache.org>]

liuml07 commented on PR #21471:
URL: https://github.com/apache/flink/pull/21471#issuecomment-1343846067

   Per discussion in the JIRA, I closed the non-merged old PR #21266. Later we think we can make it WARN level to make it more visible. CC: @rmetzger 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org