You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "Caideyipi (via GitHub)" <gi...@apache.org> on 2026/10/20 04:38:53 UTC
[PR] [Fix] Preserve negative LOAD partitions and reject incomplete PREPARE [iotdb]
Caideyipi opened a new pull request, #18930:
URL: https://github.com/apache/iotdb/pull/18930
## Description
Recovering a split LOAD drops the minus sign from negative time-partition starts in staged filenames; `Long.MIN_VALUE` also overflows during parsing. Parse the signed partition start by removing the known database/region prefix and TsFile suffix so subsequent pieces resume the original partition.
PREPARE only checks existing writers and skips files without durable chunk records. It can therefore accept an entirely missing partition or a header-only staged file and import incomplete data. Validate every staged and coordinator-announced partition before sealing any file, allowing missing pieces to be supplied before a retry.
These staging and recovery fixes are independent of #18927, which assigns IoTConsensusV2 progress at COMMIT. That PR's patch also passes `git apply --check` on this branch.
## Validation
- All four new regression tests fail on the original implementation and pass with the fix. Recovery tests read every point written before and after recovery; PREPARE tests verify rejection, successful preparation after missing data arrives, and readable output.
- 67 targeted LOAD unit tests passed, covering recovery, table schemas, modifications, snapshots, split coverage, and progress.
- Full-reactor production and test sources compiled successfully in both the default and `with-zh-locale` profiles (`test-compile -DskipTests`, 53 modules each).
- Spotless, Checkstyle, and `git diff --check` passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix] Harden split LOAD recovery, deletion dispatch and memory bounds [iotdb]
Posted by "jt2594838 (via GitHub)" <gi...@apache.org>.
jt2594838 merged PR #18930:
URL: https://github.com/apache/iotdb/pull/18930
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org