[jira] [Commented] (HIVE-8282) Potential null deference in ConvertJoinMapJoin#convertJoinBucketMapJoin()

["Ted Yu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-8282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14153232#comment-14153232 ] 

Ted Yu commented on HIVE-8282:
------------------------------

lgtm

nit: 'bucket map join' was mentioned in the log message @ line 321.
It should appear in the new message as well.

> Potential null deference in ConvertJoinMapJoin#convertJoinBucketMapJoin()
> -------------------------------------------------------------------------
>
>                 Key: HIVE-8282
>                 URL: https://issues.apache.org/jira/browse/HIVE-8282
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 0.14.0
>            Reporter: Ted Yu
>            Priority: Minor
>         Attachments: HIVE-8282.patch
>
>
> In convertJoinMapJoin():
> {code}
>     for (Operator<? extends OperatorDesc> parentOp : joinOp.getParentOperators()) {
>       if (parentOp instanceof MuxOperator) {
>         return null;
>       }
>     }
> {code}
> NPE would result if convertJoinMapJoin() returns null:
> {code}
>     MapJoinOperator mapJoinOp = convertJoinMapJoin(joinOp, context, bigTablePosition);
>     MapJoinDesc joinDesc = mapJoinOp.getConf();
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)