You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/05/04 21:52:40 UTC

[GitHub] [pulsar] mattisonchao commented on a diff in pull request #14887: [feature][admin] Support reset cluster replicator cursor

mattisonchao commented on code in PR #14887:
URL: https://github.com/apache/pulsar/pull/14887#discussion_r865415868


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:
##########
@@ -2278,89 +2279,60 @@ private void internalCreateSubscriptionForNonPartitionedTopic(
         });
     }
 
-    protected void internalResetCursorOnPosition(AsyncResponse asyncResponse, String subName, boolean authoritative,
+    protected CompletableFuture<Void> internalResetCursorOnPosition(String name, boolean authoritative,

Review Comment:
   Fixed. PTAL @RobertIndie 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org