You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/27 12:48:43 UTC
[GitHub] [pulsar] nicoloboschi opened a new pull request, #17857: [ci] Add JDK source compatibility job for building pulsar-client-all
nicoloboschi opened a new pull request, #17857:
URL: https://github.com/apache/pulsar/pull/17857
### Motivation
https://github.com/apache/pulsar/pull/17198 breaks inadvertently the jdk8 compatibility for the client and the CI didn't failed.
We already have the maven rule but it's not enough because you can still add dependency to pulsar-client that are not source compatible with JDK8.
The CI currently only verify binary compatibility.
### Modifications
* Add a simple clean install in the jdk8 and jdk11 tests to verify all the dependent modules of `pulsar-client-all` are source compatible with JDK8 and JDK11
- [x] `doc-not-needed`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi closed pull request #17857: [ci] Add JDK source compatibility job for building pulsar-client-all
Posted by GitBox <gi...@apache.org>.
nicoloboschi closed pull request #17857: [ci] Add JDK source compatibility job for building pulsar-client-all
URL: https://github.com/apache/pulsar/pull/17857
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #17857: [ci] Add JDK source compatibility job for building pulsar-client-all
Posted by GitBox <gi...@apache.org>.
lhotari commented on PR #17857:
URL: https://github.com/apache/pulsar/pull/17857#issuecomment-1259745615
I'd suggest closing this PR and instead adding https://www.mojohaus.org/extra-enforcer-rules/enforceBytecodeVersion.html to #17855 changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi commented on pull request #17857: [ci] Add JDK source compatibility job for building pulsar-client-all
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on PR #17857:
URL: https://github.com/apache/pulsar/pull/17857#issuecomment-1261099133
Closing since we adopted the Lari's idea in https://github.com/apache/pulsar/pull/17855 to set the maven enforcer plugin that is a stronger verification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org