[jira] [Commented] (IMPALA-8626) JDBC tests don't seem to be using HTTP

["Thomas Tauber-Marshall (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IMPALA-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858861#comment-16858861 ] 

Thomas Tauber-Marshall commented on IMPALA-8626:
------------------------------------------------

[~tarmstrong] So I don't think that this JIRA is actually correct - if I run the dockerized tests with TEST_START_CLUSTER_ARGS=" --impalad_args=--hs2_http_port=0 ", the http tests fail, suggesting that they really are hitting the http server when they're succeeding.

Also, if you look at the logging in the build you linked to, everything including timestamps is exactly the same for every test case, so I think there's something wrong with the logging and its doesn't necessarily reflect that the http tests are actually using the binary connection string.

For example, see https://jenkins.impala.io/job/ubuntu-16.04-dockerised-tests/465/testReport/junit/org.apache.impala.service/JdbcTest/testDecimalGetColumnTypes_1_/ which shows an error message that the http port can't be connected to even though the standard output only shows attempts to connect to the binary port.

Of course, that doesn't explain why the http tests are passing in docker without IMPALA-8623. I'm stil investigating that

> JDBC tests don't seem to be using HTTP
> --------------------------------------
>
>                 Key: IMPALA-8626
>                 URL: https://issues.apache.org/jira/browse/IMPALA-8626
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Infrastructure
>    Affects Versions: Impala 3.3.0
>            Reporter: Tim Armstrong
>            Assignee: Thomas Tauber-Marshall
>            Priority: Blocker
>
> I noticed that the parameterized JDBC tests are passing on the dockerised cluster, which shouldn't be possible because IMPALA-8623 isn't done.
> https://jenkins.impala.io/job/ubuntu-16.04-dockerised-tests/453/testReport/org.apache.impala.service/JdbcTest/
> The connection strings look identical in both cases:
> {noformat}
> 19/06/05 13:10:04 INFO testutil.ImpalaJdbcClient: Connecting to: jdbc:hive2://localhost:21050/default;auth=noSasl
> {noformat}
> {noformat}
> 19/06/05 13:10:04 INFO testutil.ImpalaJdbcClient: Connecting to: jdbc:hive2://localhost:21050/default;auth=noSasl
> {noformat}
> I was looking at related code and saw some misuse of == vs equals() for string comparison here https://github.com/apache/impala/blob/master/fe/src/test/java/org/apache/impala/testutil/ImpalaJdbcClient.java#L172
> {code}
>   private static String getConnectionStr(String connType, String authStr) {
>     String connString = DEFAULT_CONNECTION_TEMPLATE + authStr;
>     if (connType == "binary") {
>       return String.format(connString, HS2_BINARY_PORT);
>     } else {
>       Preconditions.checkState(connType == "http");
>       return String.format(connString + HTTP_TRANSPORT_SPEC, HS2_HTTP_PORT);
>     }
> }
> {code}
> But I don't think that explains what I'm seeing above.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org